-----Original Message----- From: Dimitrie O. Paun [mailto:dimi@cs.toronto.edu] Sent: Friday, January 25, 2002 9:11 AM To: Bill Medland Cc: wine-devel@winehq.com Subject: Re: Excessive clipping of text in listview
On Fri, 25 Jan 2002, Bill Medland wrote:
Does anyone know how we (again) broke the text in the large
icon display of
listview? It seems to come and go as we develop.
<blush>I probably broke it</blush>
I know the feeling. (not surprising given the size of the delta; you ought to see what my last big one would have screwed up).
The symptom. Our application has a ListView window. As of
yesterday's cvs
most of the text only displays about 2 or 3 pixels wide,
while a few are
readable.
Are you using Unicode or ANSI? Can I get access to the code to test with?
ANSI
Do you have access to the Microsoft "rowlist" sample? If so then use that but edit a couple of the labels to be longer than one line. It's the "being longer than one line" that messes it up.
I am just backtracking but I'm in a rush (I have to put together a demo machine by yesterday) and I'd like to know how far
back to go.
Tell me, is 1.106 OK? Most likely the patch 1.106 -> 1.107 broke it.
It did work on 1/jan so it was probably your delta.
-- Dimi.
Thanks for the rapid response
Bill
p.s. what is going on in DrawLargeItem with the ellipsification; it looks like it ellipsifies it and then throws the result away.
I am currently working on DrawText which should provide everything needed to draw the text properly. I am feeding it to Alexandre in small pieces so that we don't break anything. Microsoft, as far as I can see, don't actually use DrawText; they appear to reimplement all the ellipsification but I don't see why.
On Fri, 25 Jan 2002, Medland, Bill wrote:
Do you have access to the Microsoft "rowlist" sample? If so then use that
No, I don't. Can you send me a copy, or point me to a place where I can get it from?
but edit a couple of the labels to be longer than one line. It's the "being longer than one line" that messes it up.
Aha! That's a good tip -- I'll check it out soon, but right now I'm at work, and I don't have any Wine-related things around :)
Thanks for the rapid response
No problem -- sorry for the screw up :)
p.s. what is going on in DrawLargeItem with the ellipsification; it looks like it ellipsifies it and then throws the result away.
No wonder -- that's the most obscure part of the code, and I had the most problems with debugging the thing...
I am currently working on DrawText which should provide everything needed to draw the text properly. I am feeding it to Alexandre in small pieces so that we don't break anything. Microsoft, as far as I can see, don't actually use DrawText; they appear to reimplement all the ellipsification but I don't see why.
Cool. Given your knowladge of DrawText, should I just drop the ellipsification and simply let DrawText do it?
-- Dimi.
"Dimitrie O. Paun" dimi@cs.toronto.edu wrote in message news:Pine.GSO.4.21.0201251308080.14925-100000@dvp.cs...
On Fri, 25 Jan 2002, Medland, Bill wrote:
Do you have access to the Microsoft "rowlist" sample? If so then use
that
No, I don't. Can you send me a copy, or point me to a place where I can get it from?
Search at www.microsoft.com fpor rowlist; it's about the third hit (msdn.microsoft.com/msdn-files). Download and compile under VC++ 6
but edit a couple of the labels to be longer than one line. It's the
"being
longer than one line" that messes it up.
Aha! That's a good tip -- I'll check it out soon, but right now I'm at work, and I don't have any Wine-related things around :)
Thanks for the rapid response
No problem -- sorry for the screw up :)
p.s. what is going on in DrawLargeItem with the ellipsification; it
looks
like it ellipsifies it and then throws the result away.
No wonder -- that's the most obscure part of the code, and I had the most problems with debugging the thing...
I am currently working on DrawText which should provide everything
needed to
draw the text properly. I am feeding it to Alexandre in small pieces so that we don't break anything. Microsoft, as far as I can see, don't actually use DrawText; they appear to reimplement all the
ellipsification
but I don't see why.
Cool. Given your knowladge of DrawText, should I just drop the ellipsification and simply let DrawText do it?
I would say so. I expect to get the DrawText up to a usable state in a couple of weeks at most. (I've proven the concept but I need to step through the deltas carefully to make sure I don't break it). The fix will add the multiline capability with special symantics for DT_EDITCONTROL which, I believe, will make DrawText operate the same way as the text in listview. (including weird things like what does wordbreak do when a single word is too long!). Then the fun will start on ListView. When I played with it about 6 months ago the painting became a problem, taking into account when it is two lines deep, when it is "as long as needed" etc.
Bill
-- Dimi.
On Fri, 25 Jan 2002, Bill Medland wrote:
Search at www.microsoft.com fpor rowlist; it's about the third hit (msdn.microsoft.com/msdn-files). Download and compile under VC++ 6
That's great, but I don't even have a Windows partition, let alone VC++!
But nevermind the request, if the code works now...
-- Dimi.
On Fri, 25 Jan 2002, Medland, Bill wrote:
p.s. what is going on in DrawLargeItem with the ellipsification; it looks like it ellipsifies it and then throws the result away.
Bill,
Can you try the attached (uncompiled, untested) patch? It simplifies the code quite a bit IMO. BTW, the previous code did not throw away the ellipsification since szDispText == lvItem.pszText.
-- Dimi.
"Dimitrie O. Paun" dimi@cs.toronto.edu wrote in message news:Pine.GSO.4.21.0201251342440.14925-200000@dvp.cs...
On Fri, 25 Jan 2002, Medland, Bill wrote:
p.s. what is going on in DrawLargeItem with the ellipsification; it
looks
like it ellipsifies it and then throws the result away.
Bill,
Can you try the attached (uncompiled, untested) patch? It simplifies the code quite a bit IMO. BTW, the previous code did not throw away the ellipsification since szDispText == lvItem.pszText.
Fine (after satisfying the compiler). Shall I submit it or do you want the glory? Bill
On Fri, 25 Jan 2002, Bill Medland wrote:
Fine (after satisfying the compiler).
Cool. What was wrong? Nevermind, I'll check the patch.
Shall I submit it or do you want the glory?
Sure I want the glory, but you can submit it. :)
-- Dimi.
-
Bill Medland -
Dimitrie O. Paun -
Medland, Bill