See attachment.
Hi,
While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=59473
Your paranoid android.
=== wxppro (32 bit report) ===
user32: dialog.c:2014: Test failed: dialog font lfHeight not matched (-11 vs 13) dialog.c:2026: Test failed: dialog font lfFaceName not matched ('L"\01da"' vs 'L"Tahoma"')
=== w2003std (32 bit report) ===
user32: dialog.c:2014: Test failed: dialog font lfHeight not matched (-11 vs 13) dialog.c:2026: Test failed: dialog font lfFaceName not matched ('L"\01da"' vs 'L"Tahoma"')
=== wvistau64 (32 bit report) ===
user32: dialog.c:2014: Test failed: dialog font lfHeight not matched (-12 vs 15) dialog.c:2026: Test failed: dialog font lfFaceName not matched ('L"\01ee"' vs 'L"Segoe UI"')
=== w2008s64 (32 bit report) ===
user32: dialog.c:2014: Test failed: dialog font lfHeight not matched (-11 vs 13) dialog.c:2026: Test failed: dialog font lfFaceName not matched ('L"\01da"' vs 'L"Tahoma"')
=== w8 (32 bit report) ===
user32: dialog.c:2014: Test failed: dialog font lfHeight not matched (-12 vs 15) dialog.c:2026: Test failed: dialog font lfFaceName not matched ('L"\01fa"' vs 'L"Segoe UI"')
=== w8adm (32 bit report) ===
user32: dialog.c:2014: Test failed: dialog font lfHeight not matched (-12 vs 15) dialog.c:2026: Test failed: dialog font lfFaceName not matched ('L"\01fa"' vs 'L"Segoe UI"')
=== w864 (32 bit report) ===
user32: dialog.c:2014: Test failed: dialog font lfHeight not matched (-12 vs 15) dialog.c:2026: Test failed: dialog font lfFaceName not matched ('L"\01fa"' vs 'L"Segoe UI"')
=== w1064v1507 (32 bit report) ===
user32: dialog.c:2014: Test failed: dialog font lfHeight not matched (-12 vs 15) dialog.c:2026: Test failed: dialog font lfFaceName not matched ('L"\01fa"' vs 'L"Segoe UI"')
=== w1064v1809 (32 bit report) ===
user32: dialog.c:2014: Test failed: dialog font lfHeight not matched (-11 vs 15) dialog.c:2026: Test failed: dialog font lfFaceName not matched ('L"\000f"' vs 'L"Segoe UI"')
=== w1064v1809_2scr (32 bit report) ===
user32: dialog.c:2014: Test failed: dialog font lfHeight not matched (-11 vs 15) dialog.c:2026: Test failed: dialog font lfFaceName not matched ('L"\000f"' vs 'L"Segoe UI"')
=== w1064v1809_ar (32 bit report) ===
user32: dialog.c:2014: Test failed: dialog font lfHeight not matched (-11 vs 15) dialog.c:2026: Test failed: dialog font lfFaceName not matched ('L"\000f"' vs 'L"Segoe UI"')
=== w1064v1809_he (32 bit report) ===
user32: dialog.c:2014: Test failed: dialog font lfHeight not matched (-11 vs 15) dialog.c:2026: Test failed: dialog font lfFaceName not matched ('L"\000f"' vs 'L"Segoe UI"')
=== w1064v1809_ja (32 bit report) ===
user32: dialog.c:2014: Test failed: dialog font lfHeight not matched (-11 vs 15) dialog.c:2026: Test failed: dialog font lfFaceName not matched ('L"\000f"' vs 'L"Yu Gothic UI"')
=== w1064v1809_zh_CN (32 bit report) ===
user32: dialog.c:2014: Test failed: dialog font lfHeight not matched (-11 vs 17) dialog.c:2026: Test failed: dialog font lfFaceName not matched ('L"\0011"' vs 'L"Microsoft YaHei UI"')
=== wvistau64 (64 bit report) ===
user32: dialog.c:2014: Test failed: dialog font lfHeight not matched (-12 vs 15) dialog.c:2026: Test failed: dialog font lfFaceName not matched ('L"\01ee"' vs 'L"Segoe UI"')
=== w2008s64 (64 bit report) ===
user32: dialog.c:2014: Test failed: dialog font lfHeight not matched (-11 vs 13) dialog.c:2026: Test failed: dialog font lfFaceName not matched ('L"\01da"' vs 'L"Tahoma"')
=== w864 (64 bit report) ===
user32: dialog.c:2014: Test failed: dialog font lfHeight not matched (-12 vs 15) dialog.c:2026: Test failed: dialog font lfFaceName not matched ('L"\01fa"' vs 'L"Segoe UI"')
=== w1064v1507 (64 bit report) ===
user32: dialog.c:2014: Test failed: dialog font lfHeight not matched (-12 vs 15) dialog.c:2026: Test failed: dialog font lfFaceName not matched ('L"\01fa"' vs 'L"Segoe UI"')
=== w1064v1809 (64 bit report) ===
user32: dialog.c:2014: Test failed: dialog font lfHeight not matched (-11 vs 15) dialog.c:2026: Test failed: dialog font lfFaceName not matched ('L"\000f"' vs 'L"Segoe UI"')
=== debian10 (build log) ===
../../../wine/dlls/user32/dialog.c:308:44: error: unknown type name ‘LOGFONT’ ../../../wine/dlls/user32/dialog.c:315:12: error: request for member ‘lfHeight’ in something not a structure or union ../../../wine/dlls/user32/dialog.c:317:27: error: request for member ‘lfHeight’ in something not a structure or union Task: The win32 build failed
=== debian10 (build log) ===
../../../wine/dlls/user32/dialog.c:308:44: error: unknown type name ‘LOGFONT’ ../../../wine/dlls/user32/dialog.c:315:12: error: request for member ‘lfHeight’ in something not a structure or union ../../../wine/dlls/user32/dialog.c:317:27: error: request for member ‘lfHeight’ in something not a structure or union Task: The wow64 build failed
"katahiromz ." katayama.hirofumi.mz@gmail.com writes:
This is already handled in the caller. Why do you need all this?