Re: [1/3] msxml3: Add xmlparser interfaces

[Francois Gouget]

On Wed, 7 Sep 2011, Alistair Leslie-Hughes wrote:
> Changelog:
>     msxml3: Add xmlparser interfaces

This patch defines an XML_ERROR_CODE enumeration type in xmlparser.idl 
which is a bit strange because I cannot find this type in the Windows 
SDK. But in the Windows 7 SDK there is an XmlError enumeration type in 
xmllite.h that looks similar but subtly different.

These two enumaration types share some error codes, in particular 
XML_E_INVALID_HEXIDECIMAL (Microsoft can't spell apparently) but with 
different values. In this case 0xc00ce51e in Wine vs. 0xc00ce01e in the 
Windows 7 SDK.

So what's going on?

[1/3] msxml3: Add xmlparser interfaces

[Alistair Leslie-Hughes]

Hi Francois,
> This patch defines an XML_ERROR_CODE enumeration type in xmlparser.idl
> which is a bit strange because I cannot find this type in the Windows
> SDK. But in the Windows 7 SDK there is an XmlError enumeration type in
> xmllite.h that looks similar but subtly different.
>
> These two enumaration types share some error codes, in particular
> XML_E_INVALID_HEXIDECIMAL (Microsoft can't spell apparently) but with
> different values. In this case 0xc00ce51e in Wine vs. 0xc00ce01e in the
> Windows 7 SDK.
>
> So what's going on?

I have taken my values from xmlparser.idl found in the the PocketPC SDK that 
is included with VS 2008.

I've double check the values, and they are correct.
> From the windows xmlparser.idl

typedef enum {
XML_E_PARSEERRORBASE = 0xC00CE500L,

XML_E_ENDOFINPUT            = XML_E_PARSEERRORBASE,
...
XML_E_INVALID_HEXIDECIMAL,      // 1E      <- WINE = 0xC00CE51E
....
} XML_ERROR_CODE;

Hope this clears things up.

Best Regards
 Alistair Leslie-Hughes

[1/3] msxml3: Add xmlparser interfaces

[Francois Gouget]

On Sun, 11 Sep 2011, Alistair Leslie-Hughes wrote:
[...]
> > So what's going on?
>
> I have taken my values from xmlparser.idl found in the the PocketPC SDK that
> is included with VS 2008.

I think that's the problem. Wine reimplements the Windows' Platform SDK 
Win32 and Win64 APIs, not Windows Mobile which is what the PowerPC SDK 
is. Apparently there are some differences so it would be best not to mix 
the two.

Note that this is not to say that Wine should not also implement the 
Windows Mobile API, just that adding support for it would require larger 
adjustments.

[1/3] msxml3: Add xmlparser interfaces

[Alistair Leslie-Hughes]

Hi Francois,
> I think that's the problem. Wine reimplements the Windows' Platform SDK
> Win32 and Win64 APIs, not Windows Mobile which is what the PowerPC SDK
> is. Apparently there are some differences so it would be best not to mix
> the two.
>
> Note that this is not to say that Wine should not also implement the
> Windows Mobile API, just that adding support for it would require larger
> adjustments.

It shouldn't be a problem, this is the only place you can get a reference to 
these
interfaces.  It appears that once these interfaces were Deprecated they 
where removed
from the SDK for msxml. See MSDN to show that they now deprecated, and they
aren't just for Mobile Devices.
http://msdn.microsoft.com/en-us/library/ms757816%28VS.85%29.aspx

It was part of the msxml3 at some point on windows, see bug
http://bugs.winehq.org/show_bug.cgi?id=5841

Best Regards
 Alistair Leslie-Hughes

[1/3] msxml3: Add xmlparser interfaces

[Dmitry Timoshkov]

Alistair Leslie-Hughes wrote:
> It shouldn't be a problem, this is the only place you can get a reference to 
> these
> interfaces.  It appears that once these interfaces were Deprecated they 
> where removed
> from the SDK for msxml. See MSDN to show that they now deprecated, and they
> aren't just for Mobile Devices.

In that case you should be able to find appropriate definitions in older
PSDK versions.

[1/3] msxml3: Add xmlparser interfaces

[Francois Gouget]

On Mon, 12 Sep 2011, Alistair Leslie-Hughes wrote:
[...]
> It shouldn't be a problem, this is the only place you can get a 
> reference to these interfaces.  It appears that once these interfaces 
> were Deprecated they where removed from the SDK for msxml. See MSDN to 
> show that they now deprecated, and they aren't just for Mobile 
> Devices. 
> http://msdn.microsoft.com/en-us/library/ms757816%28VS.85%29.aspx
>
> It was part of the msxml3 at some point on windows, see bug
> http://bugs.winehq.org/show_bug.cgi?id=5841

I could not find an xmlparser* file (case insensitive) in any of the 
following Windows SDKs:
   Visual C++ 6.0
   Visual C++ 2005
   Visual C++ 2008
   Windows 003sp2 SDK 2006/03/15
   Longhorn SDK 6.0.6001.16500.72 2007/04/25
   Windows Vista SDK 6.0.6001.18000.367 2008/02/05
   Windows 7 SDK 7.1 2010/05/19

So I'm not sure xmlparser.idl and xmlparser.h should be in the include 
directory.