Re: ole32/tests: Test for correct storage creation.

[Dmitry Timoshkov]

Roman Dadkov  wrote:
> - IStorage_Commit(stg, STGC_DEFAULT);
> - IStorage_Release(stg);
> - GetHGlobalFromILockBytes(ilb, &hMem);

It would be helpful to test the results of the above calls too.
> - todo_wine
> - ok(!memcmp((BYTE*)hMem, StandardMagic, 8), "Incorrect storage creation\n");
> - todo_wine
> - ok(!memcmp(((BYTE*)hMem+8), NullableField, 16), "Incorrect storage creation. Field is not reset\n");
> - todo_wine
> - ok(!memcmp(((BYTE*)hMem+34), NullableField, 10), "Incorrect storage creation. Field is not reset\n");

What is this supposed to show?

ole32/tests: Test for correct storage creation.

[Vincent Povirk]

> What is this supposed to show?

Presumably that those parts of the header are actively reset by
StgCreateDocfileOnILockBytes. In fact, it probably makes sense to
throw out the initial data in the ILockBytes.

I guess it'd help if there were comments explaining what those fields
are, so people didn't have to look them up.