[PATCH 1/3] d3dx11/tests: Use CRT allocation functions.

[Matteo Bruni]

Signed-off-by: Matteo Bruni 
---
 dlls/d3dx11_43/tests/d3dx11.c | 11 +++++------
 1 file changed, 5 insertions(+), 6 deletions(-)

diff --git a/dlls/d3dx11_43/tests/d3dx11.c b/dlls/d3dx11_43/tests/d3dx11.c
index 89fc0721c92..357a84ce457 100644
--- a/dlls/d3dx11_43/tests/d3dx11.c
+++ b/dlls/d3dx11_43/tests/d3dx11.c
@@ -21,7 +21,6 @@
 #include "d3d11.h"
 #include "d3dx11.h"
 #include "wine/test.h"
-#include "wine/heap.h"

#ifndef MAKEFOURCC
 #define MAKEFOURCC(ch0, ch1, ch2, ch3)  \
@@ -503,8 +502,8 @@ static HRESULT WINAPI test_d3dinclude_open(ID3DInclude *iface, D3D_INCLUDE_TYPE

if (!strcmp(filename, "include1.h"))
     {
-        buffer = heap_alloc(strlen(include1));
-        CopyMemory(buffer, include1, strlen(include1));
+        buffer = malloc(strlen(include1));
+        memcpy(buffer, include1, strlen(include1));
         *bytes = strlen(include1);
         ok(include_type == D3D_INCLUDE_LOCAL, "Unexpected include type %d.\n", include_type);
         ok(!strncmp(include2, parent_data, strlen(include2)),
@@ -512,8 +511,8 @@ static HRESULT WINAPI test_d3dinclude_open(ID3DInclude *iface, D3D_INCLUDE_TYPE
     }
     else if (!strcmp(filename, "include\include2.h"))
     {
-        buffer = heap_alloc(strlen(include2));
-        CopyMemory(buffer, include2, strlen(include2));
+        buffer = malloc(strlen(include2));
+        memcpy(buffer, include2, strlen(include2));
         *bytes = strlen(include2);
         ok(!parent_data, "Unexpected parent_data value.\n");
         ok(include_type == D3D_INCLUDE_LOCAL, "Unexpected include type %d.\n", include_type);
@@ -530,7 +529,7 @@ static HRESULT WINAPI test_d3dinclude_open(ID3DInclude *iface, D3D_INCLUDE_TYPE

static HRESULT WINAPI test_d3dinclude_close(ID3DInclude *iface, const void *data)
 {
-    heap_free((void *)data);
+    free((void *)data);
     return S_OK;
 }

[PATCH 2/3] winebus.sys: Clarify a comment.

[Matteo Bruni]

Signed-off-by: Matteo Bruni 
---
Hopefully I got it right...

dlls/winebus.sys/unix_private.h | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/dlls/winebus.sys/unix_private.h b/dlls/winebus.sys/unix_private.h
index 3c37f219a4b..ed1ececc9e5 100644
--- a/dlls/winebus.sys/unix_private.h
+++ b/dlls/winebus.sys/unix_private.h
@@ -123,10 +123,10 @@ struct hid_report_descriptor
     BYTE next_report_id[3];
 };

-/* HID spec uses None / Stop names for the first two implicit waveforms,
- * where Windows SDK headers use STOP / NULL for the corresponding HID
- * usage constants. We're not actually using the usages anyway are we
- * stick to the HID spec here.
+/* The HID spec uses None / Stop names for the first two implicit waveforms,
+ * where the Windows SDK headers use STOP / NULL for the corresponding HID
+ * usage constants. We don't care about the usages anyway so we stick to the
+ * HID spec's nomenclature here.
  */
 enum haptics_waveform_ordinal
 {

[PATCH 2/3] winebus.sys: Clarify a comment.

[Rémi Bernon]

On 3/2/22 14:05, Matteo Bruni wrote:
> Signed-off-by: Matteo Bruni
>
> Hopefully I got it right...
>
> dlls/winebus.sys/unix_private.h | 8 ++++----
>   1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/dlls/winebus.sys/unix_private.h b/dlls/winebus.sys/unix_private.h
> index 3c37f219a4b..ed1ececc9e5 100644
> --- a/dlls/winebus.sys/unix_private.h
> +++ b/dlls/winebus.sys/unix_private.h
> @@ -123,10 +123,10 @@ struct hid_report_descriptor
>       BYTE next_report_id[3];
>   };
>
> -/* HID spec uses None / Stop names for the first two implicit waveforms,
> -
> - where Windows SDK headers use STOP / NULL for the corresponding HID
> -
> - usage constants. We're not actually using the usages anyway are we
> -
> - stick to the HID spec here.
>
> +/* The HID spec uses None / Stop names for the first two implicit waveforms,
> -
> - where the Windows SDK headers use STOP / NULL for the corresponding HID
> -
> - usage constants. We don't care about the usages anyway so we stick to the
> -
> - HID spec's nomenclature here.
> */
> enum haptics_waveform_ordinal
> {

Yeah it's right but I think I'm going to drop this nonsense anyway.

It's hopefully a standard way to describe these features but it doesn't 
map very well to what we would need for Windows.Gaming.Input trigger 
rumble support, it makes everything more complicated than necessary and 
it doesn't match what native exposes in its SimpleHapticsController 
collections: instead of a single HID collection like we have, native has 
a collection for each physical motor, and only a single implicit 
waveform on each and no real need for the stop/null waveforms.

[PATCH 3/3] combase: Add RoSetErrorReportingFlags() stub.

[Matteo Bruni]

Signed-off-by: Matteo Bruni 
---
I wrote this patch a while ago, before seeing Alistair's on the
ML. Since his version stalled I guess I might as well send mine...

dlls/combase/combase.spec |  2 +-
 dlls/combase/roapi.c      |  9 +++++++++
 include/roerrorapi.h      | 10 ++++++++++
 3 files changed, 20 insertions(+), 1 deletion(-)

diff --git a/dlls/combase/combase.spec b/dlls/combase/combase.spec
index c2fafacdea3..b3f4d25b42c 100644
--- a/dlls/combase/combase.spec
+++ b/dlls/combase/combase.spec
@@ -312,7 +312,7 @@
 @ stub RoReportUnhandledError
 @ stub RoResolveRestrictedErrorInfoReference
 @ stub RoRevokeActivationFactories
-@ stub RoSetErrorReportingFlags
+@ stdcall RoSetErrorReportingFlags(long)
 @ stub RoTransformError
 @ stub RoTransformErrorW
 @ stdcall RoUninitialize()
diff --git a/dlls/combase/roapi.c b/dlls/combase/roapi.c
index 0a17f02b776..46adf088247 100644
--- a/dlls/combase/roapi.c
+++ b/dlls/combase/roapi.c
@@ -299,6 +299,15 @@ BOOL WINAPI RoOriginateError(HRESULT error, HSTRING message)
     return FALSE;
 }

+/***********************************************************************
+ *      RoSetErrorReportingFlags (combase.@)
+ */
+HRESULT WINAPI RoSetErrorReportingFlags(UINT32 flags)
+{
+    FIXME("(%08x): stub\n", flags);
+    return S_OK;
+}
+
 /***********************************************************************
  *      CleanupTlsOleState (combase.@)
  */
diff --git a/include/roerrorapi.h b/include/roerrorapi.h
index 454e1a6c2e9..741347455b1 100644
--- a/include/roerrorapi.h
+++ b/include/roerrorapi.h
@@ -23,8 +23,18 @@
 #include <restrictederrorinfo.h>
 #include <rpc.h>

+typedef enum
+{
+    RO_ERROR_REPORTING_NONE                 = 0x0,
+    RO_ERROR_REPORTING_SUPPRESSEXCEPTIONS   = 0x1,
+    RO_ERROR_REPORTING_FORCEEXCEPTIONS      = 0x2,
+    RO_ERROR_REPORTING_USESETERRORINFO      = 0x4,
+    RO_ERROR_REPORTING_SUPPRESSSETERRORINFO = 0x8,
+} RO_ERROR_REPORTING_FLAGS;
+
 HRESULT WINAPI GetRestrictedErrorInfo(IRestrictedErrorInfo **info);
 BOOL    WINAPI RoOriginateError(HRESULT error, HSTRING message);
 BOOL    WINAPI RoOriginateLanguageException(HRESULT error, HSTRING message, IUnknown *language_exception);
+HRESULT WINAPI RoSetErrorReportingFlags(UINT32 flags);

#endif /* _ROERROR_H */

[PATCH 3/3] combase: Add RoSetErrorReportingFlags() stub.

[Huw Davies]

On Wed, Mar 02, 2022 at 02:05:32PM +0100, Matteo Bruni wrote:
> Signed-off-by: Matteo Bruni
>
> I wrote this patch a while ago, before seeing Alistair's on the
> ML. Since his version stalled I guess I might as well send mine...

"Stalled" is a bit harsh as Alistair only sent in v3 yesterday ;-)

However, this version has the points I'd asked for, so you win!

Signed-off-by: Huw Davies