Hi Frédéric,
-/* List of 3 character top level domain names Windows seems to recognize. +/* List of 3 characters top level domain names Windows seems to recognize.
That change is incorrect. In English, 'character' should be singular there. (This occurs twice in your patch.)
The other changes seem ok. - Dan
2011/7/22 Dan Kegel dank@kegel.com:
Hi Frédéric,
-/* List of 3 character top level domain names Windows seems to recognize. +/* List of 3 characters top level domain names Windows seems to recognize.
That change is incorrect. In English, 'character' should be singular there. (This occurs twice in your patch.)
Interesting. Could you pls give me pointers explaining this peculiar English grammar rule?
Frédéric
On 07/22/2011 06:49 PM, Frédéric Delanoy wrote:
2011/7/22 Dan Kegeldank@kegel.com:
-/* List of 3 character top level domain names Windows seems to recognize. +/* List of 3 characters top level domain names Windows seems to recognize.
That change is incorrect. In English, 'character' should be singular there. (This occurs twice in your patch.)
Interesting. Could you pls give me pointers explaining this peculiar English grammar rule?
A "number-noun" adjective does not use the noun's plural form. Other examples are "four-wheel drive," "seven-day trip" and "three-lane highway." I think they're easier to read with hyphens, but it's really a matter of preference.
This is the best reference I could find: http://www.grammar-quizzes.com/adjective.html
Andrew
On Sat, Jul 23, 2011 at 02:03, Andrew Eikum andrew@brightnightgames.com wrote:
On 07/22/2011 06:49 PM, Frédéric Delanoy wrote:
2011/7/22 Dan Kegeldank@kegel.com:
-/* List of 3 character top level domain names Windows seems to recognize. +/* List of 3 characters top level domain names Windows seems to recognize.
That change is incorrect. In English, 'character' should be singular there. (This occurs twice in your patch.)
Interesting. Could you pls give me pointers explaining this peculiar English grammar rule?
A "number-noun" adjective does not use the noun's plural form. Other examples are "four-wheel drive," "seven-day trip" and "three-lane highway." I think they're easier to read with hyphens, but it's really a matter of preference.
This is the best reference I could find: http://www.grammar-quizzes.com/adjective.html
Andrew
OK thx. Guess there's a "-" missing as well.
Frédéric
2011/7/23 Frédéric Delanoy frederic.delanoy@gmail.com:
On Sat, Jul 23, 2011 at 02:03, Andrew Eikum andrew@brightnightgames.com wrote:
On 07/22/2011 06:49 PM, Frédéric Delanoy wrote:
2011/7/22 Dan Kegeldank@kegel.com:
-/* List of 3 character top level domain names Windows seems to recognize. +/* List of 3 characters top level domain names Windows seems to recognize.
That change is incorrect. In English, 'character' should be singular there. (This occurs twice in your patch.)
Interesting. Could you pls give me pointers explaining this peculiar English grammar rule?
A "number-noun" adjective does not use the noun's plural form. Other examples are "four-wheel drive," "seven-day trip" and "three-lane highway." I think they're easier to read with hyphens, but it's really a matter of preference.
This is the best reference I could find: http://www.grammar-quizzes.com/adjective.html
Andrew
OK thx. Guess there's a "-" missing as well.
Frédéric
It's optional, but does make it a bit clearer to non-native English speakers.
On 7/23/11 12:29 AM, Austin English wrote:
2011/7/23 Frédéric Delanoyfrederic.delanoy@gmail.com:
On Sat, Jul 23, 2011 at 02:03, Andrew Eikumandrew@brightnightgames.com wrote:
On 07/22/2011 06:49 PM, Frédéric Delanoy wrote:
2011/7/22 Dan Kegeldank@kegel.com:
-/* List of 3 character top level domain names Windows seems to recognize. +/* List of 3 characters top level domain names Windows seems to recognize.
That change is incorrect. In English, 'character' should be singular there. (This occurs twice in your patch.)
Interesting. Could you pls give me pointers explaining this peculiar English grammar rule?
A "number-noun" adjective does not use the noun's plural form. Other examples are "four-wheel drive," "seven-day trip" and "three-lane highway." I think they're easier to read with hyphens, but it's really a matter of preference.
This is the best reference I could find: http://www.grammar-quizzes.com/adjective.html
Andrew
OK thx. Guess there's a "-" missing as well.
Frédéric
It's optional, but does make it a bit clearer to non-native English speakers.
s/seams/seems/g...
James
On 7/23/11 12:07 AM, Frédéric Delanoy wrote:
On Sat, Jul 23, 2011 at 02:03, Andrew Eikumandrew@brightnightgames.com wrote:
On 07/22/2011 06:49 PM, Frédéric Delanoy wrote:
2011/7/22 Dan Kegeldank@kegel.com:
-/* List of 3 character top level domain names Windows seems to recognize. +/* List of 3 characters top level domain names Windows seems to recognize.
That change is incorrect. In English, 'character' should be singular there. (This occurs twice in your patch.)
Interesting. Could you pls give me pointers explaining this peculiar English grammar rule?
A "number-noun" adjective does not use the noun's plural form. Other examples are "four-wheel drive," "seven-day trip" and "three-lane highway." I think they're easier to read with hyphens, but it's really a matter of preference.
This is the best reference I could find: http://www.grammar-quizzes.com/adjective.html
Andrew
OK thx. Guess there's a "-" missing as well.
Actually, if we could get away with it, the correct (grammar wise, not Windows wise is):
List of three-character top-level domain names Windows seams to recognize.
But I'm not doing the change and I don't know if this is something that AJ would approve anyway.
James