Re: [PATCH] ddraw/tests: Only set DDSCAPS_OVERLAY if supported.

[Henri Verbeet]

On 10 March 2014 14:46, Stefan Dösinger  wrote:
> - hr = IDirectDraw4_GetCaps(ddraw, &hal_caps, &hel_caps);

You're not using "hel_caps".
> -
>                if (!overlay_support)
> -
>                    ddsd.ddsCaps.dwCaps &= ~DDSCAPS_OVERLAY;

This will result in trying to create a surface with just
DDSCAPS_VIDEOMEMORY set in the caps. What kind of surface do you
expect that to create?

[PATCH] ddraw/tests: Only set DDSCAPS_OVERLAY if supported.

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2014-03-10 16:01, schrieb Henri Verbeet:
> On 10 March 2014 14:46, Stefan Dösinger 
> wrote:
> > - hr = IDirectDraw4_GetCaps(ddraw, &hal_caps, &hel_caps);
>
> You're not using "hel_caps".

I believe setting the second parameter to NULL crashes on some Windows
versions and/or some ddraw versions. dsurface.c suggests otherwise at
least for IDirectDraw though.
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.22 (GNU/Linux)
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJTHeRkAAoJEN0/YqbEcdMwPPgP/A6RPz1PoUlnRLLyWw2gjpNr
vKDHG8TDtNHOeIvfRcEmTWvomlvDkiEOTA7AxF2dNMtTUtyJkp+CjVGV85NfjWWh
YZj7NND2jprunMamYoRg/zb41hIxZ2SuuUYIO8JiISD6SMNwT8wm0fEArMG3rQBy
pAUJIZjy1Ats1BBjofG9hJKA3hEBn/sh9URfqt22KQqnVtkfenAmG9jmNNAvtGTZ
ipuoT4POChb6HB7L8AEocvWyPBbko/yYbiHOp9HP8sCXdtVmn+EcfrMG7ZwbZYZA
O7xOEtMoQvFGhr4MpE18rlmxIIwMwK1+z0UoVWZoflc5tm+NNTCPLmR+jGWtiQKH
+5r4fQGh+eQquEpm+RCaD/flz2A6Y+/mE1vdvPlzpZSSkim9RjELQRXjrWO4Df1i
K2TZbyS6yY+lZF9icS7BDt8NnKqR71pw/9HYfyWD66BvpXskIj4ACIFxTErAvcVV
cj7n0NlRKsLXRspIvYiS4rsVSyh8G0eYwLHZeqffiKLXxWuZ/Q1SWxdZlklXPyfU
/0RWNl4HnNRlNDZBIc11ErkQPflghpSYzm4qRD1rFL+lQ6xNnccBJ5HA4/p7C2k9
4pURmRy/IqKx8pEbks9lwaiMFuUlFVffQ2pdSja33NRGk8X+EbRJmxI9oDRiEc2T
xUhRPBQyWrCAjewDJZMy
=P89h
-----END PGP SIGNATURE-----