RFC: comctl32 indentations

[Andrew Talbot]

Hi,

In toolbar.c:TOOLBAR_Destroy(), should the "if" statement at line 5439 be 
compound to match the indentation, or should the three invocations of 
TOOLBAR_DeleteImageList() be outdented?

treeview.c:
In TREEVIEW_DeleteItem(), how conditional is the call of 
TREEVIEW_SetFirstVisible() at line 1539?

I'm guessing that the simple "if" statement at line 3045 just requires 
indenting(?)

If the forum is the wrong place to raise this sort of query, please forgive 
and advise. :)

Thanks,

[Andrew Talbot]

Andrew Talbot wrote:
> If the forum is the wrong place to raise this sort of query, please
> forgive and advise. :)

Actually, Alexandre suggested that I file bug reports for things I find but
can't fix myself. And I suppose an indentation anomaly is still a sort of
bug(?)

[Hin-Tak Leung]

Andrew Talbot wrote:
> Andrew Talbot wrote:
> > If the forum is the wrong place to raise this sort of query, please
> > forgive and advise. :)
>
> Actually, Alexandre suggested that I file bug reports for things I find but
> can't fix myself. And I suppose an indentation anomaly is still a sort of
> bug(?)

Indentation is something you *can* fix yourself, *if* it bothers you that much
that some lines are out indented wrongly. The usual practice elsewhere
is to just generate a diff/patch, post it and hope that somebody who has commit 
rights to agree with your that the indentation needs fixing, and just commit
the change you have already generated properly as a diff/patch. The same with
typos in comments, for example.

Talking about it and whether to do it is wasting everybody's time.