Signed-off-by: Alistair Leslie-Hughes leslie_alistair@hotmail.com --- dlls/dinput/tests/keyboard.c | 2 +- dlls/dinput/tests/mouse.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/dlls/dinput/tests/keyboard.c b/dlls/dinput/tests/keyboard.c index 9254123..d6ab5b5 100644 --- a/dlls/dinput/tests/keyboard.c +++ b/dlls/dinput/tests/keyboard.c @@ -479,7 +479,7 @@ static void test_GetDeviceInfo(IDirectInputA *pDI) wine_dbgstr_guid(&instA.guidProduct), wine_dbgstr_guid(&inst3A.guidProduct) ); ok(instA.dwDevType == inst3A.dwDevType, "got %d, %d\n", instA.dwDevType, inst3A.dwDevType);
- if (pKey) IUnknown_Release(pKey); + IUnknown_Release(pKey); }
static void keyboard_tests(DWORD version) diff --git a/dlls/dinput/tests/mouse.c b/dlls/dinput/tests/mouse.c index c5cb684..e4d24e8 100644 --- a/dlls/dinput/tests/mouse.c +++ b/dlls/dinput/tests/mouse.c @@ -224,7 +224,7 @@ static void test_GetDeviceInfo(IDirectInputA *pDI) wine_dbgstr_guid(&instA.guidProduct), wine_dbgstr_guid(&inst3A.guidProduct) ); ok(instA.dwDevType == inst3A.dwDevType, "got %d, %d\n", instA.dwDevType, inst3A.dwDevType);
- if (pMouse) IUnknown_Release(pMouse); + IUnknown_Release(pMouse); }
static BOOL CALLBACK EnumAxes(const DIDEVICEOBJECTINSTANCEA *pdidoi, void *pContext)
Hi,
While running your changed tests, I think I found new failures. Being a bot and all I'm not very good at pattern recognition, so I might be wrong, but could you please double-check?
Full results can be found at: https://testbot.winehq.org/JobDetails.pl?Key=52853
Your paranoid android.
=== debian9 (32 bit report) ===
dinput: mouse.c:173: Test failed: GetDeviceData() failed: 00000000 cnt:0
=== debian9 (32 bit French report) ===
dinput: mouse.c:173: Test failed: GetDeviceData() failed: 00000000 cnt:0
=== debian9 (32 bit Japanese:Japan report) ===
dinput: mouse.c:173: Test failed: GetDeviceData() failed: 00000000 cnt:0
=== debian9 (32 bit Chinese:China report) ===
dinput: mouse.c:173: Test failed: GetDeviceData() failed: 00000000 cnt:0
=== debian9 (32 bit WoW report) ===
dinput: mouse.c:173: Test failed: GetDeviceData() failed: 00000000 cnt:0
=== debian9 (64 bit WoW report) ===
dinput: mouse.c:162: Test failed: GetDeviceData() failed: 00000000 cnt:0 mouse.c:173: Test failed: GetDeviceData() failed: 00000000 cnt:0