Re: msi: Add binary search to the string table.

[Henri Verbeet]

2009/12/14 Hans Leidekker :
> Addresses a performance bottleneck in the Visual Studio 2005 installer.
> See http://bugs.winehq.org/show_bug.cgi?id=14168

Does it really make sense to maintain both a hash table and a binary
search tree?

msi: Add binary search to the string table.

[Hans Leidekker]

On Monday 14 December 2009 16:00:21 Henri Verbeet wrote:
> Does it really make sense to maintain both a hash table and a binary
> search tree?

Theoretically the hash lookup is faster for small numbers of strings,
but I haven't benchmarked it. Alexandre suggested to keep the hash IIRC.

-Hans

msi: Add binary search to the string table.

[Alexandre Julliard]

Hans Leidekker  writes:
> On Monday 14 December 2009 16:00:21 Henri Verbeet wrote:
> > Does it really make sense to maintain both a hash table and a binary
> > search tree?
>
> Theoretically the hash lookup is faster for small numbers of strings,
> but I haven't benchmarked it. Alexandre suggested to keep the hash IIRC.

I doubt I did, I don't think it makes sense to have both. The small
number of strings case will be fast no matter what, the added complexity
is not worth it.