Re: Question about ToolbarWindowProc

[Guy L. Albertelli]

----- Original Message -----
From: "Guy L. Albertelli" 
To: "Jeremy Shaw" ; "Wine Devel" 
Sent: Wednesday, February 27, 2002 9:20 PM
Subject: Re: Question about ToolbarWindowProc

[snip]
> case 0x0463:
>     {
>           LPDWORD hoho = (LPDWORD)lParam;
>           ERR("[0463] lParam 0x%08lx -> 0x%08lx 0x%08lx\n",
>                  lParam, *hoho, *(hoho+1));
>           /* guess  -  level 1 */
>           if (!*(hoho+1)) {
>               *(hoho+1) = *hoho;  /* set second word to first */
>           }
>           return 0;   /* really should be 1 */
>      }

After more thought (this is still supposition), I think that lParam is a
LPSIZE. Also that the code (at least partially) could be:

case 0x0463:
    {
          LPSIZE hoho = (LPDWORD)lParam;
          ERR("[0463] lParam 0x%08lx -> 0x%08lx 0x%08lx\n",
                 lParam, hoho->cx, hoho->cy);
          /* guess  -  level 2 */
          if (!hoho->cy) {
              hoho->cy = infoPtr->rcBound.bottom - infoPtr->rcBound.top;
          }
          return 1;
     }

Note that there has to be some difference between [0463] and TB_GETMAXSIZE.
Also I have seen some of the values being -1 or other small values.

Making the changes to spy.c and seeing what the natvie control does will be
the key.

Guy

Question about ToolbarWindowProc

[Dmitry Timoshkov]

"Guy L. Albertelli"  wrote:
> After more thought (this is still supposition), I think that lParam is a
> LPSIZE. Also that the code (at least partially) could be:

[skipped]
> Note that there has to be some difference between [0463] and TB_GETMAXSIZE.
> Also I have seen some of the values being -1 or other small values.
>
> Making the changes to spy.c and seeing what the natvie control does will be
> the key.

Hello Guy.

I have attached the result of my work in understanding of workings of 0x0463.
It seems that all cases except of "if(wParam == 1)" work as expected.
Hope it will help to concentrate our efforts.

Question about ToolbarWindowProc

[Guy L. Albertelli]

----- Original Message -----
From: "Dmitry Timoshkov" 
To: "Guy L. Albertelli" ; "Jeremy Shaw"

Cc: 
Sent: Friday, March 01, 2002 1:26 PM
Subject: Re: Question about ToolbarWindowProc
> I have attached the result of my work in understanding of workings of

0x0463.
> It seems that all cases except of "if(wParam == 1)" work as expected.
> Hope it will help to concentrate our efforts.

Hi Dmitry,

Here is my current code. Together with the toolbar.c patch committed
2/26/2002, this code seems to display the IE5.5 "Favorites" menu dropdown
fairly well. The changes to spy.c display the SIZE structure before and
after the message processing. Very helpful in watching the native control.

Known problems:
1. First embeded toolbar (containing the "Add..." and "Orginize..." buttons)
does not seem to be processed as vertical, thus only the "Add.." button
shows. But the actual bookmarks show up and pager works.
2. Your code segment with the GetWindowRect and MapWindowPoints I also see
in the relay trace. It needs more investigation.
3. I also have a relay trace fragment that shows a loop through each button
doing some measurement by GetDC, GetTextExtent.....  We need to understand
it better.

Well back to the relay traces.

Guy