> Also want to point out that I split test changes across both commits earlier, marking device context bit as todo, so that each pass tests. A bit hidden if not looking at individual commits in diffs.
Yes, that's the correct way - tests should pass on each commit.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/1183#note_12460
Oops, silly oversights.
Also want to point out that I split test changes across both commits earlier, marking device context bit as todo, so that each pass tests.
A bit hidden if not looking at individual commits in diffs.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/1183#note_12459
- the tests were failing in Hindi/UTF8
- rounding with (lo+(hi-lo+1)/2) let all the tests pass
- rounding with (lo+(hi-lo)/2 + 1) (as it's done when
ES_MULTILINE is enabled) let the Hindi/UTF8 fail
- it looked weird to have different rounding computation
in single vs multi line
- so, changing all rounding to (lo+(hi-lo+1)/2) let all
the tests pass
Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com>
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/1184