October 2022 - wine-gitlab

[PATCH v2 0/7] MR1180: Make all kernel callbacks go through user32
by Torge Matthies (＠tmatthies) 28 Oct '22

28 Oct '22

Overwatch 2 verifies that every kernel callback that is run, lives in user32. Introduce a callback in user32 that just forwards to the other modules' callbacks. I don't know what to call this kind of callback, I just called it "user32 callback" for now because it's going through user32 but that's not really a good name. It also sadly necessitates a private \_\_wine export from user32, unless someone has a better idea for how to register the callbacks with user32. -- v2: user32: Remove NtUserDriverCallback* kernel callbacks. winex11.drv: Convert kernel callbacks to user32 callbacks. winemac.drv: Convert kernel callbacks to user32 callbacks. wineandroid.drv: Convert kernel callbacks to user32 callbacks. winevulkan: Convert kernel callbacks to user32 callbacks. user.exe16: Convert kernel callbacks to user32 callbacks. user32: Add user32 callback infrastructure. https://gitlab.winehq.org/wine/wine/-/merge_requests/1180

2 7

[PATCH v4 0/9] MR1177: msvcrt: implement much more localized functions
by Bartosz Kosiorek (＠gang65) 27 Oct '22

27 Oct '22

-- v4: msvcrt: Add _mbctokata_l implementation. msvcrt: Add _mbctohira_l implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1177

2 9

Re: [PATCH v8 0/2] MR1015: wpcap: Build devices in unixlib for find_all_devices - closed
by Marc-Aurel Zent (＠marzent) 27 Oct '22

27 Oct '22

This merge request was closed by Marc-Aurel Zent. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1015

1 0

Re: [PATCH v8 0/2] MR1015: wpcap: Build devices in unixlib for find_all_devices
by Marc-Aurel Zent (＠marzent) 27 Oct '22

27 Oct '22

Yeah the commit above worked perfectly, didn't know even know you can do it like that on the PE side. Much nicer than the double calling and conversion of the Unix struct. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1015#note_12353

1 0

[PATCH v2 0/3] MR1174: compstui: Add CPSFUNC_ADD_PFNPROPSHEETUI and CPSFUNC_ADD_PROPSHEETPAGE support.
by Piotr Caban (＠piotr) 27 Oct '22

27 Oct '22

-- v2: compstui: Test that callbacks are executed. https://gitlab.winehq.org/wine/wine/-/merge_requests/1174

2 4

[PATCH v3 0/7] MR1177: msvcrt: implement much more localized functions
by Bartosz Kosiorek (＠gang65) 27 Oct '22

27 Oct '22

-- v3: msvcrt: Add _mbctombb_l implementation. msvcrt: Add _mbcjmstojis_l implementation. https://gitlab.winehq.org/wine/wine/-/merge_requests/1177

2 7

[PATCH 0/3] MR1174: compstui: Add CPSFUNC_ADD_PFNPROPSHEETUI and CPSFUNC_ADD_PROPSHEETPAGE support.
by Piotr Caban (＠piotr) 27 Oct '22

27 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1174

3 6

[PATCH v2 0/7] MR1177: msvcrt: implement much more localized functions
by Bartosz Kosiorek (＠gang65) 27 Oct '22

27 Oct '22

-- v2: msvcrt: Add _mbctombb_l implementation. msvcrt: Add _mbcjmstojis_l implementation. msvcrt: Add _mbcjistojms_l implementation. ucrtbase: Export more _o_* functions. https://gitlab.winehq.org/wine/wine/-/merge_requests/1177

2 7

[PATCH 0/8] MR1177: msvcrt: implement much more localized functions
by Bartosz Kosiorek (＠gang65) 27 Oct '22

27 Oct '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1177

3 10

[PATCH v2 0/3] MR1134: ntdll: Use local unwinding reimplementations for Unix libraries on ARM/ARM64
by Martin Storsjö (＠mstorsjo) 27 Oct '22

27 Oct '22

Currently, unwinding the unix libraries (or full ELF builds) requires having libunwind available. When starting up a wine environment, an exception of type `RPC_S_SERVER_UNAVAILABLE` gets thrown - and if libunwind isn't available, this breaks the startup. Thus, currently on ARM/ARM64, libunwind is essentially mandatory. Additionally, at least on ARM, libunwind seems brittle (commits in latest git master breaks the unwinding use cases in Wine, see e.g. https://github.com/libunwind/libunwind/pull/203#issuecomment-984126066. This MR tries to resolve all of this, by including the preexisting DWARF parser from x86_64 in the aarch64 version too. This bit was mostly quite straightforward. For ARM, libunwind has currently relied on DWARF debug info in the `.debug_frame` section, since Linux on ARM doesn't use DWARF for runtime unwinding. This MR adds ARM EHABI unwind opcodes where necessary, and adds a local reimplementation of an ARM EHABI/EXIDX/EXTBL unwinder, similar to the DWARF one. With these changes, unwinding on both ARM and ARM64 seems to work fine, even without libunwind. See the individual commit messages for more commentary on the decisions taken so far (I've tried to write up all relevant considerations there - it's a fair amount of commentery). A couple open questions: - So far, the shared DWARF code was put in a header, `dwarf.h`. Do you want to make this a proper standalone `.c` file too? - I wrote the ARM EHABI unwind code mostly with `stdint.h` types like `uint32_t`(as it's in the ntdll/unix directory anyway), but I can rewrite it with `DWORD` or similar if that's preferred. - The ARM EHABI opcodes are enabled for `defined(__arm__) && defined(__ELF__) && defined(__GNUC__) && !defined(__SEH__) && !defined(__ARM_DWARF_EH__)` - there's no define to check for for knowing it's used and enabled, but it has to be implicitly assumed if no other other unwind mechanism is signaled. - The `dl_iterate_phdr` function, used for finding the EXIDX section for locating ARM EHABI unwind info, is used within `#ifdef linux`. It might be available on other OSes too (like FreeBSD etc). Or should I go ahead and add a configure check for it? CC @julliard @rbernon @AndreRH -- v2: ntdll: Use the local dwarf implementation on arm64 ntdll: Add support for aarch64 in the dwarf implementation ntdll: Move the dwarf reading routines to a shareable header https://gitlab.winehq.org/wine/wine/-/merge_requests/1134

3 6

2025

2024

2023

2022

wine-gitlab October 2022