November 2022 - wine-gitlab

[PATCH 0/1] MR1554: win32u: Reset focused item when removing menu item
by Vladislav Timonin (＠vt) 26 Nov '22

26 Nov '22

Fixes an out of bounds access in `show_popup`. ```c if (menu->FocusedItem != NO_SELECTED_ITEM) { menu->items[menu->FocusedItem].fState &= ~(MF_HILITE|MF_MOUSESELECT); // <- can crash here menu->FocusedItem = NO_SELECTED_ITEM; } ``` Menu resets focused item on show, not on close. If items were later deleted, next time user opens the menu, menu can crash on out of bounds access and won't show up again, as menu thinks it's still on screen. In other words: - open split button dropdown - click on any item - clear dropdown items - open dropdown again Menu borked and won't open again. Source for the testing app for reproduction. [test.c](/uploads/2f703f63891b33e1a0eb0fcd27c912b7/test.c) I guess, the alternative is to reset focused item when menu is closed, but not sure where's the best place to do that, haven't dug deep enough. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1554

3 4

[PATCH v2 0/1] MR1553: msvcrt: Fix errno set on dup from read-only file.
by xantares (＠xantares) 26 Nov '22

26 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53950 -- v2: msvcrt: Fix errno set on dup from read-only file. https://gitlab.winehq.org/wine/wine/-/merge_requests/1553

3 3

[PATCH 0/1] MR1553: msvcrt: Fix errno set on dup from read-only file.
by xantares (＠xantares) 26 Nov '22

26 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53950 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1553

3 4

[PATCH v10 0/3] MR1539: gdiplus: add support for Custom Line Indent.
by Bartosz Kosiorek (＠gang65) 26 Nov '22

26 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45273 -- v10: gdiplus: add support for LineCapArrowAnchor. https://gitlab.winehq.org/wine/wine/-/merge_requests/1539

4 9

[PATCH 0/1] MR1552: winevulkan: Use direct calls for vkGetDescriptorEXT.
by Georg Lehmann (＠DadSchoorse) 26 Nov '22

26 Nov '22

It's as performance sensitive as descriptor updates. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1552

2 1

[PATCH 0/1] MR1494: winebus.sys: Don't use SDL_HAPTIC_INFINITY when calling SDL_HapticRunEffect.
by Ivo Ivanov (＠logos128) 26 Nov '22

26 Nov '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1494

4 12

[PATCH v9 0/3] MR1539: gdiplus: add support for Custom Line Indent.
by Bartosz Kosiorek (＠gang65) 26 Nov '22

26 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45273 -- v9: gdiplus: add support for LineCapArrowAnchor. https://gitlab.winehq.org/wine/wine/-/merge_requests/1539

3 4

[PATCH v8 0/3] MR1539: gdiplus: add support for Custom Line Indent.
by Bartosz Kosiorek (＠gang65) 26 Nov '22

26 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45273 -- v8: gdiplus: add support for LineCapArrowAnchor. https://gitlab.winehq.org/wine/wine/-/merge_requests/1539

3 4

[PATCH v7 0/3] MR1539: gdiplus: add support for Custom Line Indent.
by Bartosz Kosiorek (＠gang65) 26 Nov '22

26 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45273 -- v7: gdiplus: add support for LineCapArrowAnchor. https://gitlab.winehq.org/wine/wine/-/merge_requests/1539

3 4

[PATCH v6 0/3] MR1539: gdiplus: add support for Custom Line Indent.
by Bartosz Kosiorek (＠gang65) 26 Nov '22

26 Nov '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=45273 -- v6: gdiplus: add support for LineCapArrowAnchor. https://gitlab.winehq.org/wine/wine/-/merge_requests/1539

3 4

2025

2024

2023

2022

wine-gitlab November 2022