December 2022 - wine-gitlab

[PATCH 0/1] MR1776: include: Add _recalloc.
by Alex Henrie (＠alexhenrie) 13 Dec '22

13 Dec '22

This function would be useful in a lot of places in Wine. I wish I had known about it sooner. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1776

3 2

[PATCH 0/1] MR1804: win32u: Downgrade the NtOpenFile ERR to a WARN in add_device().
by Zebediah Figura (＠zfigura) 13 Dec '22

13 Dec '22

This may fail for multiple legitimate reasons. Most commonly, the device may not actually be present on the machine (it will appear in the registry regardless). Less commonly, the device may have been removed between the call to NtEnumerateKey and here. We can get around the former by checking the Linked subkey value, but there is not much point; failing to open the file gives us just as much information. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53300 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1804

3 2

[PATCH 0/1] MR1770: winecrt0: Include <stddef.h> from dll_soinit.c
by Gerald Pfeifer (＠gerald) 13 Dec '22

13 Dec '22

When .so module initialization was moved from ntdll to winecrt0 with commit bef09697 we lost a number of include files. FreeBSD-specific code in dll_soinit.c uses offsetof(), so include <stddef.h>. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1770

2 3

[PATCH 0/2] MR1706: Some more enabling of long types in wined3d.
by eric pouech (＠epo) 13 Dec '22

13 Dec '22

Standalone MR: - the argN and texture_id types could have been alternatively changed into unsigned int. - that would save a couple of size specifier in printf (this patch and next ones), but at the cost of lots of other changes: - as texture_id is used in some apply methods, that would mean ~200 function prototypes to change - didn't count for argN (even this could be changed on function level, contrary the previous item) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1706

3 6

[PATCH 0/45] MR1446: Draft: Enable long types in wined3d.
by eric pouech (＠epo) 13 Dec '22

13 Dec '22

This is a draft proposal for enabling long types in wined3d. Its purpose is to share with wined3d maintainers the best way to enable long types. It's not meant to be committed as is (draft MR). I tried to minimize the number of changes by migrating some types to pure int/unsigned int types. The net result is not a huge change, but still quite a change: dlls/d3d11/device.c | 6 +- dlls/d3d8/device.c | 4 +- dlls/d3d9/device.c | 4 +- dlls/ddraw/ddraw.c | 4 +- dlls/wined3d/Makefile.in | 1 - dlls/wined3d/adapter_gl.c | 32 ++++----- dlls/wined3d/adapter_vk.c | 18 +++--- dlls/wined3d/arb_program_shader.c | 84 ++++++++++++------------ dlls/wined3d/ati_fragment_shader.c | 4 +- dlls/wined3d/buffer.c | 16 ++--- dlls/wined3d/context_gl.c | 26 ++++---- dlls/wined3d/cs.c | 14 ++-- dlls/wined3d/device.c | 52 +++++++-------- dlls/wined3d/directx.c | 40 ++++++------ dlls/wined3d/glsl_shader.c | 112 ++++++++++++++++---------------- dlls/wined3d/nvidia_texture_shader.c | 12 ++-- dlls/wined3d/palette.c | 14 ++-- dlls/wined3d/query.c | 34 +++++----- dlls/wined3d/resource.c | 12 ++-- dlls/wined3d/sampler.c | 4 +- dlls/wined3d/shader.c | 51 ++++++++------- dlls/wined3d/shader_sm1.c | 12 ++-- dlls/wined3d/shader_sm4.c | 62 +++++++++--------- dlls/wined3d/shader_spirv.c | 4 +- dlls/wined3d/state.c | 84 ++++++++++++------------ dlls/wined3d/stateblock.c | 36 +++++------ dlls/wined3d/surface.c | 32 ++++----- dlls/wined3d/swapchain.c | 85 ++++++++++++------------ dlls/wined3d/texture.c | 60 ++++++++--------- dlls/wined3d/utils.c | 34 +++++----- dlls/wined3d/vertexdeclaration.c | 10 +-- dlls/wined3d/view.c | 26 ++++---- dlls/wined3d/wined3d_main.c | 16 ++--- dlls/wined3d/wined3d_private.h | 122 +++++++++++++++++------------------ include/wine/wined3d.h | 29 +++++---- 35 files changed, 580 insertions(+), 576 deletions(-) This is a fairly long series as: - long type enabling is done on a file basis instead of the module basis. - I tried to split as much as possible: + global changes (shared across multiple file) + type changes linked to a single file + printf-related changes linked to a single file. At the implementation level, there's lots of things to be discussed: - choice of integral type (unsigned int/uint32_t/UINT...). I tried to follow Zebediah's guide-lines. Even if there are counter examples. - changing type vs changing printf (there are still areas to tackle if needed), even if some are (IMO) unavoidable (like GetLastError() or HRESULT) So comments welcome. I likely start next week pushing the first bits. -- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/wine/-/merge_requests/1446

1 2

[PATCH 0/4] MR1808: winemac: Fix remaining printf format warnings.
by Huw Davies (＠huw) 13 Dec '22

13 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1808

2 4

[PATCH 0/1] MR1806: include: Add RTL_CONSTANT_STRING.
by Alex Henrie (＠alexhenrie) 13 Dec '22

13 Dec '22

This macro would be useful for Wine because it would allow us to avoid calling RtlInitUnicodeString on a constant at runtime (which is pretty common). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1806

2 1

[PATCH 0/1] MR1797: user32/tests: Don't assign const variable to other const (gcc 4.7)
by Fabian Maurer (＠DarkShadow44) 13 Dec '22

13 Dec '22

Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1797

3 3

[PATCH v2 0/8] MR50: vkd3d-shader/hlsl: Add field-level documentation to the most important structs in hlsl.h. (v2) (PART 1/2)
by Francisco Casas (＠fcasas) 12 Dec '22

12 Dec '22

First part of v2 of !38, trying to follow the wide feedback provided. Following patches in: https://gitlab.winehq.org/fcasas/vkd3d/-/tree/documentation -- v2: vkd3d-shader/hlsl: Add field-level documentation to struct hlsl_src. vkd3d-shader/hlsl: Add field-level documentation to struct hlsl_ir_node. vkd3d-shader/hlsl: Add field-level documentation to struct hlsl_ctx. vkd3d-shader/hlsl: Add field-level documentation to struct hlsl_ir_var. vkd3d-shader/hlsl: Add field-level documentation to struct hlsl_struct_field. vkd3d-shader/hlsl: Add field-level documentation to struct hlsl_type. vkd3d-shader/hlsl: Rename hlsl_struct_field.modifiers to "storage_modifiers". vkd3d-shader/hlsl: Rename hlsl_ir_var.modifiers to "storage_modifiers". https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/50

4 14

[PATCH 0/1] MR1803: ntoskrnl/tests: Ignore CONFIGFLAG_FINISH_INSTALL on the child device.
by Zebediah Figura (＠zfigura) 12 Dec '22

12 Dec '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53976 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1803

3 2

2025

2024

2023

2022

wine-gitlab December 2022