December 2022 - wine-gitlab

Re: [PATCH v2 0/1] MR1791: vbscript: Fix spelling in a FIXME message. - approved
by Alexandre Julliard (＠julliard) 12 Dec '22

12 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1791

1 0

Re: [PATCH v2 0/2] MR1789: mf/tests: Test GetOutputType for WMV decoder. - approved
by Alexandre Julliard (＠julliard) 12 Dec '22

12 Dec '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1789

1 0

[PATCH 0/1] MR1793: win32u: Call init_window_call_params after WH_CALLWNDPROC hook in call_window_proc.
by Jacek Caban (＠jacek) 12 Dec '22

12 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1793

3 2

[PATCH 0/2] MR1798: Don't redefine typedefs - Initial work for gcc 4.3 support
by Fabian Maurer (＠DarkShadow44) 12 Dec '22

12 Dec '22

Initial MR to gauge interest, there's a bunch more if this one is accepted. Since we still support old gcc, this MR starts fixing issues that prevents compilation. Site note: AFAIK, according to ANSI C redefining typedefs is not allowed either, so this seems a logical change. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1798

2 2

[PATCH 0/2] MR1795: wldap32: Free resource in error case and return error code (Coverity)
by Fabian Maurer (＠DarkShadow44) 12 Dec '22

12 Dec '22

Signed-off-by: Fabian Maurer <dark.shadow4(a)web.de> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1795

3 3

[PATCH 0/5] MR1796: Fix some winemac.drv compiler warnings
by Huw Davies (＠huw) 12 Dec '22

12 Dec '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1796

2 5

Re: [PATCH v2 0/6] MR1682: d3dx9: Partially implement texture filling using texture shaders.
by Matteo Bruni (＠Mystral) 12 Dec '22

12 Dec '22

Sorry I didn't get to your MRs earlier, I was rushing to try and finish cleaning up the d3dx9 tests for long integer types, which I also couldn't manage to do before the deadline :/ I left a few comments, nothing too crazy. Probably going to defer the MRs until the code freeze is lifted? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1682#note_19501

1 0

Re: [PATCH v2 0/6] MR1682: d3dx9: Partially implement texture filling using texture shaders.
by Matteo Bruni (＠Mystral) 12 Dec '22

12 Dec '22

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/tests/texture.c: > + hr = IDirect3DCubeTexture9_GetLevelDesc(texture, m, &desc); > + ok(hr == D3D_OK, "Unexpected hr %#x.\n", hr); > + > + size = desc.Width; > + > for (f = 0; f < 6; f++) > { > - hr = IDirect3DCubeTexture9_LockRect(tex, f, 0, &lock_rect, NULL, D3DLOCK_READONLY); > + texelsize.x = (f == 0) || (f == 1) ? 0.0f : 2.0f / size; > + texelsize.y = (f == 2) || (f == 3) ? 0.0f : 2.0f / size; > + texelsize.z = (f == 4) || (f == 5) ? 0.0f : 2.0f / size; > + > + hr = IDirect3DCubeTexture9_LockRect(texture, f, m, &lock_rect, NULL, D3DLOCK_READONLY); > ok(hr == D3D_OK, "Couldn't lock the texture, error %#x\n", hr); > if (SUCCEEDED(hr)) > { We should just get rid of the if, here or in a separate (preceding) patch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1682#note_19500

1 0

Re: [PATCH v2 0/6] MR1682: d3dx9: Partially implement texture filling using texture shaders.
by Matteo Bruni (＠Mystral) 12 Dec '22

12 Dec '22

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/tests/texture.c: > + return 0; > + } > +} > > - IDirect3DCubeTexture9_Release(tex); > +static DWORD get_expected_argb_color(D3DFORMAT format, const D3DXVECTOR4 *v) > +{ > + switch (format) > + { > + case D3DFMT_A8R8G8B8: > + return (BYTE)(v->w * 255 + 0.5f) << 24 > + | (BYTE)(v->x * 255 + 0.5f) << 16 > + | (BYTE)(v->y * 255 + 0.5f) << 8 > + | (BYTE)(v->z * 255 + 0.5f); > + case D3DFMT_A1R5G5B5: > + Probably the empty line was meant to go above the case rather than below. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1682#note_19498

1 0

Re: [PATCH v2 0/6] MR1682: d3dx9: Partially implement texture filling using texture shaders.
by Matteo Bruni (＠Mystral) 12 Dec '22

12 Dec '22

Matteo Bruni (@Mystral) commented about dlls/d3dx9_36/tests/texture.c: > + {XCOORD, ZERO, YCOORDINV}, > + {XCOORD, YCOORDINV, ONE}, > + {XCOORDINV, YCOORDINV, ZERO} > + }; > > - if (SUCCEEDED(hr)) > + DWORD x, y, m, f, levels, size, value, expected; > + D3DXVECTOR3 coord, texelsize; > + D3DLOCKED_RECT lock_rect; > + D3DSURFACE_DESC desc; > + D3DXVECTOR4 out; > + HRESULT hr; > + > + levels = IDirect3DCubeTexture9_GetLevelCount(texture); > + > + for (m = 0; m < levels; m++) Given that you're touching these lines anyway, you can probably replace the postincrement operator with preincrement (we use the latter by default). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1682#note_19499

1 0

2025

2024

2023

2022

wine-gitlab December 2022