July 2022 - wine-gitlab

[PATCH 0/1] MR563: opengl32/tests: Remove depth 32 / stencil 0 test in test_choosepixelformat().
by Paul Gofman (＠gofman) 29 Jul '22

29 Jul '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53429 As the bug states, the test is failing on Wine / Intel GPU. The test was added in commit 83cbcdefa3f55afc449b6be51e215c4f646869f4 which was a test for cc8d8b5ee33561e984d4abe4112ddd6324f77115 (opengl32: Prioritize stencil check over depth check in wglChoosePixelFormat()). The motivation under that change was to avoid the situation when we erroneously return the no-stencil format (which was breaking a game) and not vice versa. This specific test was probably added for completeness. I don't have a Windows Intel GPU machine to check how it looks like there but it seems to me that this aspect (returning 0 depth stencil instead of 8 when no stencil requested) is much less likely to affect things in practice, so just remove the test instead of trying to fix that in Wine on Intel. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/563

3 2

[PATCH v2 0/5] MR562: mshtml: Doctype node and windowless document fixes.
by Gabriel Ivăncescu (＠insn) 29 Jul '22

29 Jul '22

-- v2: mshtml: Handle lack of window in methods for detached documents. https://gitlab.winehq.org/wine/wine/-/merge_requests/562

3 6

[PATCH 0/5] MR562: mshtml: Doctype node and windowless document fixes.
by Gabriel Ivăncescu (＠insn) 29 Jul '22

29 Jul '22

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/562

2 5

[PATCH v3 0/6] MR550: comctl32/listview: Fix LVS_OWNERDATA list view multi select.
by Angelo Haller (＠szanni) 29 Jul '22

29 Jul '22

The following patches fix sending of the LVN_ODSTATECHANGED notification for LVS_OWNERDATA list views, adding more refined tests in the process and fixing various bugs. This is v5, with the added comment in 3/6 as requested on the mailing list. These are the patches sent as a response to v4 by Zhiyi Zhang on the mailing list, unmodified apart from 3/6 or f24f4b7fd. --- Warning: I have had access to the Windows Research Kernel (WRK) 1.2 ~10 years ago. These changes are regarding comctrl32 & tests which are NOT part of the WRK. As outlined in https://wiki.winehq.org/Developer_FAQ this should therefore satisfy the requirement of ONLY submitting patches to components I have NOT had access to. -- v3: comctl32/tests: Add more ownerdata listview tests. comctl32/listview: Don't send LVN_ODSTATECHANGED for empty ranges. comctl32/listview: Send LVN_ODSTATECHANGED notification for LVS_OWNERDATA listview on selection changes. comctl32/listview: Send LVN_ODSTATECHANGED only for LVS_OWNERDATA listviews. comctl32/listview: Move sending LVN_ODSTATECHANGED notifications to a function. comctl32/listview: Send one deselect all items notification for LVS_OWNERDATA listviews. https://gitlab.winehq.org/wine/wine/-/merge_requests/550

3 10

[PATCH 0/1] MR560: dwrite: Fix fallback config ranges text parsing.
by Nikolay Sivov (＠nsivov) 29 Jul '22

29 Jul '22

Currently it's using all 16 slots, filling trailing ones with rudimentary ranges. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/560

2 2

[PATCH 0/2] MR559: Type 'pointer to type' in WineDbg.
by eric pouech (＠epo) 29 Jul '22

29 Jul '22

This series ensures that when WineDbg looks up for the type 'pointer to a given type', this type always exists. There's no reason this is always available from DbgHelp, so synthetize the relevant type when it's not. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/559

2 2

[PATCH v2 0/5] MR551: win32u: Complete support for display modes in nulldrv.
by Rémi Bernon (＠rbernon) 29 Jul '22

29 Jul '22

With this series it's now possible to run and pass `user32:monitor` and `user32:sysparams` tests with nulldrv, and so most `user32` tests (except for a few desktop cursor position tests). This still requires some prefix configuration to enable the nulldrv driver, or a change like https://gitlab.winehq.org/rbernon/wine/-/commit/753368ad0ec52f03f8d6e78ca79… to enable it when `DISPLAY` environment variable is unset. This then shows that some of the user32 tests are failing with winex11 but passing with nulldrv, as in https://gitlab.winehq.org/rbernon/wine/-/commit/6d5f4109a514a0dc266899fcacf…. -- v2: win32u: Add a default EnumDisplaySettingsEx driver implementation. win32u: Add a default ChangeDisplaySettingsEx driver implementation. win32u: Move enumeration of available modes out of graphics drivers. win32u: Validate NtUserChangeDisplaySettings mode against available modes. win32u: Ignore DM_POSITION mode fields for available modes. https://gitlab.winehq.org/wine/wine/-/merge_requests/551

3 25

Re: [PATCH v2 0/6] MR550: comctl32/listview: Fix LVS_OWNERDATA list view multi select.
by Zhiyi Zhang (＠zhiyi) 29 Jul '22

29 Jul '22

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/listview.c: > ok_sequence(sequences, PARENT_ODSTATECHANGED_SEQ_INDEX, > - ownerdata_multiselect_odstatechanged_seq, > - "ownerdata select multiple notification", FALSE); > + ownerdata_multiselect_move_3_to_2_odstatechanged_seq, > + "ownerdata multiselect: keep selection but move cursor via CONTROL+UP ", FALSE); > + res = SendMessageA(hwnd, WM_KEYUP, VK_UP, 0); > + expect(0, res); > + res = SendMessageA(hwnd, LVM_GETSELECTEDCOUNT, 0, 0); > + expect(1, res); > > - res = SendMessageA(hwnd, WM_KEYUP, VK_DOWN, 0); > + hold_key(VK_SHIFT); > + > + flush_sequences(sequences, NUM_MSG_SEQUENCES); > + > + /* Select multiple via SHIFT+CONTROL+DOWN after moving cursor over an item without selecting */ Wrong comment. Should be SHIFT+CONTROL+UP. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/550#note_5317

1 0

Re: [PATCH v2 0/6] MR550: comctl32/listview: Fix LVS_OWNERDATA list view multi select.
by Zhiyi Zhang (＠zhiyi) 29 Jul '22

29 Jul '22

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/tests/listview.c: > + res = SendMessageA(hwnd, WM_KEYDOWN, VK_DOWN, 0); > + expect(0, res); > + ok_sequence(sequences, PARENT_ODSTATECHANGED_SEQ_INDEX, > + ownerdata_multiselect_select_3_odstatechanged_seq, > + "ownerdata multiselect: deselect all, select item 3 via DOWN", FALSE); > + res = SendMessageA(hwnd, WM_KEYUP, VK_DOWN, 0); > + expect(0, res); > + res = SendMessageA(hwnd, LVM_GETSELECTEDCOUNT, 0, 0); > + expect(1, res); > + > + hold_key(VK_SHIFT); > + > + flush_sequences(sequences, NUM_MSG_SEQUENCES); > + > + /* First up then down */ > + /* Select multiple items via SHIFT+UP */ For consistency, let's move hold_key() to the start of each test. Right now some of them are at the start and some are at the up. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/550#note_5316

1 0

Re: [PATCH v2 0/6] MR550: comctl32/listview: Fix LVS_OWNERDATA list view multi select.
by Zhiyi Zhang (＠zhiyi) 29 Jul '22

29 Jul '22

Zhiyi Zhang (@zhiyi) commented about dlls/comctl32/listview.c: > > - /* disable per item notifications on LVS_OWNERDATA style > - FIXME: single LVN_ODSTATECHANGED should be used */ > + /* Disable per item notifications on LVS_OWNERDATA style */ > old_mask = infoPtr->notify_mask & NOTIFY_MASK_ITEM_CHANGE; > if (infoPtr->dwStyle & LVS_OWNERDATA) > infoPtr->notify_mask &= ~NOTIFY_MASK_ITEM_CHANGE; > > LISTVIEW_DeselectAllSkipItems(infoPtr, selection); > > - > iterator_rangesitems(&i, selection); > while(iterator_next(&i)) > - LISTVIEW_SetItemState(infoPtr, i.nItem, &item); > + { > + // Find the range for LVN_ODSTATECHANGED Please use /**/ instead. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/550#note_5315

1 0

2025

2024

2023

2022

wine-gitlab July 2022