1. Default to zero on IDOK if the edit control is empty.
2. Limit text input length to 8 or 16 hexadecimal characters, or 10 or 20 decimal characters, depending on registry value type and format specifier chosen.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/554
On Thu Jul 28 03:42:04 2022 +0000, **** wrote:
> Marvin replied on the mailing list:
> ```
> Hi,
> It looks like your patch introduced the new failures shown below.
> Please investigate and fix them before resubmitting your patch.
> If they are not new, fixing them anyway would help a lot. Otherwise
> please ask for the known failures list to be updated.
> The full results can be found at:
> https://testbot.winehq.org/JobDetails.pl?Key=119994
> Your paranoid android.
> === debian11 (32 bit report) ===
> comctl32:
> listview.c:3578: Test succeeded inside todo block: ownerdata select
> multiple notification: marked "todo_wine" but succeeds
> listview.c:3595: Test succeeded inside todo block: ownerdata select
> multiple notification: marked "todo_wine" but succeeds
> listview.c:3578: Test succeeded inside todo block: ownerdata select
> multiple notification: marked "todo_wine" but succeeds
> listview.c:3595: Test succeeded inside todo block: ownerdata select
> multiple notification: marked "todo_wine" but succeeds
> === debian11 (32 bit Chinese:China report) ===
> comctl32:
> listview.c:3578: Test succeeded inside todo block: ownerdata select
> multiple notification: marked "todo_wine" but succeeds
> listview.c:3595: Test succeeded inside todo block: ownerdata select
> multiple notification: marked "todo_wine" but succeeds
> listview.c:3578: Test succeeded inside todo block: ownerdata select
> multiple notification: marked "todo_wine" but succeeds
> listview.c:3595: Test succeeded inside todo block: ownerdata select
> multiple notification: marked "todo_wine" but succeeds
> === debian11 (32 bit WoW report) ===
> comctl32:
> listview.c:3578: Test succeeded inside todo block: ownerdata select
> multiple notification: marked "todo_wine" but succeeds
> listview.c:3595: Test succeeded inside todo block: ownerdata select
> multiple notification: marked "todo_wine" but succeeds
> listview.c:3578: Test succeeded inside todo block: ownerdata select
> multiple notification: marked "todo_wine" but succeeds
> listview.c:3595: Test succeeded inside todo block: ownerdata select
> multiple notification: marked "todo_wine" but succeeds
> === debian11 (64 bit WoW report) ===
> comctl32:
> listview.c:3578: Test succeeded inside todo block: ownerdata select
> multiple notification: marked "todo_wine" but succeeds
> listview.c:3595: Test succeeded inside todo block: ownerdata select
> multiple notification: marked "todo_wine" but succeeds
> listview.c:3578: Test succeeded inside todo block: ownerdata select
> multiple notification: marked "todo_wine" but succeeds
> listview.c:3595: Test succeeded inside todo block: ownerdata select
> multiple notification: marked "todo_wine" but succeeds
> ```
Should be fixed.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/550#note_5203
The following patches fix sending of the LVN_ODSTATECHANGED notification for
LVS_OWNERDATA list views, adding more refined tests in the process and
fixing various bugs.
This is v5, with the added comment in 3/6 as requested on the mailing list.
I removed the `Signed-off-by: Zhiyi Zhang <zzhang(a)codeweavers.com>` as I am unsure what the custom is. These are the patches sent as a response to v4 by Zhiyi Zhang on the mailing list, unmodified apart from 3/6 or f24f4b7fd.
---
Warning: I have had access to the Windows Research Kernel (WRK) 1.2
~10 years ago. These changes are regarding comctrl32 & tests which are NOT
part of the WRK. As outlined in https://wiki.winehq.org/Developer_FAQ this
should therefore satisfy the requirement of ONLY submitting patches to
components I have NOT had access to.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/550