When first parsed to names in english and other non-native languages,
after parsing to names in native languages, this will result in second_name
not corresponding to names in english.
Signed-off-by: Jiajin Cui <cuijiajin(a)uniontech.com>
--
v7: win32u: Don't allow a replaced font to be a replacement.
win32u: Ensure that either the primary or secondary name is in English.
https://gitlab.winehq.org/wine/wine/-/merge_requests/628
On Fri Aug 19 08:54:40 2022 +0000, Hans Leidekker wrote:
> In the patch title please replace one occurrence of
> kerberos_SpAcceptLsaModeContext with kerberos_SpInitLsaModeContext.
> Otherwise the patch looks good.
Pushed. Sorry, I did not notice a repetition in title.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/677#note_6535
On Fri Aug 19 08:46:28 2022 +0000, Konstantin wrote:
> Pushed
In the patch title please replace one occurrence of kerberos_SpAcceptLsaModeContext with kerberos_SpInitLsaModeContext. Otherwise the patch looks good.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/677#note_6533
On Fri Aug 19 08:32:04 2022 +0000, Konstantin wrote:
> Do you mean this?
> ```
> if ( status == SEC_E_OK || status == SEC_I_CONTINUE_NEEDED )
> *new_context = create_context_handle( context_handle,
> new_context_handle );
> if (!status)
> {
> *mapped_context = TRUE;
> ```
Yes.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/677#note_6529
On Fri Aug 19 08:20:50 2022 +0000, Hans Leidekker wrote:
> The change should be minimal, so only change the condition for the
> new_context update. Please put spaces around operators like in the rest
> of the file.
> Please also fix the patch title while you're at it :)
Do you mean this?
```
if ( status == SEC_E_OK || status == SEC_I_CONTINUE_NEEDED )
*new_context = create_context_handle( context_handle, new_context_handle );
if (!status)
{
*mapped_context = TRUE;
```
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/677#note_6528