August 2022 - wine-gitlab

Re: [PATCH v4 0/1] MR677: kerberos: Fix regression in kerberos_SpAcceptLsaModeContext and kerberos_SpAcceptLsaModeContext
by Hans Leidekker (＠hans) 19 Aug '22

19 Aug '22

On Fri Aug 19 07:54:25 2022 +0000, Konstantin wrote: > Tested the changes, kerberos auth in our client application work fine. The change should be minimal, so only change the condition for the new_context update. Please put spaces around operators like in the rest of the file. Please also fix the patch title while you're at it :) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/677#note_6527

1 0

Re: [PATCH v4 0/1] MR677: kerberos: Fix regression in kerberos_SpAcceptLsaModeContext and kerberos_SpAcceptLsaModeContext
by Konstantin (＠IncubusRK) 19 Aug '22

19 Aug '22

On Fri Aug 19 07:19:10 2022 +0000, Konstantin wrote: > @hans, thank you for comment. If I understand correct you are author of > original logic. > I am not sure about changes, your suggestion change existing logic. > Originaly `*mapped_context` and `expiry_to_timestamp( exptime, expiry > );` executed only when status is SEC_E_OK, and `new_context` > modification (independant) internaly in `create_context_handle`. > I try change condition to ` if > (status==SEC_E_OK||status==SEC_I_CONTINUE_NEEDED) ` and test it in our network. Tested the changes, kerberos auth in our client application work fine. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/677#note_6526

1 0

Re: [PATCH v6 0/1] MR672: Draft: Common item dialog fixes
by Ben Cottrell (＠bgc) 19 Aug '22

19 Aug '22

On Thu Aug 18 07:09:33 2022 +0000, Zhiyi Zhang wrote: > Do not remove the id property. There should be a id="bitmap:width-depth" > property for the wine's build system to generate the bitmaps from SVGs. > Also, the commit subject is way too long. > And, for the WineHQ bugzilla link. We use the Wine-Bug: tag. OK, id properties have been kept, and have shortened the commit message. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/672#note_6523

1 0

Re: [PATCH v2 0/1] MR677: kerberos: Fix regression in kerberos_SpAcceptLsaModeContext and kerberos_SpAcceptLsaModeContext
by Konstantin (＠IncubusRK) 19 Aug '22

19 Aug '22

On Fri Aug 19 06:54:19 2022 +0000, Konstantin wrote: > @hans, thank you for comment. If I understand correct you are author of > original logic. > I am not sure. You sugesstion change existing logic. Originaly > `*mapped_context` and `expiry_to_timestamp( exptime, expiry );` executed > only when status is SEC_E_OK, and `new_context` modification > (independant) internaly in `create_context_handle`. > I can't check side effect of the proposed change. > If you sure that it correct I change condition to ` if > (status==SEC_E_OK||status==SEC_I_CONTINUE_NEEDED) ` What about SEC_I_COMPLETE_NEEDED and SEC_I_COMPLETE_AND_CONTINUE we need also put it to condition? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/677#note_6521

1 0

Re: [PATCH v2 0/1] MR677: kerberos: Fix regression in kerberos_SpAcceptLsaModeContext and kerberos_SpAcceptLsaModeContext
by Konstantin (＠IncubusRK) 19 Aug '22

19 Aug '22

On Thu Aug 18 14:47:05 2022 +0000, Hans Leidekker wrote: > As I mentioned in the bug report, the new context is updated when > initialize_context() returns SEC_E_OK or SEC_I_CONTINUE_NEEDED. That > should be reflected here. @hans, thank you for comment. If I understand correct you are author of original logic. I am not sure. You sugesstion change existing logic. Originaly `*mapped_context` and `expiry_to_timestamp( exptime, expiry );` executed only when status is SEC_E_OK, and `new_context` modification (independant) internaly in `create_context_handle`. I can't check side effect of the proposed change. If you sure that it correct I change condition to ` if (status==SEC_E_OK||status==SEC_I_CONTINUE_NEEDED) ` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/677#note_6520

1 0

[PATCH v5 0/1] MR672: Draft: Common item dialog fixes
by Ben Cottrell (＠bgc) 19 Aug '22

19 Aug '22

Made changes to comdlg32/itemdlg.c to add missing controls, which are the address bar and the up button. Updated bitmaps in comctl32 and SVG files for history icons. My changes help to resolve this bug: https://bugs.winehq.org/show_bug.cgi?id=50338. -- v5: comdlg32: Add missing controls and their functionality to IFileDialog, or the common item dialog. https://gitlab.winehq.org/wine/wine/-/merge_requests/672

3 3

[PATCH v5 0/1] MR23: shell32: Sanitize Program Manager icon and group names
by Alex Henrie (＠alexhenrie) 19 Aug '22

19 Aug '22

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52506 Signed-off-by: Alex Henrie <alexhenrie24(a)gmail.com> -- v5: shell32: Sanitize Program Manager icon and group names. https://gitlab.winehq.org/wine/wine/-/merge_requests/23

2 1

[PATCH v6 0/2] MR628: win32u: Fix the second_name parsed wrong.
by Jiajin Cui (＠jin-king1) 19 Aug '22

19 Aug '22

When first parsed to names in english and other non-native languages, after parsing to names in native languages, this will result in second_name not corresponding to names in english. Signed-off-by: Jiajin Cui <cuijiajin(a)uniontech.com> -- v6: win32u: Make the replacement font not the replaced font. https://gitlab.winehq.org/wine/wine/-/merge_requests/628

2 3

Re: [PATCH v2 0/6] MR674: win32u: wow64 fixes and winex11 support - approved
by Alexandre Julliard (＠julliard) 18 Aug '22

18 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/674

1 0

Re: [PATCH v2 0/3] MR659: comctl32/tests: Test that changing focus for edit controls doesn't repaint immediately. - approved
by Alexandre Julliard (＠julliard) 18 Aug '22

18 Aug '22

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/659

1 0

2025

2024

2023

2022

wine-gitlab August 2022