January 2023 - wine-gitlab

Re: [PATCH v2 0/2] MR2059: combase: Generate apartment OXID in rpcss
by Aaron Hill (＠Aaron1011) 31 Jan '23

31 Jan '23

On Mon Jan 30 12:35:00 2023 +0000, Huw Davies wrote: > You need to reset the stream to the start and call `CoReleaseMarshalData()`. Done -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2059#note_22496

1 0

Re: [PATCH v2 0/2] MR2059: combase: Generate apartment OXID in rpcss
by Aaron Hill (＠Aaron1011) 31 Jan '23

31 Jan '23

On Tue Jan 31 17:20:28 2023 +0000, Aaron Hill wrote: > changed this line in [version 2 of the diff](/wine/wine/-/merge_requests/2059/diffs?diff_id=30165&start_sha=b2726ff2e1cf0e71d306e617a76f35503ea152bf#fb46240622c0bd2492f45d6d0dd17b8e3c4efa65_154_157) I've adjusted this to use `I_RpcBindingInqLocalClientPID`, and removed the `process_id` parameter. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2059#note_22495

1 0

Re: [PATCH v2 0/2] MR2059: combase: Generate apartment OXID in rpcss
by Aaron Hill (＠Aaron1011) 31 Jan '23

31 Jan '23

On Mon Jan 30 12:30:54 2023 +0000, Huw Davies wrote: > I think it would make sense to also test the `COINT_MULTITHREADED` case, > perhaps by calling this function twice with a `flags` parameter. It > would also make sense to split the tests off to a separate commit, > before the implementation change, with appropriate `todo_wine`s which > would get removed in the second commit. I've added a `flags` parameter, and created a separate commit that adds the test with `todo_wines` in front of the `ok` check. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2059#note_22494

1 0

Re: [PATCH v3 0/1] MR2041: Draft: gdiplus: Correctly handle new lines. - closed
by David Kahurani (＠kahurani) 31 Jan '23

31 Jan '23

This merge request was closed by David Kahurani. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2041

1 0

[PATCH v8 0/2] MR821: Replace obsolete RtlUniform tests that no longer work (currently skipped) since Windows Vista; update RtlUniform impl.
by Jinoh Kang (＠iamahuman) 31 Jan '23

31 Jan '23

Today, test_RtlUniform() skips almost all of its tests on Windows Vista or later. The skipped tests only succeed in Windows XP, and fail on Windows Vista or later. This is because RtlUniform()'s behavior has changed, presumably due to a bug fix shipped in Windows Vista. It appears that RtlUniform, a linear congruential generator, could overflow before computing the modulo in WindoWs XP. This is no longer the case in Windows Vista or later. Meanwhile, we no longer support Windows XP behavior and thus do not test for it regularly; therefore, the tests are obsolete as of 2023. Remove obsolete tests that no longer work with any of the Windows versions actively tested by WineHQ (as of 2023), and replace them with updated tests that works in the Windows versions from Vista up to 10. Also, fix Wine's RtlUniform() to match the new behavior accordingly. -- v8: ntdll: Fix integer overflow in RtlUniform. https://gitlab.winehq.org/wine/wine/-/merge_requests/821

2 3

[PATCH v3 0/7] MR66: vkd3d-shader/hlsl: Broaden resources support v2 (PART 1).
by Francisco Casas (＠fcasas) 31 Jan '23

31 Jan '23

First part of v2 of !27, which aims to: * Allow allocation of variables of complex types that contain both numerics and objects across multiple register sets (regsets). * Support the tex2D and tex3D intrinsics, inferring generic samplers dimension from usage, writing sampler declarations, and writing sample instructions. * Support for arrays of resources for both SM1 and SM4 (not to be confused with the resource-arrays of SM 5.1, which can have non-constant indexes). * Support for resources declared within structs. * Support for synthetic combined samplers for SM1 and synthetic separated samplers for SM4, considering that they can be arrays or members of structs. * Imitate the way the native compiler assigns the register indexes of the resources on allocation, which proved to be the most difficult thing. * Support for object components within complex input parameters. * Small fixes to corner cases. This part consists on parsing the `tex2D()` and `tex3D()` intrinsics and beginning to support the allocation of variables across multiple regsets. The whole series, is on my [master6](https://gitlab.winehq.org/fcasas/vkd3d/-/commits/master6) branch. -- v3: vkd3d-shader/hlsl: Allocate register reservations in a separate pass. vkd3d-shader/hlsl: Allocate objects according to register set. vkd3d-shader/hlsl: Keep an hlsl_reg for each register set in hlsl_ir_var. vkd3d-shader/hlsl: Store the type's register size for each register set. vkd3d-shader/hlsl: Parse the tex3D() intrinsic. vkd3d-shader/hlsl: Parse the tex2D() intrinsic. vkd3d-shader/hlsl: Avoid segfault on missing sampler. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/66

4 22

[PATCH v2 0/1] MR2068: Draft: comdlg32: Enable visual styles when showing IFileDialog.
by Vladislav Timonin (＠vt) 31 Jan '23

31 Jan '23

Required for !1857 to not break when comctl32 version 6 isn't requested by application (in particular, found this in [qapitrace](https://github.com/apitrace/apitrace)). Manifest resource id and assembly identity name match with Windows. For isolation purposes, activation context is disabled while emitting events. -- v2: comdlg32: Enable visual styles when showing IFileDialog. https://gitlab.winehq.org/wine/wine/-/merge_requests/2068

3 4

[PATCH 0/4] MR2079: Be consistent in naming bits inside PDB files.
by eric pouech (＠epo) 31 Jan '23

31 Jan '23

This series tidy up some naming used to describe the PDB internals. We are not consistent in the various names added over the years. Let's try to be a bit more clear. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2079

2 4

[PATCH v7 0/2] MR821: Replace obsolete RtlUniform tests that no longer work (currently skipped) since Windows Vista; update RtlUniform impl.
by Jinoh Kang (＠iamahuman) 31 Jan '23

31 Jan '23

Today, test_RtlUniform() skips almost all of its tests on Windows Vista or later. The skipped tests only succeed in Windows XP, and fail on Windows Vista or later. This is because RtlUniform()'s behavior has changed, presumably due to a bug fix shipped in Windows Vista. It appears that RtlUniform, a linear congruential generator, could overflow before computing the modulo in WindoWs XP. This is no longer the case in Windows Vista or later. Meanwhile, we no longer support Windows XP behavior and thus do not test for it regularly; therefore, the tests are obsolete as of 2023. Remove obsolete tests that no longer work with any of the Windows versions actively tested by WineHQ (as of 2023), and replace them with updated tests that works in the Windows versions from Vista up to 10. Also, fix Wine's RtlUniform() to match the new behavior accordingly. -- v7: ntdll: Fix integer overflow in RtlUniform. https://gitlab.winehq.org/wine/wine/-/merge_requests/821

2 2

[PATCH v6 0/2] MR821: Replace obsolete RtlUniform tests that no longer work (currently skipped) since Windows Vista; update RtlUniform impl.
by Jinoh Kang (＠iamahuman) 31 Jan '23

31 Jan '23

Today, test_RtlUniform() skips almost all of its tests on Windows Vista or later. The skipped tests only succeed in Windows XP, and fail on Windows Vista or later. This is because RtlUniform()'s behavior has changed, presumably due to a bug fix shipped in Windows Vista. It appears that RtlUniform, a linear congruential generator, could overflow before computing the modulo in WindoWs XP. This is no longer the case in Windows Vista or later. Meanwhile, we no longer support Windows XP behavior and thus do not test for it regularly; therefore, the tests are obsolete as of 2023. Remove obsolete tests that no longer work with any of the Windows versions actively tested by WineHQ (as of 2023), and replace them with updated tests that works in the Windows versions from Vista up to 10. Also, fix Wine's RtlUniform() to match the new behavior accordingly. -- v6: ntdll: Fix integer overflow in RtlUniform. https://gitlab.winehq.org/wine/wine/-/merge_requests/821

2 3

2025

2024

2023

2022

wine-gitlab January 2023