January 2023 - wine-gitlab

[PATCH 0/1] MR1665: kernelbase: Let GetFileInformationByHandle succeed on unix redirected handle.
by eric pouech (＠epo) 07 Feb '23

07 Feb '23

As these handles to a file don't have an unix-name attached, the FileAllInformation query fails. So only implement GetFileInformationByHandle() on top of queries which don't fail. I tested if the three ntdll calls instead of one did impact performance. On cached handles they don't: a simple x100000 loop even shows a ~10% improvement, likely because we don't grab the filename from wineserver. Note: that NtQueryInformationFile(FileAllInformation) (as other queries returning file's name) will still fail on these unix-redirected handles. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51813 Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1665

7 15

[PATCH 0/2] MR2017: kernelbase: Partially implement QueryUnbiasedInterruptTimePrecise.
by Mohamad Al-Jaf (＠maljaf) 07 Feb '23

07 Feb '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54338 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2017

3 6

[PATCH v3 0/6] MR1925: WMV decoder DMO support.
by Ziqing Hui (＠zhui) 06 Feb '23

06 Feb '23

-- v3: winegstreamer: Implement GetOutputSizeInfo for WMV decoder. mf/tests: Test GetOutputSizeInfo for WMV decoder. winegstreamer: Implement SetOutputType for WMV decoder. winegstreamer: Implement GetOutputType for WMV decoder. mfplat: Support YVYU, NV11, MEDIASUBTYPE_RGB* media types. mfplat: Fix stride calculation for RGB24. https://gitlab.winehq.org/wine/wine/-/merge_requests/1925

4 9

[PATCH v6 0/1] MR1937: kernelbase: Fix grouping repeat for number formatting.
by Gabriel Ivăncescu (＠insn) 06 Feb '23

06 Feb '23

LOCALE_SGROUPING's string and the `Grouping` field in NUMBERFMTW are confusingly different. The former, which is what is fixed here, treats a '0' as a repeat of the previous grouping. But a 0 at the end of the `Grouping` field prevents it from repeating (it repeats by default otherwise) so it's the opposite. Note that without a '0' in the LOCALE_SGROUPING string, it shouldn't even repeat in the first place. This fixes the typical "3;0" default grouping, for example. See: https://learn.microsoft.com/en-us/windows/win32/intl/locale-sgrouping -- v6: kernelbase: Fix grouping repeat for number formatting. https://gitlab.winehq.org/wine/wine/-/merge_requests/1937

2 3

[PATCH 0/1] MR1764: inetmib1: Get rid of GCC12 warning.
by eric pouech (＠epo) 06 Feb '23

06 Feb '23

Code assumes that tableIndex is never 0, while GCC cannot infer it. So include tableIndex=0 case into already handled error cases. GCC/Mingw complains with: /home/eric/work/wine/dlls/inetmib1/main.c: In function 'mib2IfEntryQuery': /home/eric/work/wine/dlls/inetmib1/main.c:646:25: warning: array subscript 4294967295 is above array bounds of 'MIB_IFROW[1]' {aka 'struct _MIB_IFROW[1]'} [-Warray-bounds] 646 | &ifTable->table[tableIndex - 1], item, | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ In file included from /home/eric/work/wine/include/ipmib.h:21, from /home/eric/work/wine/include/iprtrmib.h:24, from /home/eric/work/wine/include/iphlpapi.h:25, from /home/eric/work/wine/dlls/inetmib1/main.c:30: /home/eric/work/wine/include/ifmib.h:66:15: note: while referencing 'table' 66 | MIB_IFROW table[1]; Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1764

3 3

[PATCH 0/1] MR978: kernelbase: Fix uninitialized return value in GetModuleHandleA().
by eric pouech (＠epo) 06 Feb '23

06 Feb '23

GCC (MingW) 12.2 rightfully warns with: /home/eric/work/wine/dlls/kernelbase/loader.c: In function 'GetModuleHandleA': /home/eric/work/wine/dlls/kernelbase/loader.c:332:12: warning: 'ret' may be used uninitialized [-Wmaybe-uninitialized] 332 | return ret; | ^~~ /home/eric/work/wine/dlls/kernelbase/loader.c:329:13: note: 'ret' declared here 329 | HMODULE ret; | ^~~ So set module to NULL on all error codepaths in GetModuleHandleExA(). Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/978

2 2

[PATCH 0/1] MR1765: krnl386.exe16: Get rid of GCC 12 warning.
by eric pouech (＠epo) 06 Feb '23

06 Feb '23

Mark args local variable with volatile to tell GCC not to check for out of bounds access. Alternative fix: use an intermediate variable to store &fun as an integer. MingW/GCC 12 complains with: In file included from /home/eric/work/wine/dlls/krnl386.exe16/thunk.c:36: /home/eric/work/wine/dlls/krnl386.exe16/thunk.c: In function 'SSCall': /home/eric/work/wine/include/wine/debug.h:91:4: warning: array subscript 1 is outside array bounds of 'INT_PTR (__attribute__((stdcall)) *[1])(void)' {aka 'int (__attribute__((stdcall)) *[1])(void)'} [-Warray-bounds] 91 | wine_dbg_log( __dbcl, __dbch, __func__, __VA_ARGS__); } } while(0) | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ /home/eric/work/wine/include/wine/debug.h:88:8: note: in expansion of macro '__WINE_DBG_LOG' 88 | __WINE_DBG_LOG | ^~~~~~~~~~~~~~ /home/eric/work/wine/include/wine/debug.h:463:36: note: in expansion of macro '__WINE_DPRINTF' 463 | #define WINE_TRACE __WINE_DPRINTF(_TRACE,__wine_dbch___default) | ^~~~~~~~~~~~~~ /home/eric/work/wine/include/wine/debug.h:506:36: note: in expansion of macro 'WINE_TRACE' 506 | #define TRACE WINE_TRACE | ^~~~~~~~~~ /home/eric/work/wine/dlls/krnl386.exe16/thunk.c:996:32: note: in expansion of macro 'TRACE' 996 | for (i = 0; i < nr/4; i++) TRACE("0x%08lx,",args[i]); | ^~~~~ /home/eric/work/wine/dlls/krnl386.exe16/thunk.c:989:17: note: at offset 4 into object 'fun' of size 4 989 | FARPROC fun, /* [in] function to call */ | ~~~~~~~~^~~ Signed-off-by: Eric Pouech <eric.pouech(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1765

3 3

[PATCH v3 0/3] MR1259: gitlab: Run some tests with nulldrv driver.
by Rémi Bernon (＠rbernon) 06 Feb '23

06 Feb '23

Allowing the job to fail to avoid failing the pipeline. Some new tests are failing with it, and some are succeeding todo_wine. -- v3: gitlab: Run user32 32-bit tests with nulldrv driver. https://gitlab.winehq.org/wine/wine/-/merge_requests/1259

2 4

[PATCH v2 0/5] MR1756: ntdll: Various performance improvements to hash_short_file_name.
by Rémi Bernon (＠rbernon) 06 Feb '23

06 Feb '23

The function is called a lot, I believe something like this would improve its performance in general. -- v2: ntdll: Lookup extension from the end in hash_short_file_name. ntdll: Use invalid char lookup table in lookup_unix_name. ntdll: Use invalid char lookup table in nt_to_unix_file_name_no_root. ntdll: Use invalid char lookup table in is_legal_8dot3_name. ntdll: Use invalid char lookup table in is_invalid_dos_char. https://gitlab.winehq.org/wine/wine/-/merge_requests/1756

2 7

[PATCH 0/1] MR1859: winex11: Raise owned windows before setting input focus.
by Rémi Bernon (＠rbernon) 06 Feb '23

06 Feb '23

Installers based on InnoSetup use invisible window owning the main installer window. When focus is given to the installer window popup, window managers sometimes do not raise it as their owner is invisible and it stays below other windows unless they are minimized. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=49933 This is not a regression and it is arguably perhaps a window manager bug, but it is also extremely annoying for users as installer windows tend to disappear from the pager, as well as missing from the window selector and below all other windows. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1859

2 2

2025

2024

2023

2022

wine-gitlab January 2023