On Sun Dec 18 23:28:47 2022 +0000, Zebediah Figura wrote:
> We already know it fits, so this can just be memcpy().
source does not have wmemcpy and wcsncpy is defined as:
`#define wcsncpy(d,s,n) error do_not_use_wcsncpy_use_lstrcpynW_or_memcpy_instead`
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_21340
On Sun Dec 18 23:24:34 2022 +0000, Zebediah Figura wrote:
> These are constant arrays, so should be "static const WCHAR *const".
> Also, it seems that one array is the same as the other without the final
> colon; can we avoid defining two arrays?
Yes, it is possible to avoid 2 arrays, that is an additional goal. The first goal for me was to avoid additional computation (string manipulation), but i will adjust.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/1825#note_21339
First relevant commit:
windows.media.speech: Add a worker thread to the recognition session.
--
v6: windows.media.speech: Store recorded audio in a temporary ringbuffer.
windows.media.speech: Partially implement the speech recognizer state.
windows.media.speech: Add an audio capturing system.
windows.media.speech: Allow the recognition session worker to be paused.
windows.media.speech/tests: Check if stopping the session resets the paused state.
windows.media.speech: Add a worker thread to the recognition session.
windows.media.speech/tests: Test starting, stopping, pausing and resuming the recognition session.
windows.media.speech/tests: Test the recognizer state.
windows.media.speech: Return IAsyncAction from session_PauseAsync.
windows.media.speech: Return IAsyncAction from session_StopAsync.
windows.media.speech: Do not force calling convention on internal callbacks.
windows.media.speech: Move constraints vector to the recognition session.
https://gitlab.winehq.org/wine/wine/-/merge_requests/1948
First relevant commit:
windows.media.speech: Add a worker thread to the recognition session.
--
v5: windows.media.speech: Store recorded audio in a temporary ringbuffer.
windows.media.speech: Partially implement the speech recognizer state.
windows.media.speech: Add an audio capturing system.
windows.media.speech: Allow the recognition session worker to be paused.
https://gitlab.winehq.org/wine/wine/-/merge_requests/1948
Currently it doesn't work as expected, namely gets stuck on delimiter and caret is moved before the delimiter.
Unnecessary more robust than Windows, which feels like doesn't do any checks at all.
EDIT1: v2: return length in `WB_RIGHT` if its bigger than default return value of 0 on invalid values
EDIT2: v3: don't test `WB_ISDELIMITER` with out of bounds indices, Windows doesn't check them and does out of bounds reads
--
v4: comctl32: Fix PathWordBreakProc.
https://gitlab.winehq.org/wine/wine/-/merge_requests/1977