January 2023 - wine-gitlab

[PATCH v4 0/2] MR1989: wininet: Allow UTC as a timezone.
by Etaash Mathamsetty (＠etaash.mathamsetty) 21 Jan '23

21 Jan '23

this should fix ubisoft connect outputting unknown timezone UTC in logs -- v4: wininet/tests: Add test for UTC timezone. https://gitlab.winehq.org/wine/wine/-/merge_requests/1989

2 3

[PATCH 0/27] MR27: vkd3d-shader/hlsl: Make hlsl_type_get_component_type() type argument
by Francisco Casas (＠fcasas) 21 Jan '23

21 Jan '23

Okay, now the text is correctly written. Please disregard the previous MR I sent by mistake, I already closed it. *ehem* I don't expect this MR to be approved (because it is quite big) but I think it would be good if you review it so I start sending it in partitions, and to avoid working on conflicting patches. But, most importantly, because the patches in the middle of this series contain design decisions pertaining the handling of resource components and register spaces that, I think, are justified by their capability of supporting the many features in the second half of the patch series. Also, in case a different approach is deemed more convenient, it would be good to consider how it would manage the features in these patches. Most of these design decisions are implemented in the following patches of the series: ``` vkd3d-shader/hlsl: Span variables across multiple register spaces. vkd3d-shader/hlsl: Support variables that have multiple-registers in object reg. spaces. ``` I converged to these implementations by using Zeb's advice and by hitting myself against the wall while trying to implement these features with other approaches. In short, this patch series includes: * For SM1, the tex2D and tex3D intrinsics, inferring generic samplers dimension from usage, writing sampler declarations, and writing sample instructions. * Support for arrays of resources for both SM1 and SM4 (not to be confused with the resource-arrays of SM 5.1, which can have non-constant indexes). * Support for declaring resources within structs. * Support for synthetic combined samplers for SM1 and synthetic separated samplers for SM4, considering that they can be arrays or members of structs. * All of this while imitating the way the native compiler assigns the register indexes of the resources on allocation, which proved to be the most difficult thing, and the main reason behind the design decisions, because the rules are many, and all the previous things have combined effects in the assignment order. * (There are also many small fixes to corner cases I have stumbled upon, and validations for cases that should not be supported. Most of them are in short patches and in the first half of the MR). In order to test that the allocated register indexes (in both the sampler and texture spaces) were the same as the native compiler, I did manual tests using ps_4_0, ps_5_0 and ps_3_0 and compared the CTAB/RDEF sections while trying to deduct the assignment rules. Sadly, I cannot be sure that I am covering 100% of the possible scenarios. I had to do tests manually since it is difficult to test this with the shader_runner which is also limited to SM4, and I haven't learned how to implement C tests that check the reflection data yet (like the ones in wine that Zeb mentioned test_constant_table() in dlls/d3dcompiler_43/tests/hlsl_d3d9.c). Doing these tests automatically is still missing in this MR. Nevertheless, I could implement some tests for lowering combined samplers for SM4 that also double down as tests to check for the register assignment order in: ``` tests: Add lowering combined samplers tests. ``` For reference, these are some of the tests I have been running manually both for SM1 and SM4 (with the -GeC flag): [sm1-separated-samplers.hlsl](/uploads/56019f468f60bd942385c4267dd82754/sm1-separated-samplers.hlsl) [sm1-separated-samplers-array.hlsl](/uploads/a0d08ae30075db7290f63a91d79eb73c/sm1-separated-samplers-array.hlsl) [sm1-reserves-and-arrays.hlsl](/uploads/8bcec18556a3981a98b7a206ef2883cf/sm1-reserves-and-arrays.hlsl) [sm1-reserves-and-dims.hlsl](/uploads/ccbf1b6fe3907354164b8301d179ce5d/sm1-reserves-and-dims.hlsl) [sm1-separated-samplers-2.hlsl](/uploads/81929a9401bec2050f401a53ec6597e5/sm1-separated-samplers-2.hlsl) [sm1-separated-and-combined-samplers.hlsl](/uploads/5eb72698df741498bdea262298f88257/sm1-separated-and-combined-samplers.hlsl) [sm1-combined-order.hlsl](/uploads/6e3e7ee5bacd183ea8d3535ddcb2821c/sm1-combined-order.hlsl) -- This merge request has too many patches to be relayed via email. Please visit the URL below to see the contents of the merge request. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/27

4 7

[PATCH 0/3] MR1988: ntoskrnl.exe/tests: Don't bind to specific listen port from userspace.
by Jinoh Kang (＠iamahuman) 21 Jan '23

21 Jan '23

Today, the driver_netio test client binds a new socket to a specific network port. This triggers a firewall alert on Windows 7, and the alert UI window may interfere with user32:msg tests. Fix this by binding to a dynamically-allocated port instead. Related: - https://bugs.winehq.org/show_bug.cgi?id=53891 - https://bugs.winehq.org/show_bug.cgi?id=54202 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1988

4 8

[PATCH v2 0/2] MR1975: Add indeo 5 video format support, and a generic video decoder, in winegstreamer.
by Shaun Ren (＠shaunren) 20 Jan '23

20 Jan '23

-- v2: winegstreamer: Add a generic video decoder. winegstreamer: Add WG_MAJOR_TYPE_VIDEO_INDEO video type. https://gitlab.winehq.org/wine/wine/-/merge_requests/1975

3 3

[PATCH v6 0/3] MR59: vkd3d-shader/hlsl: Avoid infinite loop in copy propagation.
by Francisco Casas (＠fcasas) 20 Jan '23

20 Jan '23

copy_propagation_transform_object_load() currently retrieves true, which indicates that there was progress, even if the input dereference remains the same. This can happen repeatedly if an uninitialized object is copied onto itself, as in the tests added in this patch. This results on the compilation getting stuck on an endless loop. This patch checks if the deref didn't change, to retrieve false in that case. -- v6: vkd3d-shader/hlsl: Validate that referenced objects are uniform. tests: Test uninitialized object references. vkd3d-shader/hlsl: Avoid infinite loop in copy propagation. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/59

2 5

[PATCH 0/1] MR1993: windows.globalization: Implement ILanguage::get_LanguageTag().
by Nikolay Sivov (＠nsivov) 20 Jan '23

20 Jan '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/1993

2 1

Re: [PATCH v3 0/1] MR1990: po: Update Korean translation. - approved
by Alexandre Julliard (＠julliard) 20 Jan '23

20 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1990

1 0

Re: [PATCH v2 0/1] MR1991: win32u: Document the font_lock handling in font_EnumFonts(). - approved
by Alexandre Julliard (＠julliard) 20 Jan '23

20 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1991

1 0

Re: [PATCH v5 0/1] MR1967: fix(winebuild): fix bug abort setting thumb_mode - approved
by Alexandre Julliard (＠julliard) 20 Jan '23

20 Jan '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1967

1 0

[PATCH 0/2] MR1992: user32/edit: Fix WM_CHAR handler for double-byte characters.
by Akihiro Sagawa (＠sgwaki) 20 Jan '23

20 Jan '23

After commit 2aa54a90, a double-byte character is sent to the edit control by double WM_CHAR messages. However, its WM_CHAR handler (ANSI version) can't process a double-byte character properly because the handler converts WM_CHAR to WCHAR one by one. This fix queues the double-byte lead byte as it comes in and then uses it afterwards for the WCHAR conversion. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54337 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1992

2 2

2025

2024

2023

2022

wine-gitlab January 2023