October 2023 - wine-gitlab

Re: [PATCH v3 0/4] MR363: vkd3d-shader/hlsl: Add constant folding for logical 'not', for bools. - approved
by Alexandre Julliard (＠julliard) 05 Oct '23

05 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/363

1 0

Re: [PATCH v2 0/5] MR342: vkd3d-shader/hlsl: Stop using hlsl_type_get_regset(). - approved
by Alexandre Julliard (＠julliard) 05 Oct '23

05 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/342

1 0

Re: [PATCH v4 0/1] MR330: vkd3d-shader/hlsl: Add fwidth() function. - approved
by Alexandre Julliard (＠julliard) 05 Oct '23

05 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/330

1 0

Re: [PATCH v2 0/1] MR389: vkd3d: Add ID3D12GraphicsCommandList5 interface stub. - approved
by Alexandre Julliard (＠julliard) 05 Oct '23

05 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/389

1 0

Re: [PATCH v5 0/1] MR385: vkd3d-shader: Fix compiler warning. - approved
by Alexandre Julliard (＠julliard) 05 Oct '23

05 Oct '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/385

1 0

Re: [PATCH v37 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Zebediah Figura (＠zfigura) 05 Oct '23

05 Oct '23

On Thu Oct 5 17:32:10 2023 +0000, Aidan Khoury wrote: > 1. Yes, however not easily. With my sample PE (which is what I used to > make the "normalized" buffers), it was not complex enough to emit patch > transformations when I used the mspatchc API. I tried for about a dozen > hours before giving in and using an existing real world buffer, which I > extracted from the adobe installers. > 2. Possible, yet extremely complicated as patch transformations appear > pretty complex. > The source of the buffers is the adobe acrobat x86_64 installer. Does that mean that the test data is copyrighted? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_47745

1 0

Re: [PATCH v37 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Zebediah Figura (＠zfigura) 05 Oct '23

05 Oct '23

On Thu Oct 5 17:33:15 2023 +0000, Aidan Khoury wrote: > So, should I make the effort or no? I'm afraid I can't give any injunctions, only telling what I would do. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_47744

1 0

Re: [PATCH v37 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) 05 Oct '23

05 Oct '23

On Tue Oct 3 16:18:47 2023 +0000, Zebediah Figura wrote: > > Oh! Okay, I will use `RtlImageNtHeader` and then do the bounds checks > afterwards :) > I suppose it's a matter of taste, but personally I don't find this an improvement... So, should I make the effort or no? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_47741

1 0

Re: [PATCH v37 0/6] MR3870: mspatcha: Add support for 32-bit file patching and normalization
by Aidan Khoury (＠ajkhoury) 05 Oct '23

05 Oct '23

On Thu Oct 5 17:32:10 2023 +0000, Jeffrey Smith wrote: > The three .h files in your tests are --in effect-- huge data blobs, > which is something that should usually be avoided in source code repositories > as far as is possible. I haven't had a chance to look in detail at how > you are using them, > but here a couple of things you may want to investigate: > 1. Can the tests be accomplished with smaller sample files? > 2. Better yet, can the buffers be --at least partially-- generated > programmatic at test time? (as I did with `setup_pe_with_sections` in > my tests) > BTW, what was your source for those three buffers? 1. Yes, however not easily. With my sample PE (which is what I used to make the "normalized" buffers), it was not complex enough to emit patch transformations when I used the mspatchc API. I tried for about a dozen hours before giving in and using an existing real world buffer, which I extracted from the adobe installers. 2. Possible, yet extremely complicated as patch transformations appear pretty complex. The source of the buffers is the adobe acrobat x86_64 installer. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3870#note_47740

1 0

[PATCH 0/3] MR4022: wined3d: Expose the image view usage to the Vulkan driver.
by Giovanni Mascellani (＠giomasce) 05 Oct '23

05 Oct '23

Some driver, e.g. MoltenVK, fail in some cases if the image view usage is too broad or unknown. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4022

4 5

2025

2024

2023

2022

wine-gitlab October 2023