October 2023 - wine-gitlab

[PATCH v2 0/1] MR3999: Msdasql header
by Alistair Leslie-Hughes (＠alesliehughes) 05 Oct '23

05 Oct '23

-- v2: include: Add some DBCOLUMN defines https://gitlab.winehq.org/wine/wine/-/merge_requests/3999

2 1

[PATCH 0/2] MR4018: winemac.drv: Use @autoreleasepool instead of NSAutoreleasePool.
by Brendan Shanks (＠bshanks) 05 Oct '23

05 Oct '23

`@autoreleasepool` is the newer (although still 10+ years old) way of creating ObjC autorelease pools. It allows simpler control flow, is possibly more efficient, and is a prerequisite to adopting ARC (no immediate plans for that, but it could happen in the future). I didn't add an indentation level for `@autoreleasepool` blocks covering a whole function (the common case by far), but did indent smaller blocks. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4018

2 2

Re: [PATCH 0/1] MR202: server: Hold socket reference in sock_poll_event().
by Zebediah Figura (＠zfigura) 05 Oct '23

05 Oct '23

> I think I never encountered this issue in the wild, hit it back then when was making tests for something else, sent this and forgot about it too. I don't know for sure that I've hit this in the wild, but I've *definitely* hit that assertion before and been unable to track it down. And, well, no matter what happens, the server shouldn't crash, so this is definitely worth fixing. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/202#note_47654

1 0

Re: [PATCH 0/1] MR202: server: Hold socket reference in sock_poll_event().
by Paul Gofman (＠gofman) 05 Oct '23

05 Oct '23

I think I never encountered this issue in the wild, hit it back then when was making tests for something else, sent this and forgot about it too. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/202#note_47653

1 0

[PATCH 0/1] MR3973: winsock: Map EDESTADDRREQ to STATUS_INVALID_CONNECTION.
by Paul Gofman (＠gofman) 05 Oct '23

05 Oct '23

Fixes Nascar Heat 5 not being able to connect to multiplayer lobby. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3973

4 3

[PATCH v34 0/1] MR3074: Move getpeername() implementation to wineserver
by Ally Sommers (＠dropbear) 05 Oct '23

05 Oct '23

`getpeername()` is currently handled in ntdll. This merge request changes ntdll to forward `getpeername()` to wineserver. The implementation utilises new `peer_addr` and `peer_addr_len` fields in wineserver's `struct sock`. This fixes multiple `todo_wine`s in `ws2_32/tests` and allows for more accurate peer names to be provided in case the address the socket is bound to on the Unix side does not match what `bind()` was called with on the Windows side. *This merge request was originally intended to be included in !2786 (Add support for AF_UNIX sockets) but was split into its own merge request because this is not an insignificant change.* -- v34: server: Move getpeername() implementation from ntdll/unix. https://gitlab.winehq.org/wine/wine/-/merge_requests/3074

4 3

Re: [PATCH 0/1] MR202: server: Hold socket reference in sock_poll_event(). - approved
by Zebediah Figura (＠zfigura) 05 Oct '23

05 Oct '23

This merge request was approved by Zebediah Figura. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/202

1 0

Re: [PATCH 0/1] MR202: server: Hold socket reference in sock_poll_event().
by Zebediah Figura (＠zfigura) 05 Oct '23

05 Oct '23

I have no idea why this never got noticed, but I've reviewed this now, it still applies, and it looks correct to me. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/202#note_47648

1 0

Re: [PATCH v6 0/1] MR3966: mpr: WNetAddConnection*() and WNetCancelConnection*() always return success
by Zebediah Figura (＠zfigura) 04 Oct '23

04 Oct '23

I don't think we want this kind of hack in Wine. > Allowing for manual configuration outside of wine. What does this mean? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3966#note_47646

1 0

[PATCH 0/2] MR3915: ddraw/tests: Test WS_EX_TOPMOST restoration.
by Zhiyi Zhang (＠zhiyi) 04 Oct '23

04 Oct '23

Test that there is a ~1.5s timer after entering fullscreen mode and restores WS_EX_TOPMOST if it's missing when the timer times out. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3915

4 7

2025

2024

2023

2022

wine-gitlab October 2023