On Sun Oct 1 13:54:50 2023 +0000, YuriK7 wrote:
> Adding the gstkrkr .so files does indeed fix the issue even without this
> merge an azumanga fighter and HaruToma 2. It didn't worked with touhou
> sky fight but I couldn't test with your merge as it hangs with vanilla wine.
> I thought wine-ge had all the plugins, as I used their libs to get rid
> of the missing MPEG1 decoder issue. Do you know exactly which
> plugin/part/flag they have to add ?
Glorious-Eggroll has a MPEG demuxer, which Proton's GStreamer lacks, but neither of them have any MPEG-1 video decoder.
From what I can google, the correct incantation is adding --enable-decoder=mpegvideo to GE's ffmpeg configure line; if successful, it should show up in GStreamer as avdec_mpeg2video.
If adding gstkrkr works even without this MR, my guess is that those programs tell DirectShow to automatically pick the appropriate decoders, which ends up using CLSID_decodebin_parser instead of CLSID_CMpegVideoCodec; you were missing the codec, but nothing else.
If adding this MR makes it hang or otherwise screw up, that's definitely something I should look into...
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_47297
On Sun Oct 1 13:54:50 2023 +0000, Alfred Agrell wrote:
> Yep, that one looks like a close relative of
> https://bugs.winehq.org/show_bug.cgi?id=9127 (possibly even duplicate).
> Last time I checked, Proton-GE didn't include any MPEG video decoder.
> Probably because it's unnecessary - without Wine-side support, there's
> no way to access that codec, so there's no point wasting space on it.
> Once this thing is merged, that will become a bug on their end. Feel
> free to report it.
> If you want a faster solution, you can take the GStreamer plugin from
> https://github.com/Alcaro/krkrwine/releases/tag/v1.0.0 and place it in
> the GST_PLUGIN_SYSTEM_PATH. (I wouldn't recommend installing the rest of
> that program, it's tested with Proton 8.0 only and may interact weirdly
> with this MR.)
Adding the gstkrkr .so files does indeed fix the issue even without this merge an azumanga fighter and HaruToma 2. It didn't worked with touhou sky fight but I couldn't test with your merge as it hangs with vanilla wine.
I thought wine-ge had all the plugins, as I used their libs to get rid of the missing MPEG1 decoder issue. Do you know exactly which plugin/part/flag they have to add ?
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_47296
Resolves https://bugs.winehq.org/show_bug.cgi?id=9127 . (Some of the named programs in that issue may require additional currently-missing functionality, I didn't check; but if so, that's separate issues.)
Tested with
- winetest on Windows 7
- winetest on Windows 10
- winetest in Wine, of course
- microkiri https://bugs.winehq.org/show_bug.cgi?id=9127#c102
- Wagamama High Spec Trial Edition https://wagahigh.com/download_trial.php#normal (ダウンロード means download)
- Ninki Seiyuu no Tsukurikata Trial https://archive.org/details/sayou_trial
(WMV files in microkiri and Wagamama don't work, but that's separate issues. Also, they need the LC_ALL=ja_JP env, or they throw various goofy errors.)
--
v6: quartz/tests: Add tests for CLSID_CMpegVideoCodec.
quartz/tests: Add tests for new CLSID_MPEG1Splitter functionality.
winegstreamer: Improve and clean up some debug logs.
winegstreamer: Implement a little more of IAMStreamSelect in CLSID_MPEG1Splitter.
winegstreamer: Handle format changes better in Quartz.
winegstreamer: Implement CLSID_CMpegVideoCodec.
https://gitlab.winehq.org/wine/wine/-/merge_requests/3938