--
v2: msvfw32: Use the debugstr_fourcc function instead of reimplementing it.
mscms: Use the debugstr_fourcc function instead of reimplementing it.
mciavi32: Use the debugstr_fourcc function instead of reimplementing it.
ddraw: Use the debugstr_fourcc function instead of reimplementing it.
comctl32: Use the debugstr_fourcc function instead of reimplementing it.
include: Introduce wine_dbgstr_fourcc and debugstr_fourcc.
https://gitlab.winehq.org/wine/wine/-/merge_requests/3994
vkd3d-shader/tpf.c:3810:39: warning: passing argument 2 of ‘sm4_register_from_node’ from incompatible pointer type [-Wincompatible-pointer-types]
vkd3d-shader/tpf.c:4750:59: warning: passing argument 3 of ‘sm4_register_from_deref’ from incompatible pointer type [-Wincompatible-pointer-types]
The other option is to change the parameter to a DWORD but this is a larger change.
--
v3: vkd3d-shader: Fix compiler warning.
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/385
On Tue Sep 26 23:38:34 2023 +0000, Alfred Agrell wrote:
> I don't know how many emails/etc gitlab sends, so I'm not sure if you
> saw it, but I implemented the entire thing; I think it's correct, but
> there's a fixme for the lack of tests (adding that is too far out of
> scope to belong in this MR).
> I could remove it if you don't want untested code floating around; now
> that I know what exactly it's trying to do, and what it's actually
> doing, it's not hard to work around it in the test instead.
I don't know whether this is correct or not, I think it'd be better to leave this aspect aside for now as like you said this is going a bit out of the scope of this MR.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_47467