Yes, currently MCI_MapMsgAtoW returns a tri-state.
-1 = Memory allocation error
0 = No unmap required
1 = Unmap required.
Since MCI_UnmapMsgAtoW handles all the cases where MCI_MapMsgAtoW allocates memory. Why not just
call MCI_UnmapMsgAtoW to do its thing in all cases?
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3854#note_47342
On Sun Oct 1 23:30:07 2023 +0000, YuriK7 wrote:
> Thanks !
> The game I mentioned (touhou sky fight) is a weird case. It already
> hangs (actually it just errors out and closes) without your patch on
> vanilla wine whit the gstreamer shipped with wine-ge 8-16 where they
> updated it to 1.22. With the old gstreamer it used to be a skippable
> black screen, however adding gstkrkr makes it crash. This merge doesn't
> seem to change anything on that so be reassured, I guess I …
[View More]should open
> either a wine issue or a gstreamer issue...
> But Azumanga Fighter, Higurashi Daybreak Kai and HaruToma 2 works
> perfectly well with the new gstreamer + gstkrkr (the new version show a
> color bars screen when the codec is missing, instead of playing the sound).
Yes, that is consistent with my experience. I tried Azumanga (everything looks good to me with this patch) and Touhou (crashes on Wine 8.17, Wine 8.17 with this patch, and Debian's Wine 8.0; different output before the crash, but they all segfault in SampleGrabber_ISampleGrabber_GetCurrentBuffer). Sounds like a different bug to me.
The color bars are not a Wine bug; they're protonmediaconverter. It does that if it can't find a converted version of the media, which it can't if you're running it outside Steam. gstkrkr fills that exact hole. (gstkrkr also does a little trick to ensure ffmpeg's WMA audio decoder is selected instead of mediaconverter.)
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_47318
[View Less]
On Sun Oct 1 14:18:55 2023 +0000, Alfred Agrell wrote:
> Glorious-Eggroll has a MPEG demuxer, which Proton's GStreamer lacks, but
> neither of them have any MPEG-1 video decoder.
> From what I can google, the correct incantation is adding
> --enable-decoder=mpegvideo to GE's ffmpeg configure line; if successful,
> it should show up in GStreamer as avdec_mpeg2video.
> If adding gstkrkr works even without this MR, my guess is that those
> programs tell DirectShow to …
[View More]automatically pick the appropriate decoders,
> which ends up using CLSID_decodebin_parser instead of
> CLSID_CMpegVideoCodec; you were missing the codec, but nothing else.
> If adding this MR makes it hang or otherwise screw up, that's definitely
> something I should look into...
Thanks !
The game I mentioned (touhou sky fight) is a weird case. It already hangs (actually it just errors out and closes) without your patch on vanilla wine whit the gstreamer shipped with wine-ge 8-16 where they updated it to 1.22. With the old gstreamer it used to be a skippable black screen, however adding gstkrkr makes it crash. This merge doesn't seem to change anything on that so be reassured, I guess I should open either a wine issue or a gstreamer issue...
But Azumanga Fighter, Higurashi Daybreak Kai and HaruToma 2 works perfectly well with the new gstreamer + gstkrkr (the new version show a color bars screen when the codec is missing, instead of playing the sound).
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3938#note_47317
[View Less]
--
v3: ntdll: Add support for FILE_{RENAME,LINK}_POSIX_SEMANTICS.
ntdll: Factored out get_inode_open_sharing.
ntdll/test: Add tests for FILE_LINK_POSIX_SEMANTICS.
ntdll/test: Add tests for FILE_RENAME_POSIX_SEMANTICS.
ntdll: Add support for FILE_{RENAME,LINK}_IGNORE_READONLY_ATTRIBUTE.
server: Don't allow read-only files to be replaced by File{Rename,Link}Information{,Ex}.
ntdll/test: Add tests for FILE_LINK_IGNORE_READONLY_ATTRIBUTE.
ntdll/test: Add …
[View More]tests for FILE_RENAME_IGNORE_READONLY_ATTRIBUTE.
ntdll/test: Use FileDispositionInformationEx to delete files and directories.
ntdll: Initial implementation of FileLinkInformationEx.
ntdll: Initial implementation of FileRenameInformationEx.
https://gitlab.winehq.org/wine/wine/-/merge_requests/3907
[View Less]