October 2023 - wine-gitlab

[PATCH v6 0/6] MR4092: user32: Actually implement RealGetWindowClass{A/W}.
by Connor McAdams (＠cmcadams) 20 Oct '23

20 Oct '23

-- v6: user32: Pass real argument to NtUserGetClassName in RealGetWindowClass{A/W}. win32u: Add support for retrieving real window class ID across processes. user32: Set real window class ID for user32 static controls. win32u/tests: Add a test for real window class name retrieval. comctl32/tests: Add tests for RealGetWindowClass. user32/tests: Add tests for RealGetWindowClass. https://gitlab.winehq.org/wine/wine/-/merge_requests/4092

3 8

[PATCH v2 0/7] MR4139: dmime, dmusic: Miscellaneous fixes.
by Rémi Bernon (＠rbernon) 20 Oct '23

20 Oct '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55792 Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55790 -- v2: dmime: Avoid releasing the newly created graph twice. dswave: Use the dmusic wave object implementation. dmusic: Use the IDirectMusicObject interface for waves. dmusic: Implement IDirectMusicObject interface on wave objects. dmime: Return hr from wave track SetParam GUID_DownloadToAudioPath. dmime: Return S_OK from wave track SetParam GUID_UnloadFromAudioPath. dmime: Avoid crashing when purging notification messages. https://gitlab.winehq.org/wine/wine/-/merge_requests/4139

3 9

[PATCH v4 0/2] MR4054: mshtml: HTMLWindow behavior improvements.
by Gabriel Ivăncescu (＠insn) 20 Oct '23

20 Oct '23

-- v4: mshtml: Return proper errors when navigating with no browser. mshtml: Set outer window to uninitialized page when document obj is released. https://gitlab.winehq.org/wine/wine/-/merge_requests/4054

4 7

[PATCH v6 0/7] MR3007: Draft: ntdll: Avoid requests with null pointer but invalid size.
by Bernhard Übelacker (＠bernhardu) 20 Oct '23

20 Oct '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=51770 - v1: - https://www.winehq.org/pipermail/wine-devel/2021-December/202913.html - https://www.winehq.org/pipermail/wine-devel/2022-April/213866.html (resend) - v2: - https://www.winehq.org/pipermail/wine-devel/2022-April/214306.html - Validate pointer before calling wine_server_add_data. - v3: (d4a7440a) - https://www.winehq.org/pipermail/wine-devel/2022-May/218285.html - Move check to DeviceIoControl. - Always use fixed values for IOCTL_STORAGE_GET_DEVICE_NUMBER. - Remove warning at expected hang. - v4: (6a69c680) - Fix typo in commit message. - Modified format strings. - v5: (47784feb) - Move test to own test function. - Move check to wine_server_add_data. - v6: (8c641d09) - Move check to NtDeviceIoControlFile - Add (at least temporary) tests to compare with NtDeviceIoControlFile and NtFsControlFile. -- v6: ntoskrnl.exe/test: Add some temporary debugging output. kernel32/tests: Add test for IOCTL_STORAGE_GET_DEVICE_NUMBER. ntdll: Add validation for input and output buffers in NtDeviceIoControlFile. ntoskrnl.exe: Allow sending a null input buffer to the driver. ntoskrnl.exe: Add todo_wine_if to test_ioctl_buffers. ntoskrnl.exe: Remove buffer assignments in test_ioctl_buffers. ntoskrnl.exe: Add test_ioctl_buffers. https://gitlab.winehq.org/wine/wine/-/merge_requests/3007

4 8

[PATCH v6 0/1] MR4049: ntdll: Implement thread-ID alerts using kqueue()/kevent()
by Marc-Aurel Zent (＠marzent) 20 Oct '23

20 Oct '23

This allows *BSDs to also have a fast path similar to futexes for thread-ID alerts. Also a kevent with `EV_CLEAR` and `NOTE_TRIGGER` maps perfectly to the thread alertable state, fixing the issue of the current mach-semaphore implementation not correctly waiting in the test case below: ``` NtAlertThreadByThreadId((HANDLE)GetCurrentThreadId()); NtAlertThreadByThreadId((HANDLE)GetCurrentThreadId()); NtWaitForAlertByThreadId(NULL, NULL); NtWaitForAlertByThreadId(NULL, NULL); ``` I took the liberty to remove this mach semaphore implementation, since all versions of OSX have supported kqueue(). -- v6: ntdll: Implement thread-ID alerts using kqueue/kevent. https://gitlab.winehq.org/wine/wine/-/merge_requests/4049

3 3

[PATCH v10 0/4] MR1088: ntdll: Avoid calling pthread_exit on thread exit.
by Rémi Bernon (＠rbernon) 20 Oct '23

20 Oct '23

Using a dedicated exit jmpbuf and removing the need for assembly routines. When Wine handles an exception in unix code, we return to user mode by jumping to the last syscall frame. This can leave some pthread cancel cleanups registered, in the pthread internal linked list, and at the same time later overwrite the stack frame they were registered for. In the same way, jumping to the exit frame on thread exit or abort, can also leave some cleanup handlers registered for invalid stack frames. Depending on the implementation, calling pthread_exit will cause all the registered pthread cleanup handlers to be called, possibly jumping back to now overwritten stack frames and causing segmentation faults. Exiting a pthread normally, by returning from its procedure, or calling exit(0) for the main thread doesn't run pthread_exit and doesn't call cleanup handlers, avoiding that situation. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=52213 ### Additional note: For robustness, we should probably try to execute these cleanup handlers when unwinding the stack frames, as we would otherwise leave pthread objects in a potential problematic state (like a mutex locked, etc). It is however hard to do so when the handlers are registered from some C code: pthread C implementation is done by calling some internal pthread functions to register the handlers, and they aren't registered as standard unwind handlers. Only pthread_cancel and pthread_exit can unwind and call / unregister the C handlers, but interrupting that procedure, for instance calling setjmp / longjmp from withing our own handler isn't supported. From C++ code, pthread cleanup handlers are registered through C++ class constructors / destructors, and it would then be possible to partially unwind and call them at the same time. -- v10: ntdll: Remove now unnecessary arch-specific exit frame. ntdll: Avoid calling pthread_exit from abort_thread. ntdll: Avoid calling abort_thread from the signal stack. ntdll: Use is_inside_syscall more consistently. https://gitlab.winehq.org/wine/wine/-/merge_requests/1088

3 9

[PATCH v15 0/12] MR3938: winegstreamer: Implement CLSID_CMpegVideoCodec
by Alfred Agrell (＠Alcaro) 20 Oct '23

20 Oct '23

Resolves https://bugs.winehq.org/show_bug.cgi?id=9127 . (Some of the named programs in that issue may require additional currently-missing functionality, I didn't check; but if so, that's separate issues.) Tested with - winetest on Windows 7 - winetest on Windows 10 - winetest in Wine, of course - microkiri https://bugs.winehq.org/show_bug.cgi?id=9127#c102 - Wagamama High Spec Trial Edition https://wagahigh.com/download_trial.php#normal (ダウンロード means download) - Ninki Seiyuu no Tsukurikata Trial https://archive.org/details/sayou_trial (WMV files in microkiri and Wagamama don't work, but that's separate issues. Also, they need the LC_ALL=ja_JP env, or they throw various goofy errors.) -- v15: quartz/tests: Add tests for CLSID_CMpegVideoCodec. quartz/tests: Add tests for new CLSID_MPEG1Splitter functionality. winegstreamer: Improve and clean up some debug logs. winegstreamer: Include the framerate when converting video format to GstCaps. winegstreamer: Don't read format from unparsed MPEG audio. winegstreamer: Seek to end of stream instead of to stream duration. winegstreamer: Implement a little more of IAMStreamSelect in CLSID_MPEG1Splitter. winegstreamer: Implement CLSID_CMpegVideoCodec. winegstreamer: Add program stream and video output support to CLSID_MPEG1Splitter. https://gitlab.winehq.org/wine/wine/-/merge_requests/3938

3 13

[PATCH 0/1] MR4133: mfmediaengine: Don't send event notify when engine is shutdown.
by Yuxuan Shui (＠yshui) 20 Oct '23

20 Oct '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4133

3 2

[PATCH 0/1] MR4149: msxml: Always increase error count when detect
by Alistair Leslie-Hughes (＠alesliehughes) 20 Oct '23

20 Oct '23

The error count wasn't be increased if tracing was disabled. eg CI. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55720 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4149

3 5

[PATCH v2 0/3] MR4135: d2d1: -Wenum-conversion warning fixes
by Jacek Caban (＠jacek) 20 Oct '23

20 Oct '23

-- v2: d2d1: Don't cast D2D1_THREADING_MODE to D2D1_FACTORY_TYPE in D2D1CreateDevice. d2d1: Pass interpolation mode as D2D1_INTERPOLATION_MODE to d2d_device_context_draw_bitmap. d2d1/tests: Use D2D1_INTERPOLATION_MODE constants in DrawImage calls. https://gitlab.winehq.org/wine/wine/-/merge_requests/4135

4 5

2025

2024

2023

2022

wine-gitlab October 2023