November 2023 - wine-gitlab

[PATCH v3 0/2] MR4232: ntdll: Handle LFH blocks allocated in large blocks in heap_validate_ptr().
by Paul Gofman (＠gofman) 06 Nov '23

06 Nov '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55842 The bug blames commit 059094c1c18ddc33b04eac53a72fd0eb7510be94 ("ntdll: Define heap block's BLOCK_FLAG_LFH as 0x80.") but actually before the blamed commit that worked essentially by chance. The problem the patch is solving is that RtlValidateHeap() currently always fails for LFH blocks allocated from large block memory (vs subheap blocks). That can happen for large enough LFH block sizes. In case of the regressed game the user of RtlValidateHeap() is msvcr80.msvcrt_heap_free() which uses HeapValidate() to guess the heap used to allocate the pointer to free. I am attaching a standalone test program which can be used to reproduce the problem without the patch. [test_lfh_validate.c](/uploads/006b04a9a00ffb7949956b66a275d5cf/test_lfh_validate.c) -- v3: ntdll: Fix pending free block validation in heap_validate() for LFH blocks. ntdll: Handle LFH blocks allocated in large blocks in heap_validate_ptr(). https://gitlab.winehq.org/wine/wine/-/merge_requests/4232

3 5

Re: [PATCH v5 0/3] MR4243: rtworkq: free cancelled work items
by Yuxuan Shui (＠yshui) 06 Nov '23

06 Nov '23

added `todo_wine` as per discussed -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4243#note_51078

1 0

[PATCH v4 0/3] MR4243: rtworkq: free cancelled work items
by Yuxuan Shui (＠yshui) 06 Nov '23

06 Nov '23

-- v4: rtworkq: Release cancelled work items. mfplat: tests: Validate MFCancelWorkItem releases the callback. rtworkq: Avoid use-after-free. https://gitlab.winehq.org/wine/wine/-/merge_requests/4243

4 12

[PATCH 0/2] MR4293: Msxml add get xml
by Daniel Lehman (＠dlehman25) 06 Nov '23

06 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4293

3 3

[PATCH v8 0/5] MR409: vkd3d-shader/dxil: Implement the DXIL BINOP instruction.
by Conor McCarthy (＠cmccarthy) 06 Nov '23

06 Nov '23

-- v8: vkd3d-shader/dxil: Implement the DXIL BINOP instruction. vkd3d-shader/spirv: Support VKD3D_DATA_UINT in spirv_compiler_emit_neg(). vkd3d-shader/spirv: Handle the UMUL instruction. vkd3d-shader/spirv: Introduce an IDIV instruction. vkd3d-shader/spirv: Introduce an FREM instruction. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/409

3 8

[PATCH v3 0/5] MR445: Draft: gitlab: Expect builds to always succeed, even when tests are allowed to fail.
by Giovanni Mascellani (＠giomasce) 06 Nov '23

06 Nov '23

This requires !423. -- v3: gitlab: Expect builds to always succeed, even when tests are allowed to fail. include: Import vkd3d_d3dcompiler.h instead of redefining D3D_BLOB_PART. ci: Make the MoltenVK logging less verbose. vkd3d-shader: Explicitly cast vkd3d_shader_global_flags to uint64_t. ci: Allow the artifact copy to fail. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/445

2 5

[PATCH v6 0/8] MR4284: msvcrt: Add implementation and fixes to localize functions
by Bartosz Kosiorek (＠gang65) 06 Nov '23

06 Nov '23

-- v6: msvcrt: Fix _strnicmp and _strnicmp_l implementation. msvcrt: Add _mbsnicmp_l implementation msvcrt: Add _mbsncpy_l implementation msvcrt: Add _mbsnbcnt_l implementation msvcrt: Add _mbsnbcmp_l implementation msvcrt: Add _mbsupr_l implementation msvcrt: Fix _mbslwr_s_l implementation msvcrt: Add _mbsbtype_l implementation https://gitlab.winehq.org/wine/wine/-/merge_requests/4284

3 14

[PATCH v2 0/1] MR445: gitlab: Expect builds to always succeed, even when tests are allowed to fail.
by Giovanni Mascellani (＠giomasce) 06 Nov '23

06 Nov '23

-- v2: gitlab: Expect builds to always succeed, even when tests are allowed to fail. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/445

2 1

[PATCH v5 0/8] MR4284: msvcrt: Add implementation and fixes to localize functions
by Bartosz Kosiorek (＠gang65) 06 Nov '23

06 Nov '23

-- v5: msvcrt: Fix _strnicmp and _strnicmp_l implementation. msvcrt: Add _mbsnicmp_l implementation msvcrt: Add _mbsncpy_l implementation msvcrt: Add _mbsnbcnt_l implementation msvcrt: Add _mbsnbcmp_l implementation msvcrt: Add _mbsupr_l implementation msvcrt: Fix _mbslwr_s_l implementation msvcrt: Add _mbsbtype_l implementation https://gitlab.winehq.org/wine/wine/-/merge_requests/4284

3 9

[PATCH 0/1] MR445: gitlab: Expect builds to always succeed, even when tests are allowed to fail.
by Giovanni Mascellani (＠giomasce) 06 Nov '23

06 Nov '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/445

2 1

2025

2024

2023

2022

wine-gitlab November 2023