November 2023 - wine-gitlab

[PATCH v5 0/6] MR4507: Add coml2 and start migrating a few functions from ole32
by Fabian Maurer (＠DarkShadow44) 30 Nov '23

30 Nov '23

Split off from https://gitlab.winehq.org/wine/wine/-/merge_requests/3106 -- v5: coml2: Move WriteClassStg from ole32 coml2: Move WriteClassStm from ole32 coml2: Move ReadClassStg from ole32 coml2: Move ReadClassStm from ole32 coml2: Move GetConvertStg from ole32 coml2: Add dll and move code from ole32/memlockbytes.c https://gitlab.winehq.org/wine/wine/-/merge_requests/4507

2 7

Re: [PATCH v2 0/1] MR4552: msvcrt: Initialize both ANSI and Unicode environments in both putenv() functions.
by Piotr Caban (＠piotr) 30 Nov '23

30 Nov '23

On Thu Nov 30 19:20:58 2023 +0000, Zebediah Figura wrote: > > I don't see such behavior. Could you please describe in more detail > what have you tested (preferably attaching tests diff)? It's unlikely > that native restores to initial environment in such case. > I... seem to have drastically misread my results somehow. > The attached diff does make some tests fail on Windows 10, though. > [scratch.diff](/uploads/894d1ae22c846a46b60f74af79b0f1f7/scratch.diff) I still don't get it - the same tests are failing on wine with the patch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4552#note_54428

1 0

Re: [PATCH v2 0/1] MR4552: msvcrt: Initialize both ANSI and Unicode environments in both putenv() functions.
by Zebediah Figura (＠zfigura) 30 Nov '23

30 Nov '23

> I don't see such behavior. Could you please describe in more detail what have you tested (preferably attaching tests diff)? It's unlikely that native restores to initial environment in such case. I... seem to have drastically misread my results somehow. The attached diff does make some tests fail on Windows 10, though. [scratch.diff](/uploads/894d1ae22c846a46b60f74af79b0f1f7/scratch.diff) -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4552#note_54426

1 0

[PATCH 0/1] MR4566: ntdll/unix: Add an option to inherit the Unix console handle.
by Aida Jonikienė (＠DodoGTA) 30 Nov '23

30 Nov '23

I know this breaks Windows behavior but having apps print out special debug messages to the terminal provides a good look into the applications' development (for example I know that NFS Underground has some "done" messages likely used for debugging). I also don't want to keep another revert in my Wine tree just for this one feature either so that's why I'm MR'ing this. I considered adding a registry/winecfg entry for this behavior but it would make this change much larger (and there's no good place in winecfg to put this behavior in). To enable this behavior, you can set WINEDEBUG=+unixcon variable before launching an application. Xkcd-Entry: https://xkcd.com/1172/ Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55435 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4566

2 1

Re: [PATCH v2 0/3] MR4484: comctl32: Use selected font to determine default min tab width
by Nikolay Sivov (＠nsivov) 30 Nov '23

30 Nov '23

Nikolay Sivov (@nsivov) commented about dlls/comctl32/tab.c: > - if (infoPtr->tabMinWidth < 0) > - oldcx = DEFAULT_MIN_TAB_WIDTH; > - else > + if (infoPtr->tabMinWidth < 0) { > + TEXTMETRICW text_metrics; > + HDC hdc = GetDC(infoPtr->hwnd); > + HFONT oldFont = SelectObject(hdc, infoPtr->hFont); > + GetTextMetricsW(hdc, &text_metrics); > + oldcx = text_metrics.tmAveCharWidth * MIN_CHAR_LENGTH + infoPtr->uHItemPadding * 2; > + SelectObject(hdc, oldFont); > + ReleaseDC(infoPtr->hwnd, hdc); > + } else { > oldcx = infoPtr->tabMinWidth; > + } > infoPtr->tabMinWidth = cx; > TAB_SetItemBounds(infoPtr); Could we move this segment to SetItemBounds()? It does exactly the same calculation. At the very least we should consider a helper. Or maybe we could return oldcx value from SetItemBounds()? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4484#note_54425

1 0

[PATCH 0/7] MR4565: winex11: Use helpers to attach / detach / destroy client windows.
by Rémi Bernon (＠rbernon) 30 Nov '23

30 Nov '23

After some discussion on https://gitlab.winehq.org/wine/wine/-/merge_requests/4533, this refactors how child_window are handled to make it easier to decouple them from the whole_window, and eventually have multiple detached child_window for some Vulkan use case (possibly also GL). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4565

3 9

Re: [PATCH v4 0/6] MR4522: winewayland.drv: part 10.3: Vulkan swapchain presentation
by beh 591 (＠beh_591) 30 Nov '23

30 Nov '23

On Wed Nov 29 09:33:45 2023 +0000, Stefan Riesenberger wrote: > Thanks for the quick answer! > Yeah if everything diverged too much it makes no sense wasting time on rebasing. > Looking forward to everything getting upstream then! I hope the road > will be less bumpy next year as it has been this year. looking forward for the mouselock support (you mean putting the cursor in the center I suppose) basically all I need to switch to wine-wayland which is great having support for wl-clipboard is appreciated since xwayland is broken -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4522#note_54421

1 0

[PATCH v3 0/4] MR4441: Adding tests for CreateProcess and std handles.
by eric pouech (＠epo) 30 Nov '23

30 Nov '23

Various new tests for CreateProcess showing a couple of issues in current implementation. -- v3: kernelbase: Reset std handles gotten by GetStartupInfo(). ntdll,server: Revisit std handles inheritance. kernel32/tests: Add more tests about CreateProcess. kernel32/tests: Introduce a new infrastructure for testing CreateProcess(). https://gitlab.winehq.org/wine/wine/-/merge_requests/4441

3 9

[PATCH 0/9] MR4546: [PATCH] Implement bypass process freeze flag (0x40) in NtCreateThreadEx
by Dāvis Mosāns (davispuh) (＠davispuh) 30 Nov '23

30 Nov '23

https://secret.club/2021/01/04/thread-stuff.html https://research.checkpoint.com/2023/raspberry-robin-anti-evasion-how-to-ex… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4546

3 4

[PATCH 0/1] MR4563: wineps.drv: Fix printing images from iexplore.
by Piotr Caban (＠piotr) 30 Nov '23

30 Nov '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4563

2 1

2025

2024

2023

2022

wine-gitlab November 2023