Nikolay Sivov (@nsivov) commented about dlls/comctl32/tab.c:
> - if (infoPtr->tabMinWidth < 0)
> - oldcx = DEFAULT_MIN_TAB_WIDTH;
> - else
> + if (infoPtr->tabMinWidth < 0) {
> + TEXTMETRICW text_metrics;
> + HDC hdc = GetDC(infoPtr->hwnd);
> + HFONT oldFont = SelectObject(hdc, infoPtr->hFont);
> + GetTextMetricsW(hdc, &text_metrics);
> + oldcx = text_metrics.tmAveCharWidth * MIN_CHAR_LENGTH + infoPtr->uHItemPadding * 2;
> + SelectObject(hdc, oldFont);
> + ReleaseDC(infoPtr->hwnd, hdc);
> + } else {
> oldcx = infoPtr->tabMinWidth;
> + }
> infoPtr->tabMinWidth = cx;
> TAB_SetItemBounds(infoPtr);
Could we move this segment to SetItemBounds()? It does exactly the same calculation. At the very least we should consider a helper. Or maybe we could return oldcx value from SetItemBounds()?
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/4484#note_54425
On Wed Nov 29 09:33:45 2023 +0000, Stefan Riesenberger wrote:
> Thanks for the quick answer!
> Yeah if everything diverged too much it makes no sense wasting time on rebasing.
> Looking forward to everything getting upstream then! I hope the road
> will be less bumpy next year as it has been this year.
looking forward for the mouselock support (you mean putting the cursor in the center I suppose)
basically all I need to switch to wine-wayland which is great
having support for wl-clipboard is appreciated since xwayland is broken
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/4522#note_54421
Various new tests for CreateProcess showing a couple of issues
in current implementation.
--
v3: kernelbase: Reset std handles gotten by GetStartupInfo().
ntdll,server: Revisit std handles inheritance.
kernel32/tests: Add more tests about CreateProcess.
kernel32/tests: Introduce a new infrastructure for testing CreateProcess().
https://gitlab.winehq.org/wine/wine/-/merge_requests/4441
On Thu Nov 30 15:33:34 2023 +0000, Yona-TYT wrote:
> I did a little test with the Jagex Launcher to play oldrunescape, but in
> wayland the window is completely black.
> Even so, I was able to execute by guessing where the "Play" button was.
> [JagexLauncherInstaller.exe](https://cdn.jagex.com/Jagex%20Launcher%20Instal…
> x11:
> wayland
From a quick look, the launcher uses CEF (Chromium Embedded Framework). CEF typically uses cross-process rendering which is not supported in the upstream Wayland driver yet.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3909#note_54400
I did a little test with the Jagex Launcher to play oldrunescape, but in wayland the window is completely black.
Even so, I was able to execute by guessing where the "Play" button was.
[JagexLauncherInstaller.exe](https://cdn.jagex.com/Jagex%20Launcher%20Instal…
x11:
wayland
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3909#note_54398