On Mon Nov 13 10:09:34 2023 +0000, Yuxuan Shui wrote:
> What errors are you getting?
> I don't think it needs special build instructions? I link it with
> mfplat, mf, ole32 and combase.
First thing is that it's not supported in current mingw-w64. And I'm not sure if building cpp stuff with it will work at all on windows.
The "hit race" condition is not really a race, isn't it? It means callback was called after item was cancelled. That could mean that cancellation does not work, but it's not a problem in call order I think. Regarding managing TP objects, does our rtworkq work correctly on Windows? Maybe we need to fix something on threadpool side.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/4243#note_52107
This serie:
- adds a couple of msvcrt env tests (mainly env block inheritance)
- introduces env tests for ucrtbase
- reimplement most of the env related functions to mimic native
behavior (basically when env is modified, native crt uses
a per-variable entry allocation block (instead of having
pointers inside a single chunk of memory).
This fixes programs which keep a pointer on returned getenv()
string and expect that pointer content is not modified when
other variables in env are modified.
@piotr: from previous version
- I dropped the synchronization of \_environ and \_wenviron
hence requiring the duplication of most of the code in
ansi/unicode versions
- I also tested the changes with unicode crt startup code
(you can find in [1] this MR extended with this test code
but I don't think we want to push it upstream)
- there are some init code changes because of ucrtbase tests
and unicode crt startup tests
[1] https://gitlab.winehq.org/epo/wine/-/tree/mr-crt-env-full?ref_type=heads
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/4377
That's just an ad-hoc hack. What's the use case for configuring folders individually? How are we going to ensure that prefix updates to the right thing? How can it be enabled/disabled after prefix creation? How is it going to handle inability to open Unix files (fonts etc.)? This needs a lot more thought and a proper design.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/3259#note_52102
On Sun Nov 12 17:58:00 2023 +0000, Nikolay Sivov wrote:
> Thanks. How do I build this?
What errors are you getting?
I don't think it needs special build instructions? I link it with mfplat, mf, ole32 and combase.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/4243#note_52101