November 2023 - wine-gitlab

[PATCH v9 0/6] MR459: vkd3d-shader/dxil: Implement the DXIL VSELECT instruction.
by Conor McCarthy (＠cmccarthy) 13 Nov '23

13 Nov '23

-- v9: vkd3d-shader/spirv: Avoid invalid bool-to-bool conversion in spirv_compiler_emit_movc(). vkd3d-shader/dxil: Implement the DXIL VSELECT instruction. tests/shader-runner: Add tests for 64-bit casts. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/459

3 9

[PATCH v8 0/6] MR459: vkd3d-shader/dxil: Implement the DXIL VSELECT instruction.
by Conor McCarthy (＠cmccarthy) 13 Nov '23

13 Nov '23

-- v8: vkd3d-shader/spirv: Avoid invalid bool-to-bool conversion in spirv_compiler_emit_movc(). vkd3d-shader/dxil: Implement the DXIL VSELECT instruction. tests/shader-runner: Add tests for 64-bit casts. vkd3d-shader/spirv: Return an error if an invalid handler is encountered. tests/shader-runner: Add a test for float comparisons. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/459

3 10

[PATCH 0/1] MR466: vkd3d-shader: Implement scanning combined resource/sampler information.
by Henri Verbeet (＠hverbeet) 13 Nov '23

13 Nov '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/466

3 6

Re: [PATCH v2 0/7] MR4375: dmsynth: Various fixes 2
by Rémi Bernon (＠rbernon) 13 Nov '23

13 Nov '23

Rémi Bernon (@rbernon) commented about dlls/dmsynth/synth.c: > struct wave *wave; > }; > > +struct fixup > +{ > + struct list entry; > + int dst; > + int src; > + int flags; > + > + int fixup_dst; > + float amount; > +}; > + Instead of a dynamic list, could we have just a simple structure like: ```c struct gen_increments { float env_hold; float env_decay; float vol_hold; float vol_decay; }; ``` Which we would pass around down to `add_mod_from_connection` which would set the needed adjustments (it's actually only needed there, `set_gen_from_connection` won't have to add increments), and then after the loops we would call `fluid_voice_gen_incr` for each of these? Or do we need the generic version for more fixups that are not in this MR? -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4375#note_52124

1 0

[PATCH v5 0/7] MR4358: dmime: Implement performance stop and segment repeat.
by Rémi Bernon (＠rbernon) 13 Nov '23

13 Nov '23

-- v5: dmime: Implement segment state repeat and looping. dmime: Split segment_state_play_chunk helper. dmsynth: Reset synthesizer defaults on MIDI_SYSTEM_RESET. dmime: Send MIDI_SYSTEM_RESET message on performance reset. dmime: Clear all pending messages in IDirectMusicPerformance_Stop. dmime/tests: Test that IDirectMusicPerformance_Stop clears messages. dmime/tests: Avoid discarding old notifications in test. https://gitlab.winehq.org/wine/wine/-/merge_requests/4358

3 8

Re: [PATCH v2 0/7] MR4375: dmsynth: Various fixes 2
by Rémi Bernon (＠rbernon) 13 Nov '23

13 Nov '23

Although they look fine, 20ab5954 (and ec219ce1 even more) cut some notes early in FF VIII intro. Haven't really looked into the details but 0ff26da7 feels a bit complicated, I'm wondering if there's a better way to do this. Regarding 2e226c26, is this what native does? Fwiw I'm thinking that if we want to have a much more robust SF2 / DLS2 mapping, it may be a good thing to have more dmsynth tests. I already added one that does basic sample rendering without checking the output, but maybe we should extend it to compare the rendered samples with various input. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4375#note_52119

1 0

[PATCH 0/2] MR469: vkd3d-shader/dxil: Handle missing flags as zero.
by Conor McCarthy (＠cmccarthy) 13 Nov '23

13 Nov '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/469

3 3

Re: [PATCH v5 0/3] MR4243: rtworkq: free cancelled work items
by Nikolay Sivov (＠nsivov) 13 Nov '23

13 Nov '23

On Mon Nov 13 10:09:34 2023 +0000, Yuxuan Shui wrote: > What errors are you getting? > I don't think it needs special build instructions? I link it with > mfplat, mf, ole32 and combase. First thing is that it's not supported in current mingw-w64. And I'm not sure if building cpp stuff with it will work at all on windows. The "hit race" condition is not really a race, isn't it? It means callback was called after item was cancelled. That could mean that cancellation does not work, but it's not a problem in call order I think. Regarding managing TP objects, does our rtworkq work correctly on Windows? Maybe we need to fix something on threadpool side. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4243#note_52107

1 0

[PATCH 0/1] MR465: vkd3d-shader/dxil: Fully initialize instruction data in sm6_parser_emit_extractval().
by Nikolay Sivov (＠nsivov) 13 Nov '23

13 Nov '23

Noticed after test runner started crashing when tracing is enabled. Signed-off-by: Nikolay Sivov <nsivov(a)codeweavers.com> -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/465

5 7

[PATCH 0/3] MR468: vkd3d: A few spelling fixes.
by Nikolay Sivov (＠nsivov) 13 Nov '23

13 Nov '23

-- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/468

4 5

2025

2024

2023

2022

wine-gitlab November 2023