December 2023 - wine-gitlab

[PATCH v2 0/4] MR3024: win32u: Introduce a new rawinput dedicated thread.
by Rémi Bernon (＠rbernon) 18 Jan '24

18 Jan '24

Currently only used to keep rawinput devices updated without iterating the entire list on every change. This thread will then let us solve several problems: * Solve issues with input not being polled if/when applications aren't checking their messages. This removes the need for polling messages in DInput, which is known to confuse and break DOSBOX. * Solve some issues with ll-hook deadlocks between hooking threads and the thread that is currently polling for inputs. * Useful to process internal messages and implement some user driver mechanisms. It can for instance already process WM_WINE_CLIPCURSOR messages, instead of relying on the foreground thread. * Similarly, for cursor icon changes, wineserver can notify it on cursor window changes and request the cursor icon to be updated from the user driver, instead of having to check the window the cursor is located in to change its icon on every mouse move. * Ultimately make it possible to drop the __wine_send_input PE export, the thread can read HID reports from devices that a process has registered for, and send WM_INPUT messages accordingly. This has some drawbacks though, as reading NT devices currently involves much more wineserver roundtrips than `__wine_send_input`. There's evidence that Windows uses a similar thread to process hardware events (as described in https://devblogs.microsoft.com/oldnewthing/20140213-00/?p=1773), although it's probably a system-wide kernel thread. I considered reading X11 input from a per-prefix dedicated thread (for instance in explorer.exe) or dedicated process, but having one thread per-process has several advantages. The rawinput device registration state is done per-process and according to https://gitlab.winehq.org/wine/wine/-/merge_requests/2120 it also needs to post notifications that are process specific. It also keeps the guarantee that each process will read the inputs from the window it has created, and not from some other windows, although the message dispatch may decide to send the message to another process later, it avoids having to listen to input on other processes windows. It can then be seen as an intermediate step towards having a per-prefix thread, if that's something we end up needing. Moving from a per-process thread to a per-prefix thread should be easier. -- v2: win32u: Keep rawinput device list updated using WM_DEVICECHANGE. win32u: Register for device notifications in the rawinput thread. win32u: Introduce a dedicated thread for rawinput processing. ntdll/tests: Use combase instead of comctl32 as a test module. https://gitlab.winehq.org/wine/wine/-/merge_requests/3024

4 8

[PATCH 0/2] MR3264: dinput: Improve keyboard devices scancode support.
by Rémi Bernon (＠rbernon) 18 Jan '24

18 Jan '24

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55205 This is not really a bug upstream because of the limited X11 scancode support, but it becomes one with the staging fixed scancode patch which enumerates more keys in the upper scancode range. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/3264

2 3

[PATCH v6 0/2] MR364: vkd3d-shader/hlsl: Implement inverse trigonometry.
by Petrichor Park (＠petrathekat) 15 Jan '24

15 Jan '24

Implements asin, acos, atan, and atan2. Also includes some tests in a new test file. One possible problem here is that I'm not sure how to test what Microsoft's atan and atan2 outputs are in boundary cases like atan2(1, 0). I've made the test suites adhere with the calculator program I've been using (Qalculate, which I assume is using libc's atan2). Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55154 -- v6: vkd3d-shader/hlsl: Implement atan and atan2. vkd3d-shader/hlsl: Implement acos and asin trig intrinsics. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/364

3 7

[PATCH v10 0/4] MR4551: Server-side thread priorities implementation (Part 1)
by Marc-Aurel Zent (＠mzent) 15 Jan '24

15 Jan '24

This is the current proton thread priority implementation by @rbernon rebased for upstream with a few `#ifdef`s added since AFAIK Linux is the only operating system where threads have a unique PID which can be used to set niceness on. ~~I also ran `./tools/make_requests` on https://gitlab.winehq.org/mzent/wine/-/commit/6705d3481be0409f7e971c1d2c7a3… as well and `autoconf` on https://gitlab.winehq.org/mzent/wine/-/commit/d7bafe40c411753662b2ad97148a6… (which does blow up the line count a bit).~~ A few tiny changes ~~(with the ready variable for example)~~ are in anticipation for Part 2, which also adds Mach thread priorities and recalculates thread priorities on process priority change. Since this is a rather large MR, I hope the split here is appropriate ~~(with the second part being slightly smaller)~~, but I think logically it makes the most sense here. -- v10: server: Check wineserver privileges on init with -20 niceness. server: Use setpriority to update thread niceness when safe. https://gitlab.winehq.org/wine/wine/-/merge_requests/4551

3 9

[PATCH 0/2] MR4693: Draft: xinput: Implement XInputGetCapabilitiesEx.
by Etaash Mathamsetty (＠etaash.mathamsetty) 08 Jan '24

08 Jan '24

For after the code freeze -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4693

3 8

[PATCH v2 0/10] MR4461: include: Introduce debugstr_reftime and wine_dbgstr_reftime.
by Alex Henrie (＠alexhenrie) 07 Jan '24

07 Jan '24

This replaces Wine's 10 copies of the function. -- v2: strmbase: Use debugstr_reftime instead of reimplementing it. wmvcore: Use debugstr_reftime instead of reimplementing it. winegstreamer: Use debugstr_reftime instead of reimplementing it. quartz: Use debugstr_reftime instead of reimplementing it. qasf: Use debugstr_reftime instead of reimplementing it. mfsrcsnk: Use debugstr_reftime instead of reimplementing it. mfplat: Use debugstr_reftime instead of reimplementing it. mf: Use debugstr_reftime instead of reimplementing it. evr: Use debugstr_reftime instead of reimplementing it. include: Introduce debugstr_reftime and wine_dbgstr_reftime. https://gitlab.winehq.org/wine/wine/-/merge_requests/4461

5 19

[PATCH v5 0/5] MR463: hlsl: Fix some type handling for ternaries.
by Zebediah Figura (＠zfigura) 05 Jan '24

05 Jan '24

-- v5: vkd3d-shader/hlsl: Allow non-numeric types in the ternary operator. vkd3d-shader/hlsl: Separate an add_ternary() helper. tests: Add many more tests for ternary expressions. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/463

3 7

[PATCH v8 0/4] MR519: vkd3d-shader/dxil: Support minimum precision.
by Conor McCarthy (＠cmccarthy) 04 Jan '24

04 Jan '24

-- v8: vkd3d-shader/dxil: Support 16-bit types. vkd3d-shader/spirv: Introduce HALF and UINT16 types for minimum precision. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/519

3 5

[PATCH v2 0/1] MR4757: wined3d: Do not remove invalid BO users from the list when destroying views.
by Zebediah Figura (＠zfigura) 04 Jan '24

04 Jan '24

-- v2: wined3d: Do not remove invalid BO users from the list when destroying views. https://gitlab.winehq.org/wine/wine/-/merge_requests/4757

3 2

[PATCH v4 0/1] MR523: vkd3d: Use mutable descriptors if available.
by Conor McCarthy (＠cmccarthy) 04 Jan '24

04 Jan '24

-- v4: vkd3d: Use mutable descriptors if available. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/523

4 6

2025

2024

2023

2022

wine-gitlab December 2023