On Wed Dec 27 01:54:00 2023 +0000, Jinoh Kang wrote:
> You're correct that debuggers can be sensitive to the timing of the
> initial breakpoint.
> Adding a conformance test would let us confirm your observation, and
> ensure such regression won't happen in the future. For reference, see 2b40969c58a099f958c58909b666915991a42979.
> I'm still approving since the existing tests did not fail and I cannot
> find a particular reason `process_breakpoint();` must be placed exactly
> there in the commit history.
I'm not really sure how to write test case for this, seems quite complicated since basically need to load DLL with `int3` - if it's triggered after system breakpoint then it's a pass.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/4655#note_56427
--
v9: tests: Mark loading from stencil as buggy on MoltenVK.
tests: Mark resource arrays as buggy on MoltenVK.
tests: Mark unbounded ranges as buggy on MoltenVK.
tests: Mark predicated rendering as buggy on MoltenVK.
tests: Mark streaming output as buggy on MoltenVK.
tests: Mark some sampling tests as buggy on MoltenVK.
vkd3d-shader/spirv: Specify behavior for bit field instructions.
tests: Use a uint target for rendering uint data.
vkd3d: Specify the aspect when creating NULL UAVs.
ci: Dumps the d3d12 summary line in the CI log.
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/531
Currently, a 15 character debug channel name (e.g. `WINE_DEFAULT_DEBUG_CHANNEL(mediacontroller)`) results in no null-terminator at the end of the debug channel name array (`char name[15]`), and no compiler warning. A 16+ character name does throw an excess-initializers warning.
Arguably, the debug channel name should be treated as a fixed-length string and not null-terminated, but this would require changes in a number of places (`winedbg`, `taskmgr`, `ntdll`, `winecrt0`). Also, overly-long channel names would still only result in truncation and a compiler warning rather than an error.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/4743
--
v4: vkd3d-shader/spirv: Specify behavior for bit field instructions.
tests: Use a uint target for rendering uint data.
vkd3d: Specify the aspect when creating NULL UAVs.
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/531