December 2023 - wine-gitlab

[PATCH 0/1] MR4654: Draft: msvcrt: Protect setlocale against concurrent accesses.
by Bernhard Übelacker (＠bernhardu) 31 Dec '23

31 Dec '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55467 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4654

3 3

[PATCH v2 0/2] MR4755: readme: Update German translation.
by Snowiiii (＠Snowiiii) 30 Dec '23

30 Dec '23

-- v2: Fix typo https://gitlab.winehq.org/wine/wine/-/merge_requests/4755

2 3

[PATCH 0/1] MR4755: readme: Update German translation.
by Snowiiii (＠Snowiiii) 30 Dec '23

30 Dec '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/4755

3 2

[PATCH v13 0/16] MR531: Draft: vkd3d: Assorted fixes for MoltenVK.
by Giovanni Mascellani (＠giomasce) 30 Dec '23

30 Dec '23

-- v13: tests: Mark ReadFromSubresource() and WriteToSubresource() as todo on MoltenVK. tests: Mark a test related to instanced draws as buggy on MoltenVK. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/531

2 16

Re: [PATCH v4 0/1] MR4720: Implement test_continue() for amd64
by Dāvis Mosāns (davispuh) (＠davispuh) 30 Dec '23

30 Dec '23

On Sat Dec 30 18:30:27 2023 +0000, Dāvis Mosāns (davispuh) wrote: > changed this line in [version 3 of the diff](/wine/wine/-/merge_requests/4720/diffs?diff_id=91593&start_sha=7ed40b96224c3125f2ecbda44a47cf553e1cb82a#1104a825a741495a2a3c3093b4d85d95e4f8180f_4467_4468) Are you suggesting to clear them? I don't think that's good idea since most of them will be zeros anyway. Current implementation allows to more easily see if something doesn't get restored back. They all are filled with particular pattern. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4720#note_56500

1 0

Re: [PATCH v4 0/1] MR4720: Implement test_continue() for amd64
by Dāvis Mosāns (davispuh) (＠davispuh) 30 Dec '23

30 Dec '23

On Sat Dec 30 18:30:27 2023 +0000, Dāvis Mosāns (davispuh) wrote: > changed this line in [version 3 of the diff](/wine/wine/-/merge_requests/4720/diffs?diff_id=91593&start_sha=7ed40b96224c3125f2ecbda44a47cf553e1cb82a#1104a825a741495a2a3c3093b4d85d95e4f8180f_4443_4442) Yeah I know but I intentionally did that way to make it easier understandable/readable as I don't think few bytes matter at all. Anyway changed now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4720#note_56499

1 0

Re: [PATCH v4 0/1] MR4720: Implement test_continue() for amd64
by Dāvis Mosāns (davispuh) (＠davispuh) 30 Dec '23

30 Dec '23

On Sat Dec 30 18:30:26 2023 +0000, Dāvis Mosāns (davispuh) wrote: > changed this line in [version 3 of the diff](/wine/wine/-/merge_requests/4720/diffs?diff_id=91593&start_sha=7ed40b96224c3125f2ecbda44a47cf553e1cb82a#1104a825a741495a2a3c3093b4d85d95e4f8180f_4502_4494) Fixed -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4720#note_56498

1 0

Re: [PATCH v4 0/1] MR4720: Implement test_continue() for amd64
by Dāvis Mosāns (davispuh) (＠davispuh) 30 Dec '23

30 Dec '23

On Sat Dec 30 18:30:25 2023 +0000, Dāvis Mosāns (davispuh) wrote: > changed this line in [version 3 of the diff](/wine/wine/-/merge_requests/4720/diffs?diff_id=91593&start_sha=7ed40b96224c3125f2ecbda44a47cf553e1cb82a#1104a825a741495a2a3c3093b4d85d95e4f8180f_4427_4429) Can't stand it, updated to it now. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4720#note_56497

1 0

[PATCH 0/1] MR4759: mscoree/tests: Add debug code for RemoveDirectory failure.
by Esme Povirk (＠madewokherd) 30 Dec '23

30 Dec '23

This failed at least once on testbot, but there wasn't enough information to debug: https://testbot.winehq.org/JobDetails.pl?Key=141486&s301=1&f301=exe64.repor… -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4759

2 1

[PATCH 0/1] MR4758: winhlp32: Fix main window title.
by eric pouech (＠epo) 30 Dec '23

30 Dec '23

Main window title was incorrect in a couple of cases: - the value displayed when the .HLP file didn't contain nor the main window caption nor the default help file title was incorrect (they are different patterns used, but the trigger was incorrect) - some titles were cropped (because incorrectly stored in main window caption - which is of fixed size) Changes made: - never generate a caption when none present on file, but always fallback to the help file title in this case - generate default titles when none are present on file (title pattern depends on file version) - in pattern displaying filename, only show the basename. These changes give the same result for the main window's title on all the .hlp files from my test database. (except for some cases where 'Wine help' is used instead of 'help', but I didn't bother adding a new entry in string table). Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4758

2 1

2025

2024

2023

2022

wine-gitlab December 2023