December 2023 - wine-gitlab

Re: [PATCH v2 0/1] MR4655: ntdll: loader_init() invoke breakpoint before loading dlls
by Jinoh Kang (＠iamahuman) 25 Dec '23

25 Dec '23

You're correct that debuggers can be sensitive to the timing of the initial breakpoint. Adding a conformance test would let us confirm your observation, and ensure such regression won't happen in the future. For reference, see 2b40969c58a099f958c58909b666915991a42979. I'm still approving since the existing tests did not fail and I cannot find a particular reason `process_breakpoint();` must be placed exactly there in the commit history. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4655#note_56412

1 0

[PATCH v2 0/1] MR4703: dmime: Fix handling of curve PMSG.
by Yuxuan Shui (＠yshui) 24 Dec '23

24 Dec '23

DMUS_PMSG::dwType is the type of the message, but we are comparing it to curve types. We should be using DMUS_CURVE_PMSG::bType instead. * * * (I tried to write some test cases for this. I created a IDirectMusicPort implementation that checks the generated midi commands, but instead I cannot get Windows to generate any midi commands for CCCURVEs. ) -- v2: dmime: Fix handling of curve PMSG. https://gitlab.winehq.org/wine/wine/-/merge_requests/4703

4 5

[PATCH 0/1] MR4739: ntdll: Don't hardcode page size
by Fabian Maurer (＠DarkShadow44) 24 Dec '23

24 Dec '23

While this is not needed for 16k pages to work, it does seem sensible. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4739

2 1

[PATCH 0/1] MR4734: gdiplus: Avoid use of temporary variable
by David Kahurani (＠kahurani) 23 Dec '23

23 Dec '23

A temporary variable is used here to assist with assignment but this does not conform to the coding style in the rest of gdiplus and introduces an unnecessary variable. Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4734

3 3

[PATCH v3 0/2] MR4735: advapi32/tests: Don't run wow64 tests on 32-bit Windows
by Sven Baars (＠sbaars) 23 Dec '23

23 Dec '23

This should fix some test failures in other components. Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54613 -- v3: advapi32/tests: Skip WoW64 tests on 32-bit in test_reg_create_key. https://gitlab.winehq.org/wine/wine/-/merge_requests/4735

2 2

[PATCH v2 0/2] MR4735: advapi32/tests: Don't run wow64 tests on 32-bit Windows
by Sven Baars (＠sbaars) 23 Dec '23

23 Dec '23

This should fix some test failures in other components. Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54613 -- v2: advapi32/tests: Use has_wow64() in the test_reg_create_key test. advapi32/tests: Introduce a new has_wow64 helper. https://gitlab.winehq.org/wine/wine/-/merge_requests/4735

3 3

[PATCH 0/2] MR4735: advapi32/tests: Don't run wow64 tests on 32-bit Windows
by Sven Baars (＠sbaars) 23 Dec '23

23 Dec '23

This should fix some test failures in other components. Wine-Bug: https://bugs.winehq.org//show_bug.cgi?id=54613 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4735

3 3

[PATCH v2 0/1] MR4720: Implement test_continue() for amd64
by Dāvis Mosāns (davispuh) (＠davispuh) 23 Dec '23

23 Dec '23

Currently there is `NtContinue()` test only for `aarch64` so implement it for amd64 aswell. This implementation is very similar to `aarch64` and it's very basic test. It doesn't change/test `ContextFlags` so it won't catch https://bugs.winehq.org/show_bug.cgi?id=56050 but that can be implemented later on top of this. -- v2: ntdll/tests: Implement test_continue() for amd64 https://gitlab.winehq.org/wine/wine/-/merge_requests/4720

4 10

Re: [PATCH v2 0/1] MR4733: dxdiagn: Check ICreateDevEnum_CreateClassEnumerator result for S_OK. - approved
by Alexandre Julliard (＠julliard) 22 Dec '23

22 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4733

1 0

Re: [PATCH v2 0/1] MR4732: winedbg: Fix main module detection in 'info share' command. - approved
by Alexandre Julliard (＠julliard) 22 Dec '23

22 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4732

1 0

2025

2024

2023

2022

wine-gitlab December 2023