December 2023 - wine-gitlab

[PATCH 0/1] MR4733: dxdiagn: Check ICreateDevEnum_CreateClassEnumerator result for S_OK.
by Paul Gofman (＠gofman) 22 Dec '23

22 Dec '23

CreateClassEnumerator() can return S_FALSE and NULL moniker if the specified category is empty or doesn't exist (and devenum implementation can do that), build_directshowfilters_tree() will crash in that case. That's not new and AFAIU should not be normally hit as the category should not be empty, but I managed to hit that on some prefix (maybe with messed up direct show registration) and the change looks simple and sure enough probably (currently it will always crash if gets S_FALSE). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4733

2 1

[PATCH 0/1] MR4731: include: Fix boolean return value definition in IIterator<T> methods.
by Paul Gofman (＠gofman) 22 Dec '23

22 Dec '23

The practical effect of the change is that boolean is 1 byte while BOOL is 4 bytes, so we are wrongly filling more bytes in those methods and wrongly expect full 4 byte BOOL value to be filled from apps IIterator implemenation (and thus depend on uninitialized data in implementation). That fixes a hang on new game start in Phasmophobia (when it is configured to use windows.media.speech). That was originally attributed as a regression from commit 62173699c38453777c7d5638ed2e779790506b75 ("include: Don't align the stack for PE builds.") while before that commit it worked by chance only of course, the commit only changed stack data a bit so we were a bit more lucky in getting high bytes of BOOL as 0 in windows.media.speech/vector.c:vector_hstring_create_copy(). -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4731

5 4

[PATCH 0/1] MR4732: winedbg: Fix main module detection in 'info share' command.
by eric pouech (＠epo) 22 Dec '23

22 Dec '23

Signed-off-by: Eric Pouech <epouech(a)codeweavers.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4732

3 2

[PATCH v6 0/5] MR530: Draft: Add a few validation checks.
by Giovanni Mascellani (＠giomasce) 22 Dec '23

22 Dec '23

-- v6: https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/530

2 5

Re: [PATCH v2 0/1] MR4730: dbghelp/tests: Wait for child window to be up before testing. - approved
by Alexandre Julliard (＠julliard) 21 Dec '23

21 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4730

1 0

Re: [PATCH v4 0/2] MR4676: server: Only update the global cursor if the pointer is inside the thread's windows. - approved
by Alexandre Julliard (＠julliard) 21 Dec '23

21 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4676

1 0

Re: [PATCH v4 0/1] MR4726: server: Always release internal hardware messages - approved
by Alexandre Julliard (＠julliard) 21 Dec '23

21 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4726

1 0

Re: [PATCH v2 0/2] MR4729: dnsapi: Update the array ptr in the insufficient buffer case. - approved
by Alexandre Julliard (＠julliard) 21 Dec '23

21 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4729

1 0

Re: [PATCH v2 0/1] MR4728: winmm: Fill in pIOProc field in MMIOINFO. - approved
by Alexandre Julliard (＠julliard) 21 Dec '23

21 Dec '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4728

1 0

[PATCH v4 0/4] MR530: Draft: Add a few validation checks.
by Giovanni Mascellani (＠giomasce) 21 Dec '23

21 Dec '23

-- v4: vkd3d-shader/ir: Validate destination write masks depending on the dimension. vkd3d-shader/ir: Validate source swizzles depending on the dimension. vkd3d-shader/ir: Validate SSA registers. vkd3d-shader/dxil: Create constant buffer registers with dimension vec4. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/530

2 4

2025

2024

2023

2022

wine-gitlab December 2023