On Thu Dec 14 19:18:13 2023 +0000, Fabian Maurer wrote:
> You probably want to use a more descriptive commit message. Like, the MR
> title looks okay but the commit title not.
Thanks! Amended commit with more descriptive message.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/4694#note_56015
```
Datta: what have we given?
My friend, blood shaking my heart
The awful daring of a moment's surrender
Which an age of prudence can never retract
By this, and this only, we have existed
Which is not to be found in our obituaries
Or in memories draped by the beneficient spider
Or under seals broken by the lean solicitor
In our empty rooms
```
--
v3: vkd3d-shader: Allow compiling d3d bytecode to SPIR-V.
tests: Avoid using "SV_Position" as a name for the vertex shader input.
tests: Use struct vkd3d_shader_scan_signature_info to retrieve the VS input signature.
vkd3d-shader: Do not scan DCL instructions which do not declare resources.
vkd3d-shader: Do not scan the shader in vkd3d_shader_parser_compile() for assembly targets.
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/518
On Thu Dec 14 16:34:26 2023 +0000, Henri Verbeet wrote:
> > ```diff
> > -#if defined(SONAME_LIBDXCOMPILER) && !defined(VKD3D_CROSSTEST)
> > +#if defined(SONAME_LIBDXCOMPILER) || defined(VKD3D_CROSSTEST)
> > ```
> Should that just be "#if defined(SONAME_LIBDXCOMPILER)"? We could
> perhaps consider defining SONAME_LIBDXCOMPILER to "dxcompiler.dll" if it
> isn't already defined and we have VKD3D_CROSSTEST, but in principle I
> don't think VKD3D_CROSSTEST needs special handling here.
Defining `SONAME_LIBDXCOMPILER` when the dxcompiler library is not indeed available means that tests start failing. If no soname was specified or detected at configuration time, I don't think we should even try to use that library.
--
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/519#note_55995
```
Datta: what have we given?
My friend, blood shaking my heart
The awful daring of a moment's surrender
Which an age of prudence can never retract
By this, and this only, we have existed
Which is not to be found in our obituaries
Or in memories draped by the beneficient spider
Or under seals broken by the lean solicitor
In our empty rooms
```
--
v2: vkd3d-shader: Allow compiling d3d bytecode to SPIR-V.
tests: Avoid using "SV_Position" as a name for the vertex shader input.
tests: Use struct vkd3d_shader_scan_signature_info to retrieve the VS input signature.
vkd3d-shader: Do not scan DCL instructions which do not declare resources.
vkd3d-shader: Do not scan the shader in vkd3d_shader_parser_compile() for assembly targets.
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/518
Goes atop !489. The last 7 commits belong to this MR. Many of these patches are small, but the series can be split further if necessary.
--
v4: vkd3d-shader/spirv: Handle ITOI and UTOU in spirv_compiler_map_alu_instruction().
vkd3d-shader/spirv: Support UINT64 source in spirv_compiler_emit_bool_cast().
vkd3d-shader/spirv: Support 64-bit sources in spirv_compiler_emit_int_div().
vkd3d-shader/spirv: Introduce a UINT64 component type.
vkd3d-shader/spirv: Introduce a data_type_is_64_bit() helper function.
vkd3d-shader/spirv: Use data_type_is_integer() in spirv_compiler_emit_neg().
vkd3d: Pass int64 capability info to vkd3d-shader.
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/490