On Tue Dec 12 00:19:53 2023 +0000, Nikolay Sivov wrote:
> No, sorry for confusion. Uninitialized access issue seems to be about
> that one record. It is documented in EMF+ specification.
According to the spec a previous location of 0 is assumed. For me, this implies that the first element should not always be `0`, but be `0 + points[0]`
IMHO, EmfPlusRecordTypeDrawImagePoints look correct and this wrong.
A test could clear this up, but I'm not exactly sure on how to write one. Any tips?
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/4666#note_55782
On Tue Dec 12 00:02:25 2023 +0000, Fabian Maurer wrote:
> This MR is about playback for EmfPlusRecordTypeFillClosedCurve, or is
> there something else I missed?
> Regarding EmfPlusRecordTypeDrawImagePoints, is that 'P' flag documented
> somehwere? Because we don't seem to have a test for that either.
No, sorry for confusion. Uninitialized access issue seems to be about that one record. It is documented in EMF+ specification.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/4666#note_55775
On Tue Dec 12 00:02:25 2023 +0000, Nikolay Sivov wrote:
> Playback for EmfPlusRecordTypeFillClosedCurve has the same issue, and
> EmfPlusRecordTypeDrawImagePoints was already broken because it starts
> from first delta point instead of a zero origin.
This MR is about playback for EmfPlusRecordTypeFillClosedCurve, or is there something else I missed?
Regarding EmfPlusRecordTypeDrawImagePoints, is that 'P' flag documented somehwere? Because we don't seem to have a test for that either.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/4666#note_55774