December 2023 - wine-gitlab

[PATCH v10 0/4] MR450: vkd3d-shader/ir: Flatten structured control flow instructions.
by Conor McCarthy (＠cmccarthy) 07 Dec '23

07 Dec '23

-- v10: vkd3d-shader/ir: Store code block names in struct vkd3d_shader_desc. vkd3d-shader/ir: Flatten structured control flow instructions. vkd3d-shader: Rename shader_instruction_array_add_icb() to shader_instruction_array_add_opaque_param(). vkd3d-shader/spirv: Emit descriptor offset loads in the function entry block. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/450

3 5

[PATCH v4 0/1] MR4615: vbscript: For for loop coerce right bound string to real.
by Robert Wilhelm (＠sloper42) 07 Dec '23

07 Dec '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55052 -- v4: vbscript: For for loop bounds coerce string to real. https://gitlab.winehq.org/wine/wine/-/merge_requests/4615

3 3

[PATCH 0/1] MR4632: winecoreaudio: Use UID as device string.
by Brendan Shanks (＠bshanks) 07 Dec '23

07 Dec '23

`winecoreaudio` currently uses the `AudioDeviceID` as the device string (stored in the registry and used to correlate between Core Audio devices and generated GUIDs passed to Windows applications), but an `AudioDeviceID` may change between boots or even when a device is connected/disconnected. Use the UID instead, which is persistent across boots and connects/disconnects. These are strings like `BuiltInSpeakerDevice` or `AppleUSBAudioEngine:Apple Inc.:Studio Display:00008030-000128469718180E:6,7`. This only seems to be documented in the header files, from `AudioHardwareBase.h`: "`kAudioDevicePropertyDeviceUID`: A CFString that contains a persistent identifier for the AudioDevice. An AudioDevice's UID is persistent across boots. The content of the UID string is a black box and may contain information that is unique to a particular instance of an AudioDevice's hardware or unique to the CPU. Therefore they are not suitable for passing between CPUs or for identifying similar models of hardware." -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4632

3 2

[PATCH v2 0/3] MR4639: wineps: Pattern brush improvements
by Piotr Caban (＠piotr) 07 Dec '23

07 Dec '23

-- v2: wineps: Fix color handling in PSDRV_WriteDIBPatternDict. https://gitlab.winehq.org/wine/wine/-/merge_requests/4639

4 5

[PATCH v5 0/5] MR4593: winewayland.drv: part 11: Mouselook support
by Alexandros Frantzis (＠afrantzis) 07 Dec '23

07 Dec '23

This MR implements mouselook, which requires support for ClipCursor and relative motion events. The latter we can implement directly without using `SetCursorPos` for which no Wayland protocol exists at the moment. 1. Implement setting the foreground window, as this is required for clipping to work properly (i.e., for the ClipCursor driver callback to be called in the proper process/thread, see commit (2)). We can't unconditionally set the foreground window on keyboard focus, since compositors are eager to give the focus and some windows strongly dislike that (see https://gitlab.winehq.org/wine/wine/-/merge_requests/4102#note_51733). This MR borrows the "managed" window concept from WineX11 to detect windows that we shouldn't allow the compositor to manage, and avoids setting such windows as the foreground on keyboard focus. 2. Implement cursor clipping using the pointer-constraints protocol. 3. Switch to emitting relative motion events using the relative-pointer protocol when the cursor is not visible. --- 4. Finally, a potential fix for an issue I have been seeing where apps may transiently lose the active status (see commit message for more) as a result of the foreground state changes in this MR, which has undesirable side-effects. I have included this here for MR completeness/correctness, but it can be moved to a subsequent MR if preferred. Note: the velocity of relative motion events when scaling is involved is somewhat inconsistent among Wayland compositors. Thanks! -- v5: https://gitlab.winehq.org/wine/wine/-/merge_requests/4593

3 9

[PATCH v3 0/1] MR4615: vbscript: For for loop coerce right bound string to real.
by Robert Wilhelm (＠sloper42) 07 Dec '23

07 Dec '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=55052 -- v3: vbscript: For for loop bounds coerce string to real. https://gitlab.winehq.org/wine/wine/-/merge_requests/4615

3 3

[PATCH v8 0/2] MR3106: coml2: Move remaining storage functions from ole32
by Fabian Maurer (＠DarkShadow44) 07 Dec '23

07 Dec '23

-- v8: coml2: Move storage functions from ole32 coml2: Add tests for propertytovariant and varianttoproperty ordinals https://gitlab.winehq.org/wine/wine/-/merge_requests/3106

2 3

[PATCH 0/1] MR4631: msxml3: Handle default namespace in get_namespaceURI.
by Daniel Lehman (＠dlehman25) 07 Dec '23

07 Dec '23

https://bugs.winehq.org/show_bug.cgi?id=53531 last of 5 commits to remove the todos i added now i get the "OLE Error 80020006" from the bug this blocks: https://bugs.winehq.org/show_bug.cgi?id=38350 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/4631

3 2

[PATCH v4 0/2] MR4629: user32: Correct capitalization of SetDeskWallpaper.
by Alex Henrie (＠alexhenrie) 07 Dec '23

07 Dec '23

-- v4: user.exe: Rename SetDeskWallPaper to SetDeskWallpaper. user32: Correct capitalization of SetDeskWallpaper. https://gitlab.winehq.org/wine/wine/-/merge_requests/4629

2 2

[PATCH v4 0/6] MR4593: winewayland.drv: part 11: Mouselook support
by Alexandros Frantzis (＠afrantzis) 07 Dec '23

07 Dec '23

This MR implements mouselook, which requires support for ClipCursor and relative motion events. The latter we can implement directly without using `SetCursorPos` for which no Wayland protocol exists at the moment. 1. Implement setting the foreground window, as this is required for clipping to work properly (i.e., for the ClipCursor driver callback to be called in the proper process/thread, see commit (2)). We can't unconditionally set the foreground window on keyboard focus, since compositors are eager to give the focus and some windows strongly dislike that (see https://gitlab.winehq.org/wine/wine/-/merge_requests/4102#note_51733). This MR borrows the "managed" window concept from WineX11 to detect windows that we shouldn't allow the compositor to manage, and avoids setting such windows as the foreground on keyboard focus. 2. Implement cursor clipping using the pointer-constraints protocol. 3. Switch to emitting relative motion events using the relative-pointer protocol when the cursor is not visible. --- 4. Finally, a potential fix for an issue I have been seeing where apps may transiently lose the active status (see commit message for more) as a result of the foreground state changes in this MR, which has undesirable side-effects. I have included this here for MR completeness/correctness, but it can be moved to a subsequent MR if preferred. Note: the velocity of relative motion events when scaling is involved is somewhat inconsistent among Wayland compositors. Thanks! -- v4: win32u: Don't deactivate the target thread when setting the foreground window. winewayland.drv: Lock the pointer if confined without cursor. winewayland.drv: Implement relative mouse motion. winewayland.drv: Implement ClipCursor. https://gitlab.winehq.org/wine/wine/-/merge_requests/4593

3 10

2025

2024

2023

2022

wine-gitlab December 2023