Jacek Caban (@jacek) commented about dlls/winevulkan/make_vulkan:
> for e in self.struct_extensions:
> if not e.required:
> continue
> - conversions.extend(e.get_conversions(True, parent_const))
> + # FIXME: This should follow the caller unwrapping instead of always unwrapping to host handles
Let's leave the comment out. I'm not saying no, but let's not make it sound like it's decided.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/4602#note_55078
Jacek Caban (@jacek) commented about dlls/winevulkan/make_vulkan:
>
> return self.host_handle(name)
>
> - def is_wrapped(self):
> - return self.host_handle("test") is not None
> + def is_wrapped(self, unwrap):
`unwrap` argument seems redundant to me. Do you expect that there will be a case where driver handle will be wrapped, but not host handle (nor the other way around).
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/4602#note_55077
Goes atop !489. The last 8 commits belong to this MR. Many of these patches are small, but the series can be split further if necessary.
--
v2: vkd3d-shader/spirv: Handle ITOI and UTOU in spirv_compiler_map_alu_instruction().
vkd3d-shader/spirv: Support UINT64 source in spirv_compiler_emit_bool_cast().
vkd3d-shader/spirv: Support 64-bit sources in spirv_compiler_emit_int_div().
vkd3d-shader/spirv: Introduce a UINT64 component type.
vkd3d-shader/spirv: Introduce a data_type_is_64_bit() helper function.
vkd3d-shader/spirv: Use data_type_is_integer() in spirv_compiler_emit_neg().
vkd3d: Pass int64 capability info to vkd3d-shader.
vkd3d-shader/spirv: Introduce a compiler feature flag for int64 capability.
tests/shader-runner: Add 64-bit bitwise tests.
tests/shader-runner: Add 64-bit arithmetic tests.
tests/shader-runner: Introduce a 'shader int64' requirement directive.
vkd3d-shader/spirv: Emit an error if 64-bit integers are used.
vkd3d-shader/dxil: Introduce an instruction flag to suppress masking of bitwise shift counts.
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/490
Fixes: 62a979347a4dc1bd68f79b86397de85c016ec588
There are some debug traces before init_environment, and calling init_options before main_argv is set will try to dereference a NULL pointer.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/4603