Jacek Caban (@jacek) commented about dlls/winevulkan/make_vulkan:
> for e in self.struct_extensions:
> if not e.required:
> continue
> - conversions.extend(e.get_conversions(True, parent_const))
> + # FIXME: This should follow the caller unwrapping instead of always unwrapping to host handles
Let's leave the comment out. I'm not saying no, but let's not make it sound like it's decided.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/4602#note_55078
Jacek Caban (@jacek) commented about dlls/winevulkan/make_vulkan:
>
> return self.host_handle(name)
>
> - def is_wrapped(self):
> - return self.host_handle("test") is not None
> + def is_wrapped(self, unwrap):
`unwrap` argument seems redundant to me. Do you expect that there will be a case where driver handle will be wrapped, but not host handle (nor the other way around).
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/4602#note_55077