February 2023 - wine-gitlab

Re: [PATCH v2 0/1] MR107: vkd3d-shader/hlsl: Don't map src swizzles for SM1 dp3 and dp4 ops. - approved
by Alexandre Julliard (＠julliard) 27 Feb '23

27 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/107

1 0

Re: [PATCH v3 0/1] MR108: vkd3d-shader: Do not pass client-given strings as printf()-style format strings. - approved
by Alexandre Julliard (＠julliard) 27 Feb '23

27 Feb '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/108

1 0

[PATCH v7 0/1] MR2283: ntdll: Use IOPowerSources API to fill battery info on macOS
by Marc-Aurel Zent (＠marzent) 27 Feb '23

27 Feb '23

The current implementation based on `IOPMCopyBatteryInfo` does not work (macOS 13.2, M2 Max, returns `kIOReturnUnsupported`) and is not recommended/supported by Apple: > WARNING! IOPMCoyBatteryInfo is unsupported on ALL Intel CPU based systems. For PPC CPU based systems, it remains not recommended. For almost all purposes, developers should use the richer IOPowerSources API (with change notifications) instead of using IOPMCopyBatteryInfo. Keys to decipher IOPMCopyBatteryInfo's return CFArray exist in IOPM.h. -- v7: ntdll: Use IOPowerSources API to fill battery info on macOS https://gitlab.winehq.org/wine/wine/-/merge_requests/2283

3 5

Re: [PATCH v2 0/1] MR2295: msado15: Free recordset filter on close. - approved
by Alistair Leslie-Hughes (＠alesliehughes) 27 Feb '23

27 Feb '23

This merge request was approved by Alistair Leslie-Hughes. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2295

1 0

[PATCH v3 0/6] MR2269: uiautomationcore: Test fixes and more COM helper methods.
by Connor McAdams (＠cmcadams) 27 Feb '23

27 Feb '23

-- v3: uiautomationcore: Implement IUIAutomation::CheckNotSupported. uiautomationcore: Implement IUIAutomation reserved value retrieval methods. uiautomationcore: Implement IUIAutomation::IntNativeArrayToSafeArray. https://gitlab.winehq.org/wine/wine/-/merge_requests/2269

3 9

[PATCH 0/1] MR2294: mscoree/tests: Trace the GetExitCodeProcess() error before it gets lost.
by Francois Gouget (＠fgouget) 27 Feb '23

27 Feb '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2294

3 2

[PATCH 0/1] MR107: vkd3d-shader/hlsl: Don't map src swizzles for SM1 dp3 and dp4 ops.
by Francisco Casas (＠fcasas) 27 Feb '23

27 Feb '23

Without this patch, dp3 and dp4 map src swizzles to the dst writemask, which is not correct. Before b84f560bdf59c35e093e51bfdf9a166c196d3a9b, these ops worked despite this, because the dst register had, incorrectly, the full writemask. To solve this problem, `write_sm1_binary_op_dot()` is introduced, similarly to `write_sm4_binary_op_dot()`. This was pointed out by @nsivov in https://bugs.winehq.org/show_bug.cgi?id=54522. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/107

5 6

[PATCH v3 0/1] MR2297: winex11: Assume that Xkb extension is available.
by Rémi Bernon (＠rbernon) 27 Feb '23

27 Feb '23

The extension is now part of Xlib. It might be disabled through the `XKB_DISABLE=1` environment variable (https://gitlab.freedesktop.org/xorg/lib/libx11/-/blob/master/src/xkb/XKBUse…) but I don't see why we have to support that case. I think assuming that it is always usable will make the keyboard code simpler, though I have no idea if it exists some environment without it nowadays. All recent desktop environment rely on Xkb to support keyboard layouts, especially when multiple layouts are configured (which are grouped four by four in a single X keyboard mapping, using Xkb groups). -- v3: winex11: Assume that Xkb extension is available. https://gitlab.winehq.org/wine/wine/-/merge_requests/2297

2 2

[PATCH 0/10] MR2275: winewayland.drv: part 1: Introduce the Wayland driver
by Alexandros Frantzis (＠afrantzis) 27 Feb '23

27 Feb '23

Introduction ------------ This is the first of (many) parts in the upstreaming of the Wayland driver for Wine. Since the amount of code and commits is large, my approach is to upstream the driver in multiple parts in a serial fashion, with each part being a cohesive (to the degree possible) set of not too many commits. When each part is reviewed and merged, I will move on to proposing the next part. My main goal with this approach is to make reviewing easier and more focused. If you have other ideas about how to improve this process for the reviewers, please let me know. A lot of pieces need to fall into place before the driver becomes even remotely functional, so, some MRs (especially the initial ones) will be a bit more preparatory in nature. To aid in the understanding of and justification for some of the code introduced in such MRs, all the remaining driver commits are always going to be available at https://gitlab.winehq.org/afrantzis/wine/-/tree/wayland. Part 1 ------- This MR introduces the Wayland driver PE and unixlib components with some basic code, and prepares the makedep tool to be able to handle Wayland protocol files. Please see the individual commit message for more details. Some questions I would appreciate some feedback on in the context of this MR: 1. Should the Wayland driver build be enabled by default at this point? (currently it's explicitly opt-in with --with-wayland) 2. How should the Wayland driver build be integrated with CI? (currently piggybacking on gitlab/build-linux by adding --with-wayland) Note that building the Wayland driver should not affect running/testing on X11/Xwayland etc, since it's placed lower in the driver priority list. Part 2 preview: We will handle basic Wayland wl_output (i.e., display) events and populate the Wine monitor information. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2275

7 21

[PATCH v2 0/1] MR110: vkd3d-shader: Make documentation for "messages" parameters self contained.
by Giovanni Mascellani (＠giomasce) 27 Feb '23

27 Feb '23

Otherwise it's not clear which clauses in vkd3d_shader_compile() really apply to other functions. For example, many of the functions currently refering to vkd3d_shader_compile() don't even take a vkd3d_shader_compile_info parameter. -- v2: vkd3d-shader: Make documentation for "messages" parameters self contained. https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/110

2 1

2025

2024

2023

2022

wine-gitlab February 2023