> Only if you accept that it overflows above the install button, I'm not sure that's better.
You're right, it does overflow with some of the translations.
This seems like the safest way to add it:
![Screenshot_20230323_190837](/uploads/65da20f990348341c9331a98709a37db/Screenshot_20230323_190837.png)
I checked the longest `Install theme` translation, which is Lithuanian, and it doesn't overflow:
![Screenshot_20230323_190610](/uploads/c0af96e1db89d0b9082a77fb778bfad4/Screenshot_20230323_190610.png)
Alternatively, the `Color` combo box could be moved to the first row like so:
![Screenshot_20230323_193447](/uploads/8e75a18414ba4f1f29b81bc9a2a4e7f7/Screenshot_20230323_193447.png)
Which of these would be most preferable? I'm leaning towards the second one.
--
https://gitlab.winehq.org/wine/wine/-/merge_requests/2183#note_27712
This node type is intended for use during parse-time.
While we parse an indexing expression such as `a[3]`, we don't know if
it will end up as part of an expression (in which case it must be folded
into a load) or it is for the lhs of a store (in which case it must be
folded into the store's deref). This node type is used to represent these accesses and no longer rely on building an `hlsl_ir_load` for each array index or struct record access.
`hlsl_ir_index` chains are lowered into derefs when (and if) they are used to specify the lhs of an assignment. All `hlsl_ir_index`es are lowered into `hlsl_ir_load`s with a compilation pass.
The changes introduced in these series allow to solve the problem with the return variable of function calls presented in !93, and to properly support assignment to matrix indexes, which is something we are not doing correctly.
Further patches (in my [index node](https://gitlab.winehq.org/fcasas/vkd3d/-/commits/index_node) branch) add support for indexing non-load expressions, such as `(a + b)[1]` and allowing to represent resource loads through `hlsl_ir_index`, so that `hlsl_ir_resource_store`s don't have to rely on `hlsl_ir_resource_load`s.
--
v3: vkd3d-shader/hlsl: Copy index chain values into synthetic vars.
tests: Test indexing of non-loads.
vkd3d-shader/hlsl: Support column-major matrix indexing in the lhs.
vkd3d-shader/hlsl: Always load from a synthetic copy in add_load_component().
vkd3d-shader/hlsl: Remove add_load_index().
vkd3d-shader/hlsl: Use hlsl_ir_index for array and record access.
vkd3d-shader/hlsl: Introduce hlsl_ir_index.
tests: Test side effects on indexes.
https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/124
--
v8: winegstreamer: Implement ProcessInput and ProcessOutput for WMV decoder DMO.
winegstreamer: Create wg_transform for WMV decoder.
winegstreamer: Ignore framerate of media type for WMV decoder DMO.
winegstreamer: Add format field to wmv wg_format.
mf/tests: Test time length returned by ProcessOutput.
https://gitlab.winehq.org/wine/wine/-/merge_requests/2258