March 2023 - wine-gitlab

[PATCH v2 0/1] MR2481: wldap32: Handle null DN or null message in ldap_delete* and add tests.
by Alex Henrie (＠alexhenrie) 23 Mar '23

23 Mar '23

On Windows, ldap_delete_(ext_)s returns LDAP_UNWILLING_TO_PERFORM when trying to delete an entry that cannot be deleted. On Unix, LDAP_SERVER_DOWN is returned instead. Unix also returns LDAP_SERVER_DOWN immediately from ldap_delete_ext if the entry cannot be deleted, whereas Windows queues an asynchronous operation and returns LDAP_SUCCESS. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54702 -- v2: wldap32: Handle null DN or null message in ldap_delete* and add tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/2481

3 5

[PATCH v2 0/6] MR2456: widl: Improve error messages source location.
by Rémi Bernon (＠rbernon) 23 Mar '23

23 Mar '23

-- v2: widl: Print the import stack and context in messages. widl: Improve accuracy of error messages location. widl: Enable bison locations option. widl: Move diagnostic and location functions to parser.l. widl: Allow source location to span over multiple lines. widl: Rename (error|warning)_loc_info to (error|warning)_at. https://gitlab.winehq.org/wine/wine/-/merge_requests/2456

3 8

[PATCH v2 0/5] MR2483: kernelbase: Add full support for shared Software\Classes keys.
by Sven Baars (＠sbaars) 23 Mar '23

23 Mar '23

I initially wanted to do the refactoring in a separate merge request, but since my merge request yesterday broke the tests, I decided to add the implementation into this commit as well. -- v2: kernelbase: Recursively obtain the Wow6432Node parent. kernelbase: Add support for shared registry keys. https://gitlab.winehq.org/wine/wine/-/merge_requests/2483

3 6

[PATCH v3 0/5] MR2483: kernelbase: Add full support for shared Software\Classes keys.
by Sven Baars (＠sbaars) 23 Mar '23

23 Mar '23

I initially wanted to do the refactoring in a separate merge request, but since my merge request yesterday broke the tests, I decided to add the implementation into this commit as well. -- v3: kernelbase: Recursively obtain the Wow6432Node parent. kernelbase: Add support for shared registry keys. https://gitlab.winehq.org/wine/wine/-/merge_requests/2483

2 6

[PATCH v2 0/11] MR2484: wineps: Initial work on writing ps data in print processor
by Piotr Caban (＠piotr) 23 Mar '23

23 Mar '23

-- v2: wineps: Handle EMR_LINETO record in spool files. wineps: Handle EMR_MOVETOEX record in spool files. wineps: Handle EMR_RECTANGLE record in spool files. wineps: Handle pen selection in spool files. wineps: Handle brush selection in spool files. wineps: Handle EMR_EOF record in spool files. wineps: Handle EMR_HEADER record in spool files. wineps: Write document header and footer in PrintDocumentOnPrintProcessor. https://gitlab.winehq.org/wine/wine/-/merge_requests/2484

3 13

[PATCH 0/11] MR2484: wineps: Initial work on writing ps data in print processor
by Piotr Caban (＠piotr) 23 Mar '23

23 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2484

2 12

[PATCH v4 0/3] MR1895: Fixes for NtOpenFile of read-only files with FILE_WRITE_ATTRIBUTES
by Joel Holdsworth (＠jhol) 23 Mar '23

23 Mar '23

Previously, the Wine implementation of `NtOpenFile` would fail to open read-only files for `FILE_WRITE_ATTRIBUTES` access in wine-server, because it would attempt to open the file with `O_RDWR` or `O_WRONLY` access. This patch-set adds test cases to highlight the issue, and solves it by only opening the file with write access where necessary. * Wine Bug: [#50771](https://bugs.winehq.org/show_bug.cgi?id=50771) * Related Wine-Staging Patches: * [0002-server-Allow-to-open-files-without-any-permission-bi.patch](https://gi… * [0006-ntdll-tests-Added-tests-for-open-behaviour-on-readon.patch](https://gi… * [0007-server-FILE_WRITE_ATTRIBUTES-should-succeed-for-read.patch](https://gi… -- v4: server: Allow to open read-only files with FILE_WRITE_ATTRIBUTES server: Open code FILE_UNIX_{READ,WRITE}_ACCESS ntdll/tests: Added tests for attributes access on read-only files. https://gitlab.winehq.org/wine/wine/-/merge_requests/1895

2 3

Re: [PATCH v10 0/1] MR2183: winecfg: Add an option to set WinRT app dark theme.
by Alexandre Julliard (＠julliard) 23 Mar '23

23 Mar '23

> How's this? > > Thanks for the review! :smiley: Actually thinking some more about this, a simple check mark may be better than a drop-down. It's not like there would be other possible options. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2183#note_27620

1 0

[PATCH 0/3] MR2483: kernelbase: Refactor create_key() in the same way as open_key().
by Sven Baars (＠sbaars) 23 Mar '23

23 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2483

2 3

[PATCH v2 0/5] MR2452: imm32: Implement ImmEnumInputContext.
by Rémi Bernon (＠rbernon) 23 Mar '23

23 Mar '23

-- v2: imm32: Rename InputContextData to struct imc. imm32: Use NtUserQueryInputContext to check cross-thread access. imm32: Remove unused IMM_IsCrossThreadAccess hwnd parameter. imm32: Remove unnecessary threadDefault InputContextData member. imm32: Implement ImmEnumInputContext. https://gitlab.winehq.org/wine/wine/-/merge_requests/2452

2 6

2025

2024

2023

2022

wine-gitlab March 2023