March 2023 - wine-gitlab

[PATCH v2 0/4] MR585: Improve is_gecko_path() for handling non-ASCII characters.
by Jactry Zeng (＠jactry) 08 Jul '23

08 Jul '23

This fixes an issue when the path includes non-ASCII characters. Signed-off-by: Jactry Zeng <jzeng(a)codeweavers.com> -- v2: mshtml: Call UrlUnescapeW() with URL_UNESCAPE_AS_UTF8 in is_gecko_path(). shlwapi/tests: Test UrlUnescapeW() with URL_UNESCAPE_AS_UTF8. kernelbase: Implement URL_UNESCAPE_AS_UTF8 for UrlUnescapeW(). shlwapi/tests: Test UrlUnescapeW() with independent data. https://gitlab.winehq.org/wine/wine/-/merge_requests/585

4 6

[PATCH 0/1] MR2228: bcryptprimitives: ProcessRng stub
by Christopher Denton (＠cdenton) 04 Jul '23

04 Jul '23

`ProcessRng` is the only publicly documented function exported by `bcryptprimitives`. This stub simply forwards it to `RtlGenRandom` in `advapi32`. Documentation: https://learn.microsoft.com/en-us/windows/win32/seccng/processprng -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2228

4 11

[PATCH 0/1] MR1045: include: Add wine/winrt.h and define IInspectable helpers there.
by Paul Gofman (＠gofman) 23 Jun '23

23 Jun '23

And use that instead of duplicating those helpers across the tree. Besides removing existing duplicates, I am planning to add yet another WinRT dll (gamepad) and we will likely add more in the future, each of those can use that, as well as potentially more common helpers. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1045

5 6

[PATCH 0/1] MR2507: vbscript: Add additional types for stack_pop_bool.
by Jason Millard (＠jsm174) 21 Jun '23

21 Jun '23

I have found some scripts where comparisons that use floats and OLECOLOR directly fail. For example: ``` If Light005.State Then ' State is a float V_R4 End If If Light005.Colorfull Then ' Colorfull is an OLECOLOR VT_UI4 End If ``` This is because `stack_pop_bool` does not handle `VT_R4` and `VT_UI4` and returns `E_NOTIMPL`. This adds additional types to `stack_pop_bool` similar to `VARIANT_Coerce`. Fixes https://bugs.winehq.org/show_bug.cgi?id=54731 -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2507

4 7

[PATCH 0/1] MR1305: ntdll: The maximum length for a path is MAX_PATH.
by Jiajin Cui (＠jin-king1) 21 Jun '23

21 Jun '23

see "https://learn.microsoft.com/en-us/windows/win32/fileio/maximum-file-path-li…". Signed-off-by: Jiajin Cui <cuijiajin(a)uniontech.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1305

3 3

[PATCH 0/1] MR1306: win32u: When the window is not visible but has WS_VISIBLE flag, we should update the vis rgn.
by Jiajin Cui (＠jin-king1) 21 Jun '23

21 Jun '23

When the child window and the parent window are no longer in the same process, the parent window shadow does not update the vis rgn of the child window and modify the WS_VISIBLE style of the child window. so we need to update the vis rgn when another process gets the DC of the child window. Signed-off-by: Jiajin Cui <cuijiajin(a)uniontech.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/1306

2 2

[PATCH v4 0/4] MR1710: mf: Discard end of presentation on IMFMediaSession_Stop.
by Rémi Bernon (＠rbernon) 20 Jun '23

20 Jun '23

MR !607 was trying to fix an issue with Life Is Strange Remastered, but although it fixed some race conditions with presentation end, the issue it was trying to fix is still there. The game calls IMFMediaSession_Stop while the presentation is ending, expects that command to quickly execute, interrupting the presentation end and emitting a MESessionStopped event instead of the MESessionEnded. Delaying the Stop command and emitting the MESessionEnded event breaks the game assumptions and it crashes. -- v4: mf: Discard end of presentation on IMFMediaSession_Stop. mf/tests: Test IMFMediaSession_Stop command near presentation end. mf/tests: Test Start / Pause / Stop IMFMEdiaSession events. mf/tests: Split wait_media_event helper into wait_next_media_event. https://gitlab.winehq.org/wine/wine/-/merge_requests/1710

3 10

[PATCH v2 0/1] MR2348: comdlg32: Add parent dir button to "Item" file dialog.
by Florian Will (＠w-flo) 17 Jun '23

17 Jun '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=29912 Now it looks like this (this patch adds the separator & "up" button): ![Bildschirmfoto_vom_2023-03-08_13-34-36](/uploads/cd30de5b3fa5f39accb4dd14a3f54421/Bildschirmfoto_vom_2023-03-08_13-34-36.png) -- v2: comdlg32: Add parent dir button to "Item" file dialog. https://gitlab.winehq.org/wine/wine/-/merge_requests/2348

2 5

[PATCH v5 0/3] MR1259: gitlab: Run some tests with nulldrv driver.
by Rémi Bernon (＠rbernon) 08 Jun '23

08 Jun '23

Allowing the job to fail to avoid failing the pipeline. Some new tests are failing with it, and some are succeeding todo_wine. -- v5: gitlab: Run user32 32-bit tests with nulldrv driver. user32/tests: Update todos specific to the X11 display driver. user32/tests: Check graphics driver and add todos for nulldrv. https://gitlab.winehq.org/wine/wine/-/merge_requests/1259

2 5

[PATCH v13 0/12] MR1857: Draft: comdlg32: IFileDialog navigation bar
by Vladislav Timonin (＠vt) 06 Jun '23

06 Jun '23

Implements navigation bar featuring: - back/forward buttons - go up button - address crumbs - hides crumbs when there's not enough space to display all of them - always shows at least 2 crumbs - truncating them if needed - first crumb is at least 56px - aligns label to the left if truncated - right clicking on the crumb, or free space, opens a menu with `Copy address as text` and `Edit address` options - reuses existing crumbs to avoid some flickering - overflow menu - ~~first crumb is always moved here~~ - removes the split, if there are no items in the menu - hidden crumbs are moved here - left ~~or right~~ click on the button starts address editing - address edit - accepts an existing path - expands environment variables, e.g. `%APPDATA%\Microsoft` -> `C:\users\%USERNAME%\AppData\Roaming\Microsoft` - errors with a `MessageBox` on nonexistent paths - refresh button - changes into go to button when editing address - DPI scaling Screenshots: ![navbar-crumbs-classic](/uploads/8c9a806b57f8e456fcbfd3cbc1ef3bb7/navbar-crumbs-classic.png) ![navbar-crumbs-light](/uploads/9c8a7acf9b55ae5ac182219edd45b65d/navbar-crumbs-light.png) ![navbar-edit-classic](/uploads/f68309bbc9200a8d8d4e3cd692179409/navbar-edit-classic.png) ![navbar-edit-light](/uploads/6798e79e6d2498a052b0ecbc2545c6e4/navbar-edit-light.png) ![navbar-120dpi-classic](/uploads/72abee382ab6171ff9c1b99a9065c845/navbar-120dpi-classic.png) ![navbar-120dpi-light](/uploads/538a030bc2028f8654d6c35d6f2825dd/navbar-120dpi-light.png) Remaining issues: - crumbs not lighting up when hovered sometimes - can be observed in current file dialog, hovering over dropdown arrow of a file type fixes it for a moment - crumbs flickering on address change sometimes - mostly when there's not enough space to display all of them - `DeferWindowPos` doesn't seem to be atomic in Wine, presumably is in native Windows? - unexpected address conversion for some PIDLs - e.g. `Desktop` -> `C:\users\%USERNAME%\Desktop`, which is an entirely different location - or `My Computer` into an empty string - known folders are not handled by address edit, e.g. `Desktop`, `My Computer` - icons are not DPI scaled - while writing this: ``` 0024:fixme:bitmap:NtGdiCreateBitmap planes = 0 0024:err:system:user_check_not_lock BUG: holding USER lock wine/dlls/win32u/sysparams.c:396: user_check_not_lock: Assertion `0' failed. wine: Assertion failed at address F7FF8549 (thread 0024), starting debugger... ``` - can't reproduce, happened when clicking on an item in overflow menu - race condition? cosmic ray? Addresses following bugs: - https://bugs.winehq.org/show_bug.cgi?id=29912 - https://bugs.winehq.org/show_bug.cgi?id=50338 - https://bugs.winehq.org/show_bug.cgi?id=51855 (partially? no search box) -- v13: comdlg32: Add Ctrl+Backspace delete word to IFileDialog address edit. comdlg32: Use path word break in IFileDialog address edit. comctl32: Fix PathWordBreakProc. comdlg32: Keep IExplorerBrowser in IFileDialog focused after Backspace. fixup: comdlg32: Add address edit to IFileDialog navigation bar. comdlg32: Add refresh/go to button to IFileDialog navigation bar. comdlg32: Add address edit to IFileDialog navigation bar. comdlg32: Add breadcrumb overflow menu to IFileDialog navigation bar. comdlg32: Add address breadcrumbs to IFileDialog navigation bar. comdlg32: Add go up button to IFileDialog navigation bar. comdlg32: Add IFileDialog navigation bar. comdlg32: Enable visual styles when showing IFileDialog. https://gitlab.winehq.org/wine/wine/-/merge_requests/1857

6 22

2025

2024

2023

2022

wine-gitlab March 2023