March 2023 - wine-gitlab

[PATCH v5 0/1] MR2346: winsqlite3: Add stub DLL.
by Tareque Md Hanif (＠tmdh) 18 May '23

18 May '23

Required to run winget package manager. -- v5: winsqlite3: Add stub DLL. https://gitlab.winehq.org/wine/wine/-/merge_requests/2346

3 4

[PATCH 0/4] MR2002: Draft: RFC: Extend winetest with multi-arch capabilities.
by eric pouech (＠epo) 12 May '23

12 May '23

Rationale: - currently, winetest is built either as a 32bit exec or a 64bit exec, containaing a bunch of tests of same bitness. - there's no simple support for having parent process in one bitness, and child process in a different bitness. - lots of cases are not covered in ntdll, kernel32 and kernelbase tests. - there are here and there a couple of tweaks to workaround this, but nothing a bit solid. Attached is a proposal to extend winetest to support better these use cases: - the idea is to add an extra-option to winetest.exe (64bit) passing the path to the corresponding winetest.exe (32bit). - when running test X (64bit), the path to corresponding test X (32bit) will be passed to test X (64 bit), allowing it to trigger test with test X (32bit). - nothing more is provided: it's up to the test designer to decide whether to use the 32bit child (and to adapt potentially the test) to cope with the difference in bitness between parent and child. - this can be used either in current wow64 setup, and also in multi-arch wow64 setup (just need to change the patch to 32bit winetest.exe) There's an example of such test at the end of the serie. Comments, ideas welcomed. And especially if it's something worth continuing. Note: - this is first shot at it, it should be improved (especially in ensuring that the 32bit/64bit pair is correct). A+ -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2002

2 5

[PATCH 0/3] MR2497: Modules list handling in dbghelp.
by eric pouech (＠epo) 12 May '23

12 May '23

The aim of this series is to re-implement dbghelp.EnumerateLoadedModules* in order to match Windows' behavior (especially in wow64 environments). The serie includes: - a bunch of tests to compare 3 different sets of loaded modules: + the load DLL debug events (generated by kernel) + the output of dbghelp.EnumerateLoadedModules(), which is a wrapper around kernel32.EnumProcesModulesEx (yet modifying some information) + the actual list of loaded modules in dbghelp (SymEnumerateModules). => the later list can be populated automatically from the second if requested to dbghelp (this is what is tested). => for the record, winedbg uses the first set to populate the third set. We just test the content of first set, not the population to the third. - the reimplementation of EnumerateLoadedModules to match Window's behavior (especially regarding paths information) Despite the three sets look similar, they have quite a few differences to be taken care of (especially in wow64 setup). Note: having the correct paths (esp. in wow64) is important as dbghelp sometimes tries some wild guesses based on the path (like bitness <g>) or (in some other places) don't rely on path information and retries things on its own. The long target is to simplify the module lookup by relying on more solid information. @julliard: the paths for wow64 modules returned from kernel32 don't match windows behavior: wine returns 32bit system modules from c:\windows\syswow64 whereas windows returns them from c:\windows\system32 (except a couple of exceptions: 32bit ntdll and exe main module). Implementation in dbghelp includes the correction of this. (I opted not to change ntdll at once: testing on windows show that kernel32.EnumProcesModulesEx returns exactly the ldr_data list, and I didn't feel like adding this burden to this patch ;-). Let me know if you want ntdll to be fixed before this patch. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2497

3 7

[PATCH 0/1] MR2230: webservices: Avoid uninitialized variable warning in format_double
by Gerald Pfeifer (＠gerald) 09 May '23

09 May '23

GCC 13 was going to diagnose dlls/webservices/writer.c:960:18: warning: 'mag2' may be used uninitialized -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2230

3 6

[PATCH 0/1] MR2241: makedep: Better differentiate between compiling and linking commands.
by Bernhard Kölbl (＠besentv) 06 May '23

06 May '23

This makes one able to see what is being built as PE and UNIX code and shows 'LINK' for linking in silent configuration `--enable-silent-rules`. For example: ``` make: Entering directory '/home/bernhard/Documents/programming/builds/wine/x64' UNIX dlls/windows.media.speech/unixlib.o PE dlls/windows.media.speech/x86_64-windows/async.o PE dlls/windows.media.speech/x86_64-windows/main.o PE dlls/windows.media.speech/x86_64-windows/recognizer.o PE dlls/windows.media.speech/x86_64-windows/event_handlers.o PE dlls/windows.media.speech/x86_64-windows/listconstraint.o PE dlls/windows.media.speech/x86_64-windows/synthesizer.o PE dlls/windows.media.speech/x86_64-windows/vector.o WIDL dlls/windows.media.speech/x86_64-windows/classes_r.res LINK dlls/windows.media.speech/x86_64-windows/windows.media.speech.dll LINK dlls/windows.media.speech/windows.media.speech.so Wine build complete. ``` -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2241

3 3

[PATCH 0/1] MR2330: xmllite/writer: implement prefix autogeneration
by David Kahurani (＠kahurani) 29 Apr '23

29 Apr '23

Looks good to me but would love some opinion(s) Signed-off-by: David Kahurani <k.kahurani(a)gmail.com> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2330

3 7

[PATCH 0/1] MR2205: winspool: Fix crash when dmSize is 0
by Tingzhong Luo (＠tzluo) 26 Apr '23

26 Apr '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2205

4 5

[PATCH 0/1] MR71: Draft: vkd3d: Update Vulkan descriptors only when submitted to a command queue.
by Conor McCarthy (＠cmccarthy) 26 Apr '23

26 Apr '23

Unpolished. Raises framerate by around 15% in SotTR because vk_sets_mutex is locked only once for each descriptor heap. It's possible to collate multiple writes for a single vkUpdateDescriptorSets() call as was done in the optimised copying path, but it may not be worth it. A possible complication with this: if it becomes possible to remove the descriptor mutexes after the remaining problems with queue sequencing are fixed, we theoretically may still need them for this. Descriptors should not be updated while binding, but there's no reason more can't be written in another thread while a command list is submitted to a queue. -- https://gitlab.winehq.org/wine/vkd3d/-/merge_requests/71

2 2

[PATCH v3 0/1] MR1853: mf: Request more samples for MFT when needed.
by Shaun Ren (＠shaunren) 20 Apr '23

20 Apr '23

When an upstream node has not given enough samples to the transform, we need to request more samples from it to avoid stalling the pipeline. This fixes an issue where the intro audio of the game Airborne Kingdom stops playing after a few seconds. -- v3: mf: Request more samples for transforms when needed. https://gitlab.winehq.org/wine/wine/-/merge_requests/1853

2 3

[PATCH v2 0/3] MR2350: Recognize Intel UHD 630 coffelake GT2
by Carlos Rodriguez (＠mrdeathjr28) 17 Apr '23

17 Apr '23

Recognize Intel UHD 630 coffelake GT2 -- v2: Recognize Intel UHD 630 coffelake GT2 https://gitlab.winehq.org/wine/wine/-/merge_requests/2350

3 5

2025

2024

2023

2022

wine-gitlab March 2023