March 2023 - wine-gitlab

Re: [PATCH v2 0/1] MR2403: crypt32: Add some CertGetNameStringW fallback cases
by Hans Leidekker (＠hans) 15 Mar '23

15 Mar '23

Hans Leidekker (@hans) commented about dlls/crypt32/str.c: > - oid = szOID_RSA_emailAddr; > - nameAttr = CertFindRDNAttr(oid, nameInfo); > + if (oid) > + nameAttr = CertFindRDNAttr(oid, nameInfo); > + else > + { > + static const LPCSTR attributeOIDs[] = > + { > + szOID_RSA_emailAddr, szOID_COMMON_NAME, > + szOID_ORGANIZATIONAL_UNIT_NAME, szOID_ORGANIZATION_NAME > + }; > + DWORD i; > + > + for (i = 0; !nameAttr && i < ARRAY_SIZE(attributeOIDs); i++) > + nameAttr = CertFindRDNAttr(attributeOIDs[i], nameInfo); > + } Thanks for the patch. Could you add a test to crypt32/tests/str.c? At least one fallback case would be good to have. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2403#note_26961

1 0

[PATCH 0/1] MR2363: Update dlls/ntdll/wcstring.c
by li wenzhe (＠chrisli) 15 Mar '23

15 Mar '23

LPWSTR __cdecl wcsncpy( LPWSTR s1, LPCWSTR s2, size_t n ) { WCHAR *ret = s1; **//When encountering 0, the loop will jump out directly, but the pointer of s1 has been++, which leads to the memory overflow of the second for** for ( ; n; n--) if (!(*s1++ = *s2++)) break; for ( ; n; n--) *s1++ = 0; return ret; } -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2363

3 4

[PATCH v3 0/1] MR2367: comctl32/treeview: Ignore the lParam to WM_PRINTCLIENT and add tests.
by Alex Henrie (＠alexhenrie) 15 Mar '23

15 Mar '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54640 -- v3: comctl32/treeview: Ignore the lParam to WM_PRINTCLIENT and add tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/2367

3 2

[PATCH 0/3] MR2406: win32u: Give full access rights to the process window station.
by Zhiyi Zhang (＠zhiyi) 15 Mar '23

15 Mar '23

Fix CEF applications crash at start without --no-sandbox option. Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=53981 Signed-off-by: Dmitry Timoshkov <dmitry(a)baikal.ru> -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2406

3 4

[PATCH v11 0/6] MR2275: winewayland.drv: part 1: Introduce the Wayland driver
by Alexandros Frantzis (＠afrantzis) 15 Mar '23

15 Mar '23

Introduction ------------ This is the first of (many) parts in the upstreaming of the Wayland driver for Wine. Since the amount of code and commits is large, my approach is to upstream the driver in multiple parts in a serial fashion, with each part being a cohesive (to the degree possible) set of not too many commits. When each part is reviewed and merged, I will move on to proposing the next part. My main goal with this approach is to make reviewing easier and more focused. If you have other ideas about how to improve this process for the reviewers, please let me know. A lot of pieces need to fall into place before the driver becomes even remotely functional, so, some MRs (especially the initial ones) will be a bit more preparatory in nature. To aid in the understanding of and justification for some of the code introduced in such MRs, all the remaining driver commits are always going to be available at https://gitlab.winehq.org/afrantzis/wine/-/tree/wayland. Part 1 ------- ~~This MR introduces the Wayland driver PE and unixlib components with some basic code, and prepares the makedep tool to be able to handle Wayland protocol files.~~ This MR introduces the Wayland driver PE and unixlib components with some basic code, and reports some basic monitor information to Wine. Please see the individual commit message for more details. Some questions I would appreciate some feedback on in the context of this MR: 1. Should the Wayland driver build be enabled by default at this point? (currently it's explicitly opt-in with --with-wayland) 2. How should the Wayland driver build be integrated with CI? (currently piggybacking on gitlab/build-linux by adding --with-wayland) Note that building the Wayland driver should not affect running/testing on X11/Xwayland etc, since it's placed lower in the driver priority list. ~~Part 2 preview: We will handle basic Wayland wl_output (i.e., display) events and populate the Wine monitor information.~~ Part 2 preview: We will report more monitor information and implement GetCurrentDisplaySettings. -- v11: winewayland.drv: Report all advertised monitor modes to Wine. winewayland.drv: Report basic monitor information. https://gitlab.winehq.org/wine/wine/-/merge_requests/2275

3 7

[PATCH 0/1] MR2403: crypt32: Add some CertGetNameStringW fallback cases
by Tyson Whitehead (＠twhitehead) 14 Mar '23

14 Mar '23

When called with CERT_NAME_ATTR_TYPE and pvTypePara=NULL, Windows did the first of email, CN, OU, or O while Wine just did email. This closes https://bugs.winehq.org/show_bug.cgi?id=54687. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2403

2 1

Re: [PATCH v2 0/1] MR2398: d3dcompiler: Handle some newer D3D_BLOB_PART values in debug_d3dcompiler_d3d_blob_part(). - approved
by Alexandre Julliard (＠julliard) 14 Mar '23

14 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2398

1 0

Re: [PATCH v2 0/5] MR2396: widl: Use bison-bridge and noyywrap options, clean up a few things. - approved
by Alexandre Julliard (＠julliard) 14 Mar '23

14 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2396

1 0

Re: [PATCH v3 0/1] MR2379: windows.networking: Stub DllGetActivationFactory(). - approved
by Alexandre Julliard (＠julliard) 14 Mar '23

14 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2379

1 0

Re: [PATCH v3 0/1] MR2375: wofutil: Stub WofIsExternalFile(). - approved
by Alexandre Julliard (＠julliard) 14 Mar '23

14 Mar '23

This merge request was approved by Alexandre Julliard. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2375

1 0

2025

2024

2023

2022

wine-gitlab March 2023