March 2023 - wine-gitlab

[PATCH 0/5] MR2353: ddraw: SetSurfaceDesc() refactoring, part 3.
by Zebediah Figura (＠zfigura) 14 Mar '23

14 Mar '23

In truth this part is actually just ddraw_surface_create() refactoring, but it came about while working on SetSurfaceDesc()... -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2353

4 8

[PATCH 0/1] MR2390: winegstreamer: Cache wg_parser input data.
by Derek Lesho (＠dlesho) 14 Mar '23

14 Mar '23

On my Steam Deck, this reduces the time it takes to initialize the wg_parser radically (by around 1 second). This helps in the game WILD HEARTS, which doesn't present while loading help videos during gameplay, causing large stutters. Because GStreamer can randomly access the file with no known pattern on our side, I opted to implement this by buffering 4 chunks so that interleaved reads to different areas of the file don't cause us to discard and reload cached data more than we need to. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2390

3 3

Re: [PATCH v2 0/16] MR2386: windows.perception.stub: Implement IHolographicSpaceStatics2/3 interfaces.
by Rémi Bernon (＠rbernon) 14 Mar '23

14 Mar '23

Rémi Bernon (@rbernon) commented about include/windows.graphics.holographic.idl: > +import "windows.graphics.directx.direct3d11.idl"; > +import "windows.perception.idl"; > +import "windows.perception.spatial.idl"; > +import "windows.ui.core.idl"; > + > +namespace Windows.Graphics.Holographic { > + typedef enum HolographicFramePresentResult HolographicFramePresentResult; > + typedef enum HolographicFramePresentWaitBehavior HolographicFramePresentWaitBehavior; > + typedef struct HolographicAdapterId HolographicAdapterId; > + typedef struct HolographicStereoTransform HolographicStereoTransform; > + > + interface IHolographicCameraPose; > + interface IHolographicCameraRenderingParameters; > + interface IHolographicFrame; > + interface IHolographicFramePrediction; > + interface IHolographicSpaceStatics2; If you only forward declare `IHolographicSpaceStatics` here, you don't need its definition later in the file, as you also don't implement it. This then makes 5ec7b6eecc89f2e88df836e1e68c9d59fa640816 ad31506143de193058129e2981818b6e7fc5c252 8fbfa09fd86eb7306688e0914c44964860165a0d 2e1f8bd100e040e8025c5801cecdf7636187582c aaeb3ffc5ce074ddea6a16e5b28788f73b1fd12c also unnecessary, which to be honest, seems appealing to me at least from a review perspective, given the number of new classes and interfaces. Of course, we might need them later and could be useful to keep them around, but then it would be nice to have it done more gradually if possible. Regarding 04ee932ff5e261b9aceee47542f91aa6b4f115c1, and for similar changes, it'd be nice to make smaller additions, for instance adding one interface definition at a time (and its dependencies if they aren't too much, or add them beforehand), so that reviewing what needs what is easier. -- https://gitlab.winehq.org/wine/wine/-/merge_requests/2386#note_26841

1 0

[PATCH v2 0/1] MR2367: comctl32/treeview: Ignore the lParam to WM_PRINTCLIENT and add tests.
by Alex Henrie (＠alexhenrie) 14 Mar '23

14 Mar '23

Wine-Bug: https://bugs.winehq.org/show_bug.cgi?id=54640 -- v2: comctl32/treeview: Ignore the lParam to WM_PRINTCLIENT and add tests. https://gitlab.winehq.org/wine/wine/-/merge_requests/2367

3 2

[PATCH v4 0/4] MR2355: win32u: Keep the current user locale when enumerating layouts.
by Rémi Bernon (＠rbernon) 14 Mar '23

14 Mar '23

-- v4: winex11: Remove now unnecessary user locale change checks. win32u: Prevent user locale change in NtUserActivateKeyboardLayout. win32u: Keep the current user locale when loading layout. win32u: Keep the current user locale when enumerating layouts. https://gitlab.winehq.org/wine/wine/-/merge_requests/2355

2 5

[PATCH 0/4] MR2395: imm32: Implement ImmLoadIME and ImmFreeLayout.
by Rémi Bernon (＠rbernon) 14 Mar '23

14 Mar '23

-- https://gitlab.winehq.org/wine/wine/-/merge_requests/2395

2 4

[PATCH v5 0/3] MR2377: sppc: Add stubs for MS Office.
by Daniel Tang (＠danielzgtg) 14 Mar '23

14 Mar '23

After this and the related MRs, MS Office 365 finally loads. We see the fancy start screen, and we need modify the options to trust the folder we have our Word documents in. This works for `WINWORD.EXE`, `EXCEL.EXE` and `POWERPNT.exe`. I am able to open an existing file and view it. This MR is limited to showing the first page or so of the Word document. It freezes with the Wine crash dialog basically the moment right after the screen is rendered. There is no backtrace in the dialog, but winedbg points to `v8jsi.dll` and so does the console output without winedbg. Creating new documents is not achieved by this MR either. -- v5: Sleep forever in SLOpen. Add SLGetApplicationPolicy stub. Add SLLoadApplicationPolicies stub. https://gitlab.winehq.org/wine/wine/-/merge_requests/2377

4 8

[PATCH v2 0/1] MR2375: wofutil: Stub WofIsExternalFile().
by Daniel Tang (＠danielzgtg) 14 Mar '23

14 Mar '23

This fixes a crash in `OneDriveSetup.exe`. It still doesn't install with "A supported version of Windows 10 or Windows 11 is required to proceed," but at least it doesn't crash. After this patch, we can now see the OneDrive logo, the progress bar, and the "Installing OneDrive" label. -- v2: wofutil: Stub WofIsExternalFile(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2375

4 6

[PATCH v4 0/1] MR2377: sppc: Add stubs for MS Office.
by Daniel Tang (＠danielzgtg) 14 Mar '23

14 Mar '23

After this and the related MRs, MS Office 365 finally loads. We see the fancy start screen, and we need modify the options to trust the folder we have our Word documents in. This works for `WINWORD.EXE`, `EXCEL.EXE` and `POWERPNT.exe`. I am able to open an existing file and view it. This MR is limited to showing the first page or so of the Word document. It freezes with the Wine crash dialog basically the moment right after the screen is rendered. There is no backtrace in the dialog, but winedbg points to `v8jsi.dll` and so does the console output without winedbg. Creating new documents is not achieved by this MR either. -- v4: sppc: Add stubs for MS Office. https://gitlab.winehq.org/wine/wine/-/merge_requests/2377

4 5

[PATCH v2 0/1] MR2379: windows.networking: Stub DllGetActivationFactory().
by Daniel Tang (＠danielzgtg) 14 Mar '23

14 Mar '23

With this MR, now I can create documents in Word. Applied together with my other patches, we will have the 3 main apps of Microsoft Office working! -- v2: windows.networking: Stub DllGetActivationFactory(). https://gitlab.winehq.org/wine/wine/-/merge_requests/2379

2 2

2025

2024

2023

2022

wine-gitlab March 2023